From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA8D4C55199 for ; Mon, 27 Apr 2020 09:31:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB147206A4 for ; Mon, 27 Apr 2020 09:31:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbgD0Jbv (ORCPT ); Mon, 27 Apr 2020 05:31:51 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52802 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726903AbgD0Jbv (ORCPT ); Mon, 27 Apr 2020 05:31:51 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03R92PED072940; Mon, 27 Apr 2020 05:31:34 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 30mhbynh8a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Apr 2020 05:31:34 -0400 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 03R92UXv073589; Mon, 27 Apr 2020 05:31:34 -0400 Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com with ESMTP id 30mhbynh7n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Apr 2020 05:31:33 -0400 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 03R9VOAg006066; Mon, 27 Apr 2020 09:31:32 GMT Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by ppma04dal.us.ibm.com with ESMTP id 30mcu66bj4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Apr 2020 09:31:32 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 03R9VWL053149966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Apr 2020 09:31:32 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E7E0EAC060; Mon, 27 Apr 2020 09:31:31 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2631DAC05F; Mon, 27 Apr 2020 09:31:25 +0000 (GMT) Received: from localhost.localdomain (unknown [9.199.63.250]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 27 Apr 2020 09:31:24 +0000 (GMT) Subject: Re: [PATCH v2 01/11] perf expr: unlimited escaped characters in a symbol To: Jiri Olsa , Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Kan Liang , Andi Kleen , Haiyan Song , Jin Yao , Song Liu , Ravi Bangoria , John Garry , Leo Yan , Adrian Hunter , Paul Clarke , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Stephane Eranian References: <20200422220430.254014-1-irogers@google.com> <20200422220430.254014-2-irogers@google.com> <20200423112905.GG1136647@krava> From: kajoljain Message-ID: <0930a64c-5c33-3527-949b-41ae42fefe52@linux.ibm.com> Date: Mon, 27 Apr 2020 15:01:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20200423112905.GG1136647@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-27_03:2020-04-24,2020-04-27 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004270077 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/23/20 4:59 PM, Jiri Olsa wrote: > On Wed, Apr 22, 2020 at 03:04:20PM -0700, Ian Rogers wrote: >> Current expression allows 2 escaped '-,=' characters. However, some >> metrics require more, for example Haswell DRAM_BW_Use. >> >> Fixes: 26226a97724d (perf expr: Move expr lexer to flex) >> Signed-off-by: Ian Rogers >> --- >> tools/perf/util/expr.l | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/perf/util/expr.l b/tools/perf/util/expr.l >> index 2582c2464938..95bcf3629edf 100644 >> --- a/tools/perf/util/expr.l >> +++ b/tools/perf/util/expr.l >> @@ -73,7 +73,7 @@ number [0-9]+ >> sch [-,=] >> spec \\{sch} >> sym [0-9a-zA-Z_\.:@]+ >> -symbol {spec}*{sym}*{spec}*{sym}* >> +symbol ({spec}|{sym})+ Tested by: kjain@linux.ibm.com Thanks, Kajol Jain > > yep, much better ;-) > > thanks, > jirka > >> >> %% >> struct expr_scanner_ctx *sctx = expr_get_extra(yyscanner); >> -- >> 2.26.2.303.gf8c07b1a785-goog >> >