From: Markus Elfring <Markus.Elfring@web.de>
To: Zhang Qiang <qiang.zhang@windriver.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>, Tejun Heo <tj@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [v3] workqueue: Fix double kfree for rescuer
Date: Tue, 26 May 2020 12:34:36 +0200 [thread overview]
Message-ID: <093e5131-fdee-54fd-e2e1-a632435005b7@web.de> (raw)
In-Reply-To: <9e7c20bd-8161-0790-36de-108c6dae65df@windriver.com>
> There is something wrong with my description. is it feasible to describe as follows:
>
> The resucer is already free in "destroy_workqueue" and
> "wq->rescuer = NULL" was executed, but in "rcu_free_wq"
> it's release again (equivalent to kfree(NULL)), this is
> unnecessary, so should remove.
I find that this suggestion indicates further wording challenges.
Please try another variant.
Regards,
Markus
prev parent reply other threads:[~2020-05-26 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 9:30 [PATCH v3] " qiang.zhang
2020-05-25 10:01 ` Markus Elfring
2020-05-25 10:01 ` Markus Elfring
2020-05-26 8:56 ` Lai Jiangshan
2020-05-26 9:11 ` [v3] " Markus Elfring
2020-05-26 10:04 ` [PATCH v3] " Zhang, Qiang
2020-05-26 10:34 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=093e5131-fdee-54fd-e2e1-a632435005b7@web.de \
--to=markus.elfring@web.de \
--cc=jiangshanlai@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiang.zhang@windriver.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®