From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2162938-1527178787-2-6137116777676910445 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='utf-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-api-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1527178787; b=cPoKPSND9M8ISK0BhTg7+6h245hSr3B/EFjSiITidVXIIP3pVx JypqGbR1BudPCoDYQ/sTYUtV65ZRvRvNF6SLe7bjhZuR3jEbN+B6heLQ5p2K3Iwk GUj2vu9UBCdRWs+0TO8unr3NDwvxuicAHDzWLfd5a/7E5GoJ+Ud0wiX4iyMlhwwr TsXVzQ2vs5R28wpy3IuBGWOx+4JhP2e2+HGmL+wdNuZ+s+Hk+K+zxplzQktI5K8+ Cc/tJmz44rZbwuKbUMrDAdFLMVt8GGSUIX0ky1ORUsFt/h+uo+WYsIZHMuXAhcwU r2yRJlZ06uJnHIviOOJnANn/h/NikUj0jFDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=fm2; t=1527178787; bh=NgNpDm+/HSbX/8TAq0PDJd648J+2MuyExlDXTa0H48s=; b=ZOnNrDWJPSm2 wKYUvCyInSj6AZMmbgAcxKO6LPCS8My9B5AHM8mrxGwd6ND1JTjvexvL2AZCTlVN 57zn88L6eFSXTIZEyVqZUSLk2su1Yi/r6x1xGU69hR2jlM9if2nBzrv06pSTplQD 7i9lvDgny+3rEyqa8pLQUILxTiG5S3lrRlzDKlYHEXJ4oIWtykgJ4DgAAuY+2lRT 2GJjF+RMzKlIdr5kGbEv1oa0ID4Et/zDgBHuQw4CzHSr8fnbCL9Zf0fXYw4lRLSy ZkTRWPnq1KUs1S1KdS/1MtuEPnaf3vNiQFIhHbsr3ShIkrqhovnR7fKpkVjCLo3M xhCkQyGmrQ== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=infradead.org header.i=@infradead.org header.b=lHKk7/p6 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=merlin.20170209; dmarc=none (p=none,has-list-id=yes,d=none) header.from=infradead.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=infradead.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered, 2048-bit rsa key sha256) header.d=infradead.org header.i=@infradead.org header.b=lHKk7/p6 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=merlin.20170209; dmarc=none (p=none,has-list-id=yes,d=none) header.from=infradead.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=infradead.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfPK7AvsRcBhJVfHiW7GHFQ2MJHJsDxDoEvsa8lYzF7QZHsLUhrHIoukEdQ3aT5Ufyggu75YTYeUVKj1a2MY3fWu1yVtUzm8XEx/BdOYA6gHJ8s+ZGO2k hy/YWb5XrfQrnVdNKX0B3sqU1EDMlzPA0gYGymP+iJdtYxjehNa/URwkFA1yloNiRA9nU3EkdOsWU06lzIlrRUZyuA2nZpuHoatFdIq9t6hBDI/p98L2yHOV X-CM-Analysis: v=2.3 cv=FKU1Odgs c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=VUJBJC2UJ8kA:10 a=VwQbUJbxAAAA:8 a=94PGxtta7-7cmXTglaYA:9 a=QEXdDO2ut3YA:10 a=x8gzFH9gYPwA:10 a=AjGcO6oz07-iQ99wixmX:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033520AbeEXQTF (ORCPT ); Thu, 24 May 2018 12:19:05 -0400 Received: from merlin.infradead.org ([205.233.59.134]:49894 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030896AbeEXQTD (ORCPT ); Thu, 24 May 2018 12:19:03 -0400 Subject: Re: [RFC PATCH 0/5] kmalloc-reclaimable caches To: Matthew Wilcox , Vlastimil Babka Cc: linux-mm@kvack.org, Roman Gushchin , Michal Hocko , Johannes Weiner , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Mel Gorman , Vijayanand Jitta References: <20180524110011.1940-1-vbabka@suse.cz> <20180524114350.GA10323@bombadil.infradead.org> From: Randy Dunlap Message-ID: <0944e1ed-60fe-36ce-ea06-936b3f595d5f@infradead.org> Date: Thu, 24 May 2018 09:18:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180524114350.GA10323@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-api-owner@vger.kernel.org X-Mailing-List: linux-api@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 05/24/2018 04:43 AM, Matthew Wilcox wrote: > On Thu, May 24, 2018 at 01:00:06PM +0200, Vlastimil Babka wrote: >> Now for the issues a.k.a. why RFC: >> >> - I haven't find any other obvious users for reclaimable kmalloc (yet) > > Is that a problem? This sounds like it's enough to solve Facebook's > problem. > >> - the name of caches kmalloc-reclaimable-X is rather long > > Yes; Christoph and I were talking about restricting slab names to 16 bytes > just to make /proc/slabinfo easier to read. How about > > kmalloc-rec-128k > 1234567890123456 > > Just makes it ;-) > > Of course, somebody needs to do the work to use k/M instead of 4194304. > We also need to bikeshed about when to switch; should it be: > > kmalloc-rec-512 > kmalloc-rec-1024 > kmalloc-rec-2048 > kmalloc-rec-4096 > kmalloc-rec-8192 > kmalloc-rec-16k > > or should it be > > kmalloc-rec-512 > kmalloc-rec-1k > kmalloc-rec-2k > kmalloc-rec-4k > kmalloc-rec-8k > kmalloc-rec-16k > > I slightly favour the latter as it'll be easier to implement. Something like Yes, agree, start using the suffix early. > > static const char suffixes[3] = ' kM'; > int idx = 0; > > while (size > 1024) { > size /= 1024; > idx++; > } > > sprintf("%d%c", size, suffices[idx]); suffixes > > -- -- ~Randy