mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Wei, Gang" <gang.wei@intel.com>
To: "Woodruff, Richard" <r-woodruff2@ti.com>,
	"Linux Power Management List" <linux-pm@lists.osdl.org>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: RE: [linux-pm] [RFC-PATCH] Improve Menu Governor Prediction of interrupted C states.
Date: Wed, 6 Aug 2008 09:51:14 +0800	[thread overview]
Message-ID: <094BCE01AFBE9646AF220B0B3F367AAB035B08D0@pdsmsx413.ccr.corp.intel.com> (raw)
In-Reply-To: <13B9B4C6EF24D648824FF11BE89671620361F4E439@dlee02.ent.ti.com>

> Hi,
> 
>> I also found current cpuidle Menu governor should have some problems
>> while predicting next non-expected break-event after some expected
>> break-events. The measured_us/elapsed_us/predicted_us will become
larger
>> and larger once (measured_us + BREAK_FUZZ >= data->expected_us -
>> target->exit_latency). The major point is that it should be
>> last_residency, not measured_us, that need to be used to do comparing
>> and distinguish between expected & non-expected events.
>> 
>> Below is my draft patch (not tested) for this. It is simple and
should
>> also be effective for high interrupt rates case.
> 
> This does seem to give better guesses.  However, first tests are not
showing
> as well as the irq time stamp version I posted. 
> 
> I'll need to grab some hardware trace to see what is going on.

Thanks for the trial. My original patch has already been merged into
another patch "[patch 2/3] cpuidle: Menu governor fix wrong usage of
measured_us" sent out by Venkatesh. The new patch should be more intact.

Jimmy

      reply	other threads:[~2008-08-06  1:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14 21:02 Woodruff, Richard
2008-07-22  7:59 ` [linux-pm] " Wei, Gang
2008-07-23 18:59   ` Woodruff, Richard
2008-08-06  1:24   ` Woodruff, Richard
2008-08-06  1:51     ` Wei, Gang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=094BCE01AFBE9646AF220B0B3F367AAB035B08D0@pdsmsx413.ccr.corp.intel.com \
    --to=gang.wei@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=r-woodruff2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®