From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932986AbcFGNuY (ORCPT ); Tue, 7 Jun 2016 09:50:24 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35006 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932607AbcFGNuW (ORCPT ); Tue, 7 Jun 2016 09:50:22 -0400 Subject: Re: [PATCH 3.14 11/23] pipe: Fix buffer offset after partially failed read To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org References: <20160605213826.938892115@linuxfoundation.org> <20160605213828.067815770@linuxfoundation.org> Cc: stable@vger.kernel.org, Ben Hutchings , Willy Tarreau From: Jiri Slaby Message-ID: <094a36ed-163a-8ced-afd2-85bb74d21f4f@suse.cz> Date: Tue, 7 Jun 2016 15:50:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160605213828.067815770@linuxfoundation.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/2016, 11:40 PM, Greg Kroah-Hartman wrote: > 3.14-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Ben Hutchings > > commit feae3ca2e5e1a8f44aa6290255d3d9709985d0b2 upstream. This is not a SHA of an upstream commit ;). > Quoting the RHEL advisory: > >> It was found that the fix for CVE-2015-1805 incorrectly kept buffer >> offset and buffer length in sync on a failed atomic read, potentially >> resulting in a pipe buffer state corruption. A local, unprivileged user >> could use this flaw to crash the system or leak kernel memory to user >> space. (CVE-2016-0774, Moderate) > > The same flawed fix was applied to stable branches from 2.6.32.y to > 3.14.y inclusive, and I was able to reproduce the issue on 3.2.y. > We need to give pipe_iov_copy_to_user() a separate offset variable > and only update the buffer offset if it succeeds. > > References: https://rhn.redhat.com/errata/RHSA-2016-0103.html > Signed-off-by: Ben Hutchings > Cc: Willy Tarreau > Signed-off-by: Greg Kroah-Hartman thanks, -- js suse labs