From: Matteo Martelli <matteo.martelli@codethink.co.uk>
To: Yuri Andriaccio <yurand2000@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Luca Abeni <luca.abeni@santannapisa.it>,
Yuri Andriaccio <yuri.andriaccio@santannapisa.it>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Matteo Martelli <matteo.martelli@codethink.co.uk>
Subject: Re: [PATCH v2] sched/deadline: Remove fair-servers from real-time task's bandwidth accounting
Date: Fri, 25 Jul 2025 20:04:45 +0200 [thread overview]
Message-ID: <094f8017f1d9a76ced80e75168de4cd3@codethink.co.uk> (raw)
In-Reply-To: <20250725164412.35912-1-yurand2000@gmail.com>
Hi Yuri,
On Fri, 25 Jul 2025 18:44:12 +0200, Yuri Andriaccio <yurand2000@gmail.com> wrote:
> ...
> @@ -1688,17 +1690,14 @@ int dl_server_apply_params(struct sched_dl_entity *dl_se, u64 runtime, u64 perio
>
> cpus = dl_bw_cpus(cpu);
> cap = dl_bw_capacity(cpu);
> + max_bw = div64_ul(cap_scale(BW_UNIT - dl_b->bw, cap), (unsigned long)cpus);
This line exceeds 80 characters width. Perhaps it needs to be split.
>
> - if (__dl_overflow(dl_b, cap, old_bw, new_bw))
> + if (new_bw > max_bw)
> return -EBUSY;
> ...
Beside that minor note, I retested the v2 of this patch with the same
tests I ran for v1 [1]. I confirm that stress-ng and runtime variations
commands provide the same results. Also no warning is produced anymore
as I also applied Juri's patch as you suggested [2].
Tested-by: Matteo Martelli <matteo.martelli@codethink.co.uk>
[1]: https://lore.kernel.org/all/86013fcc38e582ab89b9b7e4864cc1bd@codethink.co.uk/
[2]: https://lore.kernel.org/all/20250725152804.14224-1-yurand2000@gmail.com/
next prev parent reply other threads:[~2025-07-25 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 16:44 Yuri Andriaccio
2025-07-25 18:04 ` Matteo Martelli [this message]
2025-08-01 7:37 ` Juri Lelli
2025-08-01 16:03 ` Yuri Andriaccio
2025-08-12 14:18 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=094f8017f1d9a76ced80e75168de4cd3@codethink.co.uk \
--to=matteo.martelli@codethink.co.uk \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yurand2000@gmail.com \
--cc=yuri.andriaccio@santannapisa.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®