From: David Lechner <david@lechnology.com>
To: ahaslam@baylibre.com, gregkh@linuxfoundation.org,
stern@rowland.harvard.edu, khilman@kernel.org, kishon@ti.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v5,3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS
Date: Sat, 19 Nov 2016 21:37:32 -0600 [thread overview]
Message-ID: <094fef2f-5901-5bc4-0574-269364aa8630@lechnology.com> (raw)
In-Reply-To: <26d7b4c1-a7ef-7250-eb6a-270182d279ea@lechnology.com>
On 11/19/2016 09:31 PM, David Lechner wrote:
> On 11/14/2016 08:41 AM, ahaslam@baylibre.com wrote:
>> + ocic_mask |= 1;
>
> I thought that a previous patch got rid of all globals. Why is ocic_mask
> still a global variable?
I suppose if I read the commit message, I will know the answer ;-)
next prev parent reply other threads:[~2016-11-20 3:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 14:40 [PATCH v5 0/5] USB: ohci-da8xx: Add device tree support Axel Haslam
2016-11-14 14:40 ` [PATCH v5 1/5] USB: ohci: da8xx: use ohci priv data instead of globals Axel Haslam
2016-11-20 2:58 ` [v5,1/5] " David Lechner
2016-11-21 9:07 ` Axel Haslam
2016-11-14 14:41 ` [PATCH v5 2/5] USB: ohci: da8xx: Add wrappers for platform callbacks Axel Haslam
2016-11-14 14:41 ` [PATCH v5 3/5] USB: ohci: da8xx: Allow a regulator to handle VBUS Axel Haslam
2016-11-20 3:31 ` [v5,3/5] " David Lechner
2016-11-20 3:37 ` David Lechner [this message]
2016-11-21 10:22 ` Axel Haslam
2016-11-21 16:29 ` David Lechner
2016-11-22 14:18 ` Axel Haslam
2016-11-14 14:41 ` [PATCH v5 4/5] USB: ohci: da8xx: Add devicetree bindings Axel Haslam
2016-11-16 13:26 ` Rob Herring
2016-11-14 14:41 ` [PATCH v5 5/5] USB: ohci: da8xx: Allow probing from DT Axel Haslam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=094fef2f-5901-5bc4-0574-269364aa8630@lechnology.com \
--to=david@lechnology.com \
--cc=ahaslam@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome