From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97363435AA9 for ; Mon, 10 Aug 2026 18:13:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385582; cv=none; b=ZYqUSJL8tDXZ4BWWAo2jUSjzjDo/Z7oTI/ng9aM+5nPpofafFG1Sduy/usYPH/lKynTVKrPlrfzq6J6dLHtui+vuRz90Ce/grrG4KTpfjN5dciwjoPt13KIj5/1/6vp4e7/uR4KYxUPumdXL1cdC/V3qIFsqn2DOg6bxQbImTSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786385582; c=relaxed/simple; bh=E2tVVahiEfiSwa0DcP4d1RfJxRDEhPgKD8HLYsgugx4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GaK8s1vZmzuuVbu8V/LPlNCTmuCRVPVW4zm5NKhHE2XvBJ6CgHB9MBPKQrhywFfk/Wr6iWBl7yiNYAnUnGwWeWCeVJMolu+bdnqFTM/hLJh6gx0B6uozSOGi3a/7o+v8TH3gJAYyqe18nJWgiOpHWP+CkCDUJFnKB0CFL9AyMaM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LHpiw8Os; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LHpiw8Os" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38de840f2f0so1560433a91.0 for ; Mon, 10 Aug 2026 11:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786385579; x=1786990379; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NJJYd1UvvpYlQGN46E9GIRgAsLwA3hYqM6XgiHJz9nQ=; b=LHpiw8Os1NrpRQLvwTrPTx03Ptucq5PTxV8mZ7JxFeinPL0+nNOlHm2YpOQ5IGjjLv A59RooxhSeTWOZ5j77wwmyu7tjxBwkUjzdN/O1Avo5RIAVFCsG/G4KW8BUBU87Ai6B4Z VaM7nlpYkQrbYmlQWgY/qUuLIGOLHT7ihtI11GzbZVfz0rw8UHih1zRpBmwYYKs/zTNB 8V6SW9J2HBJJuwwuR83AngPOMOXJqdOyS+JEB4Ubcd2QVS9M7iVaoYkuAq/V7LmKT5ED 6/sXn8ASeExiqHeoNZw7bMzwU6OKQgwa+B/gkmNo7AnIWqO10S2xPsPR+O364H2lX0ZP Z1Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786385579; x=1786990379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NJJYd1UvvpYlQGN46E9GIRgAsLwA3hYqM6XgiHJz9nQ=; b=fjYgOP6CR72kWrCIMJA+dJnuIkqytdzyYLjiMKN9jn6JhZ3vcW3yLYOgtCrK+EASAk xCGWg3Ky5jYxFjNNo/LDAxBBKe8g3XPTrEvKheYmYlQ89NmsdAArOaim0os20oTjTEah skxtieDbTlHHvHGIHh5wKWc/LK9coxf46lFYi+Vju2N92d11RPwifu2bRPL02x+jkiY0 7M6Z+Fr7EDGyDbx/CyPwZfggQc5QAS/j5lNI/DK7N9HBim9Oyk7fUeC54dQ6xanEgOlb sxS5Kp5ZQo10Wa/WK00PVr0e+EbwO8X2HLErk2aq9Z5J3irOgtnzDV8e99gUuI8GdXTA axQQ== X-Forwarded-Encrypted: i=1; AHgh+RoL1gvVlXEfyQdKoNw7GmPgW03DG9nlwxz4XDK9navL5HIBD5MGj7wLwjaQMUpLjn1zz6ytnSAoN5d+8DM=@vger.kernel.org X-Gm-Message-State: AOJu0YxoKTnM6aGnvn5/J08U6IjFOAi53DVsdLik7UlpYeLI7EmPNmOO 4Y24INOKF7KDP/vtU4oPT6ILg5BmwLuQGNGQulTbyPl/xwCuwxI2I1dp X-Gm-Gg: AR+sD11l7ckfXPS6VEPfBzhs/neVR4/NuRet23fZuuc0CFgFzKjTNa557atcn/l7Bih JayaFvfyCtv5sF+QIbfdnpSpCTq05Xvf13DdSLLOMXciH9N5mcwld3Dhx2e1vOFhGbgieUaIzPx ke4bcNmlQ5jqjD96Mx261eLqCRVg4alcXfDWfGg7kQarV7i8HNCfDoSNI8a9WB1PwvIZbjq/qSt Xrlp9f+nHpaRWWNN+zvw9tuiRCzmRZh+DDnNW4k8CZUkGVkAMnLIPmJHC4eINZC6o7kIPPxgwil WV3Af3pnmvLdUTq8PkWaXmCp1BGQHdc3dzNHtobplRuMo7dRYG788CsOkT7M0vYjQW9DgXScfd4 tekkX4JetG4IzEz2YOB2cZGA5YIH0wx7nE7fE6pzzakVlht8QK3hqTeTerieR1GNcXuZktG9ll6 oJIw0mxYg8ZDDpfx8/KqhH42cFBQrxu0ioPy8jRO4q4+qX8lumk1/7HVxXNdRvB/w= X-Received: by 2002:a17:90b:5350:b0:38f:1a2e:6e56 with SMTP id 98e67ed59e1d1-392822dcc89mr21756290a91.9.1786385579551; Mon, 10 Aug 2026 11:12:59 -0700 (PDT) Received: from cryptic.lan ([2001:569:7fa9:fa00:b1a9:6513:83c6:1d23]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392d53b873asm472795a91.17.2026.08.10.11.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:12:58 -0700 (PDT) From: Allen Pais To: Vinod Koul , Frank Li Cc: Allen Pais , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook Subject: [PATCH v3 23/34] dmaengine: timb_dma: route callbacks via channel BH Date: Mon, 10 Aug 2026 11:09:24 -0700 Message-ID: <0950412c2bdfac1b4014903dada42f4aec055bb8.1786384169.git.allen.lkml@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Schedule per-channel BH work for completions so callbacks run through the dma_chan deferral mechanism while keeping the controller tasklet for IRQ handling. Signed-off-by: Allen Pais --- drivers/dma/timb_dma.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c index 4fc5119854ec..5a2374aab02a 100644 --- a/drivers/dma/timb_dma.c +++ b/drivers/dma/timb_dma.c @@ -438,6 +438,8 @@ static void td_free_chan_resources(struct dma_chan *chan) dev_dbg(chan2dev(chan), "%s: Entry\n", __func__); + dmaengine_kill_bh(&td_chan->chan); + /* check that all descriptors are free */ BUG_ON(!list_empty(&td_chan->active_list)); BUG_ON(!list_empty(&td_chan->queue)); @@ -580,17 +582,25 @@ static void td_tasklet(struct tasklet_struct *t) for (i = 0; i < td->dma.chancnt; i++) if (ipr & (1 << i)) { struct timb_dma_chan *td_chan = td->channels + i; - spin_lock(&td_chan->lock); - __td_finish(td_chan); - if (!list_empty(&td_chan->queue)) - __td_start_next(td_chan); - spin_unlock(&td_chan->lock); + dmaengine_schedule_bh(&td_chan->chan); } ier = __td_ier_mask(td); iowrite32(ier, td->membase + TIMBDMA_IER); } +static void timb_dma_chan_bh(struct dma_chan *chan) +{ + struct timb_dma_chan *td_chan = container_of(chan, struct timb_dma_chan, + chan); + + spin_lock(&td_chan->lock); + __td_finish(td_chan); + if (!list_empty(&td_chan->queue)) + __td_start_next(td_chan); + spin_unlock(&td_chan->lock); +} + static irqreturn_t td_irq(int irq, void *devid) { @@ -697,6 +707,7 @@ static int td_probe(struct platform_device *pdev) INIT_LIST_HEAD(&td_chan->active_list); INIT_LIST_HEAD(&td_chan->queue); INIT_LIST_HEAD(&td_chan->free_list); + dmaengine_init_bh(&td_chan->chan, timb_dma_chan_bh); td_chan->descs = pchan->descriptors; td_chan->desc_elems = pchan->descriptor_elements; -- 2.43.0