From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E70A2C0015E for ; Fri, 11 Aug 2023 16:58:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232879AbjHKQ60 (ORCPT ); Fri, 11 Aug 2023 12:58:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231939AbjHKQ6Y (ORCPT ); Fri, 11 Aug 2023 12:58:24 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B7EE2D7F for ; Fri, 11 Aug 2023 09:58:24 -0700 (PDT) Received: from [192.168.88.20] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3CE77DFB; Fri, 11 Aug 2023 18:57:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1691773032; bh=bShxo1jKF9pYDYG+jLk6w+AipRBx9OfbfoiVO7qx9I4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QJAihD4bh5YnH3QPWKANpmfLLvt5m2cf/M/QW8B0KSrQlYS/zIWfDZFjZ7q6HJu2r +Z7pFGa4PaoP4zB4OA4vlu3ds+m9lSEE604WTUBn6urYkRL18ll6V1EZKuZ0jfBIGs 5XRyEKKj6WBxpZrZSX3zni8btn6CY3kglZ4J5eqY= Message-ID: <095208cc-7966-db1d-4259-567eba9eafec@ideasonboard.com> Date: Fri, 11 Aug 2023 19:58:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 11/11] drm/bridge: tc358768: Add DRM_BRIDGE_ATTACH_NO_CONNECTOR support Content-Language: en-US To: =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Francesco Dolcini Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Aradhya Bhatia References: <20230804-tc358768-v1-0-1afd44b7826b@ideasonboard.com> <20230804-tc358768-v1-11-1afd44b7826b@ideasonboard.com> From: Tomi Valkeinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/08/2023 19:44, Péter Ujfalusi wrote: > > > On 04/08/2023 13:44, Tomi Valkeinen wrote: > > I would rather have a commit message than a blank one. Oops... >> Signed-off-by: Tomi Valkeinen >> --- >> drivers/gpu/drm/bridge/tc358768.c | 64 +++++++++++++++++++++++++++------------ >> 1 file changed, 45 insertions(+), 19 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c >> index ea19de5509ed..a567f136ddc7 100644 >> --- a/drivers/gpu/drm/bridge/tc358768.c >> +++ b/drivers/gpu/drm/bridge/tc358768.c >> @@ -131,8 +131,17 @@ static const char * const tc358768_supplies[] = { >> >> struct tc358768_dsi_output { >> struct mipi_dsi_device *dev; >> + >> + /* Legacy field if DRM_BRIDGE_ATTACH_NO_CONNECTOR is not used */ >> struct drm_panel *panel; >> - struct drm_bridge *bridge; >> + >> + /* >> + * If DRM_BRIDGE_ATTACH_NO_CONNECTOR is not used and a panel is attached >> + * to tc358768, 'next_bridge' contains the bridge the driver created >> + * with drm_panel_bridge_add_typed(). Otherwise 'next_bridge' contains >> + * the next bridge the driver found. >> + */ >> + struct drm_bridge *next_bridge; > > why it is better to call it next_bridge than just bridge? Is there a > prev_bridge also? There is, prev bridge would be the bridge behind tc358768 in the chain. Bridge is tc358768. Next bridge is the following one. Here, it's in the tc358768_dsi_output struct, so bridge is perhaps ok. I just wanted to be extra clear here, as I think it's often called next_bridge in other drivers. Tomi