From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7D7D351C03 for ; Thu, 12 Mar 2026 14:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773324482; cv=none; b=Gjifv6sGfkNK2+11BYTLIBlIE8xDxCzFI+ylTiptF4ethiO3Ki4f34wW2blpCKO2HvzUKH88J0e8UFgEbwboZjkDqjxC1CDSeMg/77Y6Jw8L0qK0IcMf08frZz6eWGVm5or7OtvmSIMgKYD8lndelBdmRUBS3ujE7F8uFSYLuaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773324482; c=relaxed/simple; bh=tijxHpkB1XZlqGPvL+/rIuQOBbP8vGNP9OSJjet1gtw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=k8JuOyxh6ghJvH1hhzCKCLvLr96mzTdaQzbOHk7JV01gKWLyN18Z3fc2JWsJ4NtyH4/lNVtzudZqCE3R8YRKy3OkERpY39F2jJ0DQ4CirnH3NLC3yhBK35uYyp6f7KxnZ0dwx/Uhi61UK603jmG2Hw0oZsBZiElKzKkdiiLwiNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=R6NMG8kH; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kpO61QpC; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="R6NMG8kH"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kpO61QpC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773324479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Khzpn5Mx56KvyAQlDdussK+xDM01SpYAZGq0vABXvB8=; b=R6NMG8kHdKlbMGBRjpDVzEc0VlV8O/ZfH20dOvplvTacUpcrls7IE4jevEYZbTY4yHPb7Y VOGj4FmOuL9dKQNNraOORaFKo5oSTgIAuFsQc4aw8oelQ9ueUyY+ehqE1MIVJBBz4fMCTQ AhGksNJLkb6chUZ6eAT9VnugKewoFXo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-6mYqa5eVMRmeQIyV_g8pFA-1; Thu, 12 Mar 2026 10:07:55 -0400 X-MC-Unique: 6mYqa5eVMRmeQIyV_g8pFA-1 X-Mimecast-MFC-AGG-ID: 6mYqa5eVMRmeQIyV_g8pFA_1773324473 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4853f33b7dbso7873355e9.3 for ; Thu, 12 Mar 2026 07:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1773324473; x=1773929273; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Khzpn5Mx56KvyAQlDdussK+xDM01SpYAZGq0vABXvB8=; b=kpO61QpCYMTMtIbLDVpyhDbv7qRo1OJLcgCnAE+C1SG4kziPaq43QCZVnPnBSAor8B PjqDJ4FbaEvrzC57yuYUA35xJbb+m7qhwQKFqjBO+rlGjNLcMw0+01Q8WK4SjZV4U4rY Srh7QLlK3IN3e9561/Aezk/UZ39Uf5rTwcPQrAgweOxRtmtluutFXv2529U7c0hEjkWs 6IKCwWV2vq6zX2HC4S2562jo/bSDM3U7BWaZ/o56lQdrPmgyh7AlqJhs9fbMX7jRvYtT b2f9WCUQYQQX6zX/yrFZ3VXvnKKxFCHGlbzPleHHCYnEXN0bRHsevZ22eubdfUd/DI1w 4iVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773324473; x=1773929273; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Khzpn5Mx56KvyAQlDdussK+xDM01SpYAZGq0vABXvB8=; b=gtf6U74+OSWptne0nZOln1MlleCqBb54x31mwRS/byJcFg1mTQagYpTC26ohGg4H48 qBzJuI+b2M0n6MzG5YKEL4MOH5Pq/kMNxNu/gstOOyRSok/o4pc+rcc0Aqv7H2DGTT2Z 5VO2T01K4u7Nbn3dqRxRhyRUeIdBwNwlSu1tPlVqMkwpGxkODOIJJqRscwNcLpI2rrCR wxBfkbYu2uNjkVzsqK26yu9Um4xIvcabNs+hpHJmGHbWNpq5RZKGoE67Ta1OKxSfR6Df S8v3VqflO2Go6qEIn/0tD+vWBpUw7OqE51YDE1tSEI6TMDCrp3UtZQEDpeT2Q41sBqrI E6Og== X-Forwarded-Encrypted: i=1; AJvYcCXY33GROe8C2r5CH8kpLPby1UmtlrPwq4eCk/aAxt5TJ1u5mHQ3wEe/tKCfipDQ7RJU5oIxExZBnK278Mc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyepepu8slI7kqu2g/NPiRhucQWlLgRGvvea5nFtrBpzRBO+9dW RwcLVvVE6vsg2iUtwBv1pQNm8KSA1f34NfOnn4IAHAaqlm7pahTJp6aoQT4K2Ei5G6vjyCYtBWg RCSibQcOQ6HBHVzEsNmKpTrJRcaPSjZGNp/YXp2Dc+mNCbUC+/kPkc5DaR2u/aFcDIw== X-Gm-Gg: ATEYQzx8s+ZwiChuqBUarnkDyHsBMuLLbGJFbYQRv/j/2TpoHzchAsyt4NeE8MiV0ey NxIDfBE7uLv8LH82XjVlBzd3AWfc+TyR8n76Ew8FdkWoOf16vOTLlJ7cIe903DU4KxvvkixrU6k s6D6TreKmn9A94E6E7AjVjk/fNU2zPHSMs3QBoQwSK8bfEaYBhlNcPQvax6gB6v9LM9DuMmEc68 m/kgV+fSJb5LssRFfkD0qmRafrzTt/LEYl+2QkljrKy5cPoydnbKwyaYxZysm+Z7yPJAj+pURNs T3hd6bIfAmSdmX8LNHtfwGIHv5sIN7uCoDOaMpM2GQNZDj3H3eEuYaiY/ho4PO5Rk8iLqA4vSSh Rjbh9j+svLKRpdaxK/qT5GC3mzU8xyOCjgiyrUC+PVlffRrfmaZgCa9A= X-Received: by 2002:a05:600c:8b0a:b0:485:3ae8:2236 with SMTP id 5b1f17b1804b1-4854b123cd6mr107431225e9.32.1773324473112; Thu, 12 Mar 2026 07:07:53 -0700 (PDT) X-Received: by 2002:a05:600c:8b0a:b0:485:3ae8:2236 with SMTP id 5b1f17b1804b1-4854b123cd6mr107430595e9.32.1773324472680; Thu, 12 Mar 2026 07:07:52 -0700 (PDT) Received: from [192.168.88.32] ([216.128.11.95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4854b6756e4sm154581925e9.15.2026.03.12.07.07.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Mar 2026 07:07:52 -0700 (PDT) Message-ID: <09528d3a-e08a-4942-aff7-b59610f6b13e@redhat.com> Date: Thu, 12 Mar 2026 15:07:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH resend net-next 1/1] net: stmmac: actually error requests to change the auxiliary snapshot capture channel To: david.laight.linux@gmail.com, Johannes Zink , Alexandre Torgue , =?UTF-8?Q?Alexis_Lothor=C3=A9?= , Andrew Lunn , Bartosz Golaszewski , Chen-Yu Tsai , "David S. Miller" , Eric Dumazet , Gatien Chevallier , Jakub Kicinski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , Maxime Coquelin , netdev@vger.kernel.org, "Russell King (Oracle)" , Richard Cochran References: <20260310140155.3359-1-david.laight.linux@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260310140155.3359-1-david.laight.linux@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/10/26 3:01 PM, david.laight.linux@gmail.com wrote: > From: David Laight > > Commit 2ddd05d1d5ed ("net: stmmac: do not silently change auxiliary snapshot capture channel") > added code that attempted to return -EBUSY to a PTP_CLK_REQ_EXTTS > request whan a snapshot was already enabled. > However it tested bits in 'acr_value' after they had been masked off > so the check would never return an error. > > Change the code so that the test actually works. > Note that when the commit message says: > Previously in case of a PTP_CLK_REQ_EXTTS request, previously active > auxiliary snapshot capture channels were silently dropped and the new > channel was activated. > this only refers to two commits earlier (a few minutes earlier). > Prior to that only a single fixed snapshot channel could be enabled. > > Note that the check will reject requests to re-enable the currently > enabled channel. > Plausibly the best fix is just to delete the check completely. I agree with this last statement. Enforcing the check could potentially break the user-space. /P