From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787962E8E10 for ; Wed, 19 Nov 2025 15:35:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763566508; cv=none; b=h3VuGbKk6+hkZOjhA3IrHy0+o9cH1dcypGxPL2NR0Xb8grWl9tpR42O4ZMUhmbhCeLAjKmw/pWHr3ZDSYJLrOnias+h9Na1VtVuSilsraZ1AljQbNVEilda55Pl29BuNreCXtodPM5+noCoR+S/yFByGUnBBEfruToNgJarYagM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763566508; c=relaxed/simple; bh=aWyowoKzJF3LmxjEa5m+k7Ul+P3W6nIhOolyl6OYx8w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DeVnW60v9pGTNiez5At2lv+YdRnxIAGuQWNgDjcwTFvgpzOTeXPuwkQwymTG1UI1aO24+64vdd0eklywC6p81PhWkZrTWgLALjj0wJDz/qqZOfnox0yG9EEkSv6k4kYIU8OG88NeJZfORS+4qvVf60jJ26rYsuapcXSvkwjTzWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iNnE/g2Q; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=F493pHeK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iNnE/g2Q"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="F493pHeK" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AJBe2JC536943 for ; Wed, 19 Nov 2025 15:35:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5tDx7NYoUx/VPGlaHHPKM3CRY4d7jWYFUAKx3QSgPPc=; b=iNnE/g2QxMbUwlEa 9ioCWGkIOXGOarAHE1hmxgUqCSNQ1mXwTyBVkQdkp3X3IqDd1QeoVDhlM1nVZKTt WkYzDSa6RFyl309HGcvGEJnpet/mK/MI0gBrfpkiRoCFPLEt3s+QstJ4R+BIJubW 8OWx/NFZT5oMY74MY0LPCDMDD9LMM0EIfVb04SKAy3BRqH8dmI3+1U/LccmTRbDI sP1nkLeMfj6CwuHEvJj3vOpLu2NGUrIkUA5H3uhgZENCEwwglU/axDT8if1WK5hO y98O/Nx/VYOKm+c1YhylxqqofrzAH7R9Iln6fm1mOSB/zqtcPC2a/Dhg0s6863XU oV7ViA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ah65t20yr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Nov 2025 15:35:05 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ed79dd4a47so215465301cf.3 for ; Wed, 19 Nov 2025 07:35:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763566504; x=1764171304; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5tDx7NYoUx/VPGlaHHPKM3CRY4d7jWYFUAKx3QSgPPc=; b=F493pHeKb/xNfZ/NXV2SRLPjSU2NBZ6YYB2T1cCqJB08KvViTWCcYZhqo+5zDrtXqQ 20X9fHIK1xZSAfPlRXso4Gp8L/NrjJB98XJ09VhEwm6FXAbtanVqhiQYYNeJlBnE8wqI VLcysVjgz88CfcJfsVAR6hR5RenRmpNGUpnmYYeebGRHd1wnBOIDcXvVVWf+THinWjAD x/m5pXsmjoLx6at2VArRBKEqsscCIGoRRs7oAQfIEfQDkoLull/Ajyjv1hyxS0rrZpvi Xg3m9AwCW8m849R8lu50yN+P0Sy9V0go3Ina9UUwl5xbFPsFay2ledlWTBB8fT3lKttD MJSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763566504; x=1764171304; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5tDx7NYoUx/VPGlaHHPKM3CRY4d7jWYFUAKx3QSgPPc=; b=vc8kGyL3402fa6irt22GjCivmOKXcZUGGySZGgprmpS+dOMlVHnaic9jEdBCT9wY1Z z3RU2D+eOXFWnTFQjClWyJbOAmVC/tVo0wKh1Q2nSsNC6JLzM8PvQnFAOUtlNTUOsSDw 9AsbXpNu7iU56tlCPr2FL2d+IVwbEaGWgX28qmrybz8t7LCp59sOO38G8FRWW5/1hi6G glEcAG1Kd0DtuCE49Pmg9Lkn+PGMVJ7U1rwHC2DK46HpNpjJa9TSHiIPXexXqgehczRf UkOOzLaat6IT5zBf4lQMRxFCxzyWNAd1NyzjkYieUV6PS9sYWklmhhRpmkyfaDDhcGqr JkyA== X-Forwarded-Encrypted: i=1; AJvYcCU9KKaQ1XgvQMz79pftHq0zFnFAQ/qWi7wb/wKrhMjJS2uHrFFEPgliSAyuE1KmPTvgaOirWprBBva0JA4=@vger.kernel.org X-Gm-Message-State: AOJu0YxDKa9VxmnW1pBMN8xYi5tX89IuTq1LC005X2Xm/jGL4EO9zVgM tasEUP99WqFDustjJSpGkRgN8hG4NCGMhJ6jQukbiCzCXBcvvLR8HpaxnQBdixsOGI9LLMJiMdc MP5xpoOZtqT+UeYqM2U358sXPeq0ivkP9ePrHv5lSn1n8usE+i4D9FT2XWmtGJQwvOpI= X-Gm-Gg: ASbGnctY7KV0UwPxkaRts1kXec58ywgqymf8ww6rehZv/Oxi45L58Gu8w/CoRYhEGsQ i9uXSVs3kjRdRamUEocgIl1RAxPygypC0JoC9JjBFRWaz4eg1DjKgiCUDbQd3MsAlMdiOcxdp7J zeLiX+ZmjaxKsptPWDXi4/JtCtIZZl6ZEzfRt7qpDpgCr/drDtP4mKXeT5WKImrdZDqDky4BAMw /FzH1r64AMSmOIdyNdMXgWbCyfGsWaddKE8g47sbUjVIdyolqpznnwTyI9oIDqYgy/HP7MVEmUZ VbbF0Dix1E2AEvTDC0jRL/hjQH/VFarciErYjuQ7ArfhsUx77bmsovUb1VOFNqEqN36LeIYVrz3 GVlEE1e34lBdS0uWtYRVQic8RPTbtNWWuF+vw X-Received: by 2002:a05:622a:15d2:b0:4e8:aa9d:f0d9 with SMTP id d75a77b69052e-4edf2130595mr249093771cf.38.1763566504075; Wed, 19 Nov 2025 07:35:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFq352RyfTxaD/m6203E2Uf8xLboRspl8BPd52ftBjqoQTWmB0XosHeuF+KICNiiS5/juTXJA== X-Received: by 2002:a05:622a:15d2:b0:4e8:aa9d:f0d9 with SMTP id d75a77b69052e-4edf2130595mr249093091cf.38.1763566503498; Wed, 19 Nov 2025 07:35:03 -0800 (PST) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 2adb3069b0e04-595803b33basm4791604e87.36.2025.11.19.07.34.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 07:35:03 -0800 (PST) Message-ID: <0954c4f6-a50e-477a-9354-0f7c497f6f4b@oss.qualcomm.com> Date: Wed, 19 Nov 2025 15:34:57 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/9] ASoC: codecs: lpass-wsa-macro: remove mix path event To: Jonathan Marek , linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "open list:QCOM AUDIO (ASoC) DRIVERS" , open list References: <20251117051523.16462-1-jonathan@marek.ca> <20251117051523.16462-3-jonathan@marek.ca> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20251117051523.16462-3-jonathan@marek.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=avK/yCZV c=1 sm=1 tr=0 ts=691de3a9 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RAbU-raeAAAA:8 a=EUspDBNiAAAA:8 a=Bn-LY-kQ7RkP1ue-7dgA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=JiizpSU_mAIq9zsZDqn2:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE5MDEyNCBTYWx0ZWRfXyu0vRo/+QeA2 K+Ro/xe1EX7ehSPHMHJfB7c+YYcvWCIh49HxO3jNnNx6A8SKv7g5lvGAIuCJkT8F/Tp77d2wVk5 /6TROOaC00ARuues/Myz3UztnrQSFXk9K+0dmd6UT/62Hgq5TmirmK6jzW4YYyaYKZ/uUYszJTT NMM9jGTIVjkZYspTYorJp14QopcB/8uj9Bi35mWecfuk0WZYAPz2fCi98cf5W4xbNdqHKmbKR4t dLx0p0EKIt/punMTvDZxWr4elqvR9i+UCtv7VzRcG145MS324iffZgcKZkcvioljSiKYnBxe+vQ rPZvD3LlZO1v9wNjEjmvX3FFo9qDO/5dXLA/s0L07YEAWuZSJGceF+Mc4tPqNiBhAzD6eYlieoY cZm3PAzTsvc8JwXIuKjm/828A9kZwA== X-Proofpoint-GUID: mtAeDgO-kJz7O-JLlHeePJeo1bzC7yE6 X-Proofpoint-ORIG-GUID: mtAeDgO-kJz7O-JLlHeePJeo1bzC7yE6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-19_04,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 adultscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511190124 On 11/17/25 5:15 AM, Jonathan Marek wrote: > All it does it disable the mix path clk bit, but this is already managed by > the WSA_RX_MIX0_CLK/WSA_RX_MIX1_CLK supplies. > > Signed-off-by: Jonathan Marek > --- Tested-by: Srinivas Kandagatla #on T14s Reviewed-by: Srinivas Kandagatla > sound/soc/codecs/lpass-wsa-macro.c | 46 +++--------------------------- > 1 file changed, 4 insertions(+), 42 deletions(-) > > diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c > index 6f16d54aee401..06570e474c850 100644 > --- a/sound/soc/codecs/lpass-wsa-macro.c > +++ b/sound/soc/codecs/lpass-wsa-macro.c > @@ -1563,36 +1563,6 @@ static int wsa_macro_enable_vi_feedback(struct snd_soc_dapm_widget *w, > return 0; > } > > -static int wsa_macro_enable_mix_path(struct snd_soc_dapm_widget *w, > - struct snd_kcontrol *kcontrol, int event) > -{ > - struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); > - u16 path_reg; > - > - switch (w->shift) { > - case WSA_MACRO_RX_MIX0: > - path_reg = CDC_WSA_RX0_RX_PATH_MIX_CTL; > - break; > - case WSA_MACRO_RX_MIX1: > - path_reg = CDC_WSA_RX1_RX_PATH_MIX_CTL; > - break; > - default: > - return 0; > - } > - > - switch (event) { > - case SND_SOC_DAPM_POST_PMU: > - break; > - case SND_SOC_DAPM_POST_PMD: > - snd_soc_component_update_bits(component, path_reg, > - CDC_WSA_RX_PATH_MIX_CLK_EN_MASK, > - CDC_WSA_RX_PATH_MIX_CLK_DISABLE); > - break; > - } > - > - return 0; > -} > - > static void wsa_macro_hd2_control(struct snd_soc_component *component, > u16 reg, int event) > { > @@ -2475,30 +2445,22 @@ static const struct snd_soc_dapm_widget wsa_macro_dapm_widgets_v2_1[] = { > SND_SOC_DAPM_MUX("WSA_RX0 INP0", SND_SOC_NOPM, 0, 0, &rx0_prim_inp0_mux_v2_1), > SND_SOC_DAPM_MUX("WSA_RX0 INP1", SND_SOC_NOPM, 0, 0, &rx0_prim_inp1_mux_v2_1), > SND_SOC_DAPM_MUX("WSA_RX0 INP2", SND_SOC_NOPM, 0, 0, &rx0_prim_inp2_mux_v2_1), > - SND_SOC_DAPM_MUX_E("WSA_RX0 MIX INP", SND_SOC_NOPM, WSA_MACRO_RX_MIX0, > - 0, &rx0_mix_mux_v2_1, wsa_macro_enable_mix_path, > - SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD), > + SND_SOC_DAPM_MUX("WSA_RX0 MIX INP", SND_SOC_NOPM, 0, 0, &rx0_mix_mux_v2_1), > SND_SOC_DAPM_MUX("WSA_RX1 INP0", SND_SOC_NOPM, 0, 0, &rx1_prim_inp0_mux_v2_1), > SND_SOC_DAPM_MUX("WSA_RX1 INP1", SND_SOC_NOPM, 0, 0, &rx1_prim_inp1_mux_v2_1), > SND_SOC_DAPM_MUX("WSA_RX1 INP2", SND_SOC_NOPM, 0, 0, &rx1_prim_inp2_mux_v2_1), > - SND_SOC_DAPM_MUX_E("WSA_RX1 MIX INP", SND_SOC_NOPM, WSA_MACRO_RX_MIX1, > - 0, &rx1_mix_mux_v2_1, wsa_macro_enable_mix_path, > - SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD), > + SND_SOC_DAPM_MUX("WSA_RX1 MIX INP", SND_SOC_NOPM, 0, 0, &rx1_mix_mux_v2_1), > }; > > static const struct snd_soc_dapm_widget wsa_macro_dapm_widgets_v2_5[] = { > SND_SOC_DAPM_MUX("WSA_RX0 INP0", SND_SOC_NOPM, 0, 0, &rx0_prim_inp0_mux_v2_5), > SND_SOC_DAPM_MUX("WSA_RX0 INP1", SND_SOC_NOPM, 0, 0, &rx0_prim_inp1_mux_v2_5), > SND_SOC_DAPM_MUX("WSA_RX0 INP2", SND_SOC_NOPM, 0, 0, &rx0_prim_inp2_mux_v2_5), > - SND_SOC_DAPM_MUX_E("WSA_RX0 MIX INP", SND_SOC_NOPM, WSA_MACRO_RX_MIX0, > - 0, &rx0_mix_mux_v2_5, wsa_macro_enable_mix_path, > - SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD), > + SND_SOC_DAPM_MUX("WSA_RX0 MIX INP", SND_SOC_NOPM, 0, 0, &rx0_mix_mux_v2_5), > SND_SOC_DAPM_MUX("WSA_RX1 INP0", SND_SOC_NOPM, 0, 0, &rx1_prim_inp0_mux_v2_5), > SND_SOC_DAPM_MUX("WSA_RX1 INP1", SND_SOC_NOPM, 0, 0, &rx1_prim_inp1_mux_v2_5), > SND_SOC_DAPM_MUX("WSA_RX1 INP2", SND_SOC_NOPM, 0, 0, &rx1_prim_inp2_mux_v2_5), > - SND_SOC_DAPM_MUX_E("WSA_RX1 MIX INP", SND_SOC_NOPM, WSA_MACRO_RX_MIX1, > - 0, &rx1_mix_mux_v2_5, wsa_macro_enable_mix_path, > - SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD), > + SND_SOC_DAPM_MUX("WSA_RX1 MIX INP", SND_SOC_NOPM, 0, 0, &rx1_mix_mux_v2_5), > }; > > static const struct snd_soc_dapm_route wsa_audio_map[] = {