From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B92C43EB80B for ; Tue, 24 Mar 2026 12:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774354804; cv=none; b=qJmuQ+udfeEWkrVrNVFb4kKai46htYoPyFGV2A6iskYxQG9ZjVfE0o6DZrnXRJpZ1DJ6vRksewvP9m13vasIqY92rMM151DmsjGdyZXl8YNw0uV+LRp/OdCi9XbN+ATeCcjj8S7k1gayNejTPxbFC0XXVAezjpwJeyLFVz8Ei+g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774354804; c=relaxed/simple; bh=nBpcshDUXGsdJq19WufZSbR45lWJYXUT8cWL/8Uyqxg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fqOv9Mwnoyy5PAwCKm15wavGxLZ9bB1xiKvoiRI/eWbTPir6resMrV8SCYdZmpH+PHckW7dD2L145+u2hodOQ3aLrNJf5fXdeWel4LdMsfbLQvnM1vhXA2QFfXOVR7kra8FcPHlAYkwnCcyhR+eFeZ72FZQZYeOcno+pbBeUyrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E176/AhE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E176/AhE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE4B3C2BCB1; Tue, 24 Mar 2026 12:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774354804; bh=nBpcshDUXGsdJq19WufZSbR45lWJYXUT8cWL/8Uyqxg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E176/AhErzCouvY3ETmgNShe8DY3jmhd2QAAePt1i+d8smXGBpjT73b+WJ3HX8mTx W+7sIromtOyZ6uD6pJX+avK8yrfPe/G+8jjRTQ6pkYoVho9fXlNnmKUykIbnTLkO1O O+UeQGhB49v0Ibm+X+oogwRU5Dh9ehpZui5UjS+jP/8pe3zjbvP2K+l1iG+h38j1E4 b1ExbsQO2EyJ39LjR9jyzBvQjifLZYFQRqZs3rRyIplBFd7Z0sfVFUGw5o3GjOGCmR C9Cu1ccXhRPQ95nqNOOgvXks0UkOEqIdHWk6UdR1CxV/pzOEsG2A0X6nsLmjQwc0hQ D1aY8EKqE6OoQ== Date: Tue, 24 Mar 2026 12:20:01 +0000 From: "Lorenzo Stoakes (Oracle)" To: Qi Zheng Cc: hannes@cmpxchg.org, hughd@google.com, mhocko@suse.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, david@kernel.org, ziy@nvidia.com, harry.yoo@oracle.com, yosry.ahmed@linux.dev, imran.f.khan@oracle.com, kamalesh.babulal@oracle.com, axelrasmussen@google.com, yuanchu@google.com, weixugc@google.com, chenridong@huaweicloud.com, mkoutny@suse.com, akpm@linux-foundation.org, hamzamahfooz@linux.microsoft.com, apais@linux.microsoft.com, lance.yang@linux.dev, bhe@redhat.com, usamaarif642@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qi Zheng Subject: Re: [PATCH 1/3] mm: memcontrol: correct the type of stats_updates to unsigned long Message-ID: <095a503f-6967-45f1-99c0-03d4fc3baf0b@lucifer.local> References: <74022705dc8d5209ff7e603a178044fe4cfbae09.1774342371.git.zhengqi.arch@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74022705dc8d5209ff7e603a178044fe4cfbae09.1774342371.git.zhengqi.arch@bytedance.com> (-cc old mail) On Tue, Mar 24, 2026 at 07:31:27PM +0800, Qi Zheng wrote: > From: Qi Zheng > > Now, the memcg_rstat_updated() is for vmstats_percpu->state and Now? Did this change? If so, please put commit here in commit xxx ("blah") format, I don't want to have to try and look it up :P > lruvec_stats_percpu->state, which are both of type long, so let's change > the type of stats_updates to unsigned long as well. Is this a bug whereby before this could be overflowed? Or are you deciding to make these long now? Because it seems that are proactively making this change _yourself_. This comment message needs a lot more explanation. > > Signed-off-by: Qi Zheng > --- > mm/memcontrol.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index a47fb68dd65f1..7fb9cbc10dfbb 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -608,7 +608,7 @@ static inline int memcg_events_index(enum vm_event_item idx) > > struct memcg_vmstats_percpu { > /* Stats updates since the last flush */ > - unsigned int stats_updates; > + unsigned long stats_updates; > > /* Cached pointers for fast iteration in memcg_rstat_updated() */ > struct memcg_vmstats_percpu __percpu *parent_pcpu; > @@ -639,7 +639,7 @@ struct memcg_vmstats { > unsigned long events_pending[NR_MEMCG_EVENTS]; > > /* Stats updates since the last flush */ > - atomic_t stats_updates; > + atomic_long_t stats_updates; > }; > > /* > @@ -665,16 +665,16 @@ static u64 flush_last_time; > > static bool memcg_vmstats_needs_flush(struct memcg_vmstats *vmstats) > { > - return atomic_read(&vmstats->stats_updates) > > + return atomic_long_read(&vmstats->stats_updates) > > MEMCG_CHARGE_BATCH * num_online_cpus(); > } > > -static inline void memcg_rstat_updated(struct mem_cgroup *memcg, int val, > +static inline void memcg_rstat_updated(struct mem_cgroup *memcg, long val, > int cpu) > { > struct memcg_vmstats_percpu __percpu *statc_pcpu; > struct memcg_vmstats_percpu *statc; > - unsigned int stats_updates; > + unsigned long stats_updates; > > if (!val) > return; > @@ -697,7 +697,7 @@ static inline void memcg_rstat_updated(struct mem_cgroup *memcg, int val, > continue; > > stats_updates = this_cpu_xchg(statc_pcpu->stats_updates, 0); > - atomic_add(stats_updates, &statc->vmstats->stats_updates); > + atomic_long_add(stats_updates, &statc->vmstats->stats_updates); > } > } > > @@ -705,7 +705,7 @@ static void __mem_cgroup_flush_stats(struct mem_cgroup *memcg, bool force) > { > bool needs_flush = memcg_vmstats_needs_flush(memcg->vmstats); > > - trace_memcg_flush_stats(memcg, atomic_read(&memcg->vmstats->stats_updates), > + trace_memcg_flush_stats(memcg, atomic_long_read(&memcg->vmstats->stats_updates), > force, needs_flush); > > if (!force && !needs_flush) > @@ -4406,8 +4406,8 @@ static void mem_cgroup_css_rstat_flush(struct cgroup_subsys_state *css, int cpu) > } > WRITE_ONCE(statc->stats_updates, 0); > /* We are in a per-cpu loop here, only do the atomic write once */ > - if (atomic_read(&memcg->vmstats->stats_updates)) > - atomic_set(&memcg->vmstats->stats_updates, 0); > + if (atomic_long_read(&memcg->vmstats->stats_updates)) > + atomic_long_set(&memcg->vmstats->stats_updates, 0); > } > > static void mem_cgroup_fork(struct task_struct *task) > -- > 2.20.1 >