From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5716FC4167D for ; Mon, 13 Nov 2023 00:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232685AbjKMA7q (ORCPT ); Sun, 12 Nov 2023 19:59:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230394AbjKMA7p (ORCPT ); Sun, 12 Nov 2023 19:59:45 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37FAF1BD4 for ; Sun, 12 Nov 2023 16:58:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699837137; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cDT/Yw6MepTUY5berRyzp+iGTh5/71yTqnFQ/kYgufg=; b=F2nQ34+LtuVNAzyHYMhY7XKF8bKgDNlg2lTV3kPzOyfNVqMTnoyZycOp3/kc191s/cPkOT X9y36lz/hegBsN5yN0+KnUJa1Wh3z27wNu1V7y1dhKJHdpVpaZ/Uzz59iae17ivmd+/piC IaPEuDzPSDJOa3dvZmFTGJa+XSk1Ruo= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-596-gILUsjvIPJaVSlaQY4mcTQ-1; Sun, 12 Nov 2023 19:58:56 -0500 X-MC-Unique: gILUsjvIPJaVSlaQY4mcTQ-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1cc4cab731dso37756415ad.1 for ; Sun, 12 Nov 2023 16:58:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699837135; x=1700441935; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cDT/Yw6MepTUY5berRyzp+iGTh5/71yTqnFQ/kYgufg=; b=YTbaWVctYbQbGYo/qa6p8TUok685LNsAx6S9YJxpyA52l8FG9yIkUT7pMr0lI4xGQx 5acF52h3mdYA19mR9NHCa1FXrH3BGuVFONfYxEQ4gVWgnNrz+mI012lQF+kNEpZKr4XV Y+6DSl0JhAZUxmdC9Q8Kn82/qF8mKUHAlJOZV8BOggj+76P+nZ3SVrXICCLzGjgb+3Yx NifPWqWfWHpJQjIntMDV03bKGcG76+Wm/DHJT04vykRfbUM7tt/DM0KJZ96gihb4T/vZ 8WTonBtm4ISkq0X52s0ZOgb3gt5jxpL9E7lBWeuhVhuIl8I3BXChOKhgLAbbDeDPImxf cBxQ== X-Gm-Message-State: AOJu0YytGKKhAIZvZ1CPvBINF5CeZjoLuU/XRo2dHfZyJ7rIQ9nxnJCX h6KfRoSq98Xi5Xsj8yQNCcz3lnGgU+FkO7I5dvekIqgH3dWmzc9mrD6tc7s4A0t015+c1ULI4vo y0hohzPa/H4beP87PO5ULnpw6 X-Received: by 2002:a17:903:18a:b0:1c5:d063:b70e with SMTP id z10-20020a170903018a00b001c5d063b70emr3527465plg.53.1699837134995; Sun, 12 Nov 2023 16:58:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYIxs5W0nH5PRlEPeC7HszJcExOhwxIk5eQviHGK0uTrxM/8D+SW3tGS+WkqqASqjIUf7rPA== X-Received: by 2002:a17:903:18a:b0:1c5:d063:b70e with SMTP id z10-20020a170903018a00b001c5d063b70emr3527451plg.53.1699837134747; Sun, 12 Nov 2023 16:58:54 -0800 (PST) Received: from ?IPV6:2001:8003:e5b0:9f00:b890:3e54:96bb:2a15? ([2001:8003:e5b0:9f00:b890:3e54:96bb:2a15]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c24d00b001c5fc291ef9sm3053276plg.209.2023.11.12.16.58.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Nov 2023 16:58:54 -0800 (PST) Message-ID: <095c2d24-735b-4ce2-ba2e-9ec2164f2237@redhat.com> Date: Mon, 13 Nov 2023 10:58:46 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 10/22] drivers: base: Move cpu_dev_init() after node_dev_init() Content-Language: en-US To: "Russell King (Oracle)" , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org Cc: Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, James Morse , Greg Kroah-Hartman , "Rafael J. Wysocki" References: From: Gavin Shan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/7/23 20:30, Russell King (Oracle) wrote: > From: James Morse > > NUMA systems require the node descriptions to be ready before CPUs are > registered. This is so that the node symlinks can be created in sysfs. > > Currently no NUMA platform uses GENERIC_CPU_DEVICES, meaning that CPUs > are registered by arch code, instead of cpu_dev_init(). > > Move cpu_dev_init() after node_dev_init() so that NUMA architectures > can use GENERIC_CPU_DEVICES. > > Signed-off-by: James Morse > Signed-off-by: Russell King (Oracle) > --- > Note: Jonathan's comment still needs addressing - see > https://lore.kernel.org/r/20230914121612.00006ac7@Huawei.com > --- > drivers/base/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > With Jonathan's comments addressed: Reviewed-by: Gavin Shan