From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751042AbdE3H1S (ORCPT ); Tue, 30 May 2017 03:27:18 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37102 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750839AbdE3H1R (ORCPT ); Tue, 30 May 2017 03:27:17 -0400 Subject: Re: [PATCH v5 02/10] drm: Introduce drm_bridge_mode_valid() To: Jose Abreu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <36bd5e054496ad3c9c71f1ffe204f28533f55f1e.1495720737.git.joabreu@synopsys.com> Cc: Carlos Palminha , Laurent Pinchart From: Neil Armstrong Organization: Baylibre Message-ID: <095dd0d3-2d1a-4882-70aa-79239af99cc9@baylibre.com> Date: Tue, 30 May 2017 09:27:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <36bd5e054496ad3c9c71f1ffe204f28533f55f1e.1495720737.git.joabreu@synopsys.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2017 04:19 PM, Jose Abreu wrote: > Introduce a new helper function which calls mode_valid() callback > for all bridges in an encoder chain. > > Signed-off-by: Jose Abreu > Reviewed-by: Daniel Vetter > Cc: Carlos Palminha > Cc: Ville Syrjälä > Cc: Dave Airlie > Cc: Andrzej Hajda > Cc: Archit Taneja > Cc: Laurent Pinchart > --- > drivers/gpu/drm/drm_bridge.c | 33 +++++++++++++++++++++++++++++++++ > include/drm/drm_bridge.h | 2 ++ > 2 files changed, 35 insertions(+) > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > index 86a7637..dc8cdfe 100644 > --- a/drivers/gpu/drm/drm_bridge.c > +++ b/drivers/gpu/drm/drm_bridge.c > @@ -206,6 +206,39 @@ bool drm_bridge_mode_fixup(struct drm_bridge *bridge, > EXPORT_SYMBOL(drm_bridge_mode_fixup); > > /** > + * drm_bridge_mode_valid - validate the mode against all bridges in the > + * encoder chain. > + * @bridge: bridge control structure > + * @mode: desired mode to be validated > + * > + * Calls &drm_bridge_funcs.mode_valid for all the bridges in the encoder > + * chain, starting from the first bridge to the last. If at least one bridge > + * does not accept the mode the function returns the error code. > + * > + * Note: the bridge passed should be the one closest to the encoder. > + * > + * RETURNS: > + * MODE_OK on success, drm_mode_status Enum error code on failure > + */ > +enum drm_mode_status drm_bridge_mode_valid(struct drm_bridge *bridge, > + const struct drm_display_mode *mode) > +{ > + enum drm_mode_status ret = MODE_OK; > + > + if (!bridge) > + return ret; > + > + if (bridge->funcs->mode_valid) > + ret = bridge->funcs->mode_valid(bridge, mode); > + > + if (ret != MODE_OK) > + return ret; > + > + return drm_bridge_mode_valid(bridge->next, mode); > +} > +EXPORT_SYMBOL(drm_bridge_mode_valid); > + > +/** > * drm_bridge_disable - disables all bridges in the encoder chain > * @bridge: bridge control structure > * > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 00c6c36..8358eb3 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -233,6 +233,8 @@ int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge, > bool drm_bridge_mode_fixup(struct drm_bridge *bridge, > const struct drm_display_mode *mode, > struct drm_display_mode *adjusted_mode); > +enum drm_mode_status drm_bridge_mode_valid(struct drm_bridge *bridge, > + const struct drm_display_mode *mode); > void drm_bridge_disable(struct drm_bridge *bridge); > void drm_bridge_post_disable(struct drm_bridge *bridge); > void drm_bridge_mode_set(struct drm_bridge *bridge, > Reviewed-by: Neil Armstrong