Re: [PATCH] PPC64 iSeries: cleanup viopath

[Hollis Blanchard <hollis@penguinppc.org>]

On Mar 14, 2005, at 9:34 PM, Stephen Rothwell wrote:
>
> Since you brought this file to my attention, I figured I might as well 
> do
> some simple cleanups.  This patch does:
> 	- single bit int bitfields are a bit suspect and Anndrew pointed
> 	  out recently that they are probably slower to access than ints

> --- linus/arch/ppc64/kernel/viopath.c	2005-03-13 04:07:42.000000000 
> +1100
> +++ linus-cleanup.1/arch/ppc64/kernel/viopath.c	2005-03-15 
> 14:02:48.000000000 +1100
> @@ -56,8 +57,8 @@
>   * But this allows for other support in the future.
>   */
>  static struct viopathStatus {
> -	int isOpen:1;		/* Did we open the path?            */
> -	int isActive:1;		/* Do we have a mon msg outstanding */
> +	int isOpen;		/* Did we open the path?            */
> +	int isActive;		/* Do we have a mon msg outstanding */
>  	int users[VIO_MAX_SUBTYPES];
>  	HvLpInstanceId mSourceInst;
>  	HvLpInstanceId mTargetInst;

Why not use a byte instead of a full int (reordering the members for 
alignment)?

-- 
Hollis Blanchard
IBM Linux Technology Center