From: Krzysztof Kozlowski <krzk@kernel.org>
To: Esben Haabendal <esben@geanix.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Pratyush Yadav <pratyush@kernel.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC
Date: Tue, 28 May 2024 15:00:57 +0200 [thread overview]
Message-ID: <096662e8-03cf-4c13-baa0-11918cab7511@kernel.org> (raw)
In-Reply-To: <20240528-fsl-ifc-config-v2-2-5fd7be76650d@geanix.com>
On 28/05/2024 14:28, Esben Haabendal wrote:
> With CONFIG_FSL_IFC now being user-visible, and thus changed from a select
> to depends in CONFIG_MTD_NAND_FSL_IFC, the dependencies needs to be
> selected in config snippets.
>
> Signed-off-by: Esben Haabendal <esben@geanix.com>
> ---
> arch/powerpc/configs/85xx-hw.config | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx-hw.config
> index 524db76f47b7..8aff83217397 100644
> --- a/arch/powerpc/configs/85xx-hw.config
> +++ b/arch/powerpc/configs/85xx-hw.config
> @@ -24,6 +24,7 @@ CONFIG_FS_ENET=y
> CONFIG_FSL_CORENET_CF=y
> CONFIG_FSL_DMA=y
> CONFIG_FSL_HV_MANAGER=y
> +CONFIG_FSL_IFC=y
Does not look like placed according to config order. This is not
alphabetically sorted, but as Kconfig creates it (make savedefconfig).
> CONFIG_FSL_PQ_MDIO=y
> CONFIG_FSL_RIO=y
You also missed to update second defconfig - arm64.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-28 13:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 12:28 [PATCH v2 0/2] memory: fsl_ifc: Make FSL_IFC config visible and selectable Esben Haabendal
2024-05-28 12:28 ` [PATCH v2 1/2] " Esben Haabendal
2024-05-28 12:48 ` Miquel Raynal
2024-05-28 13:15 ` Christophe Leroy
2024-05-28 13:32 ` Krzysztof Kozlowski
2024-05-28 13:43 ` Esben Haabendal
2024-05-28 12:28 ` [PATCH v2 2/2] powerpc/configs: Update defconfig with now user-visible CONFIG_FSL_IFC Esben Haabendal
2024-05-28 13:00 ` Krzysztof Kozlowski [this message]
2024-05-28 13:33 ` Esben Haabendal
2024-05-28 13:47 ` Krzysztof Kozlowski
2024-05-29 8:14 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=096662e8-03cf-4c13-baa0-11918cab7511@kernel.org \
--to=krzk@kernel.org \
--cc=aneesh.kumar@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=esben@geanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miquel.raynal@bootlin.com \
--cc=mpe@ellerman.id.au \
--cc=mwalle@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®