From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937273AbdCJNYO (ORCPT ); Fri, 10 Mar 2017 08:24:14 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:54335 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932879AbdCJNYM (ORCPT ); Fri, 10 Mar 2017 08:24:12 -0500 Subject: Re: [PATCH 1/2] mfd: retu: Add OF device ID table To: linux-kernel@vger.kernel.org References: <20170221133435.25881-1-javier@osg.samsung.com> Cc: Lee Jones From: Javier Martinez Canillas Message-ID: <096d8b8a-7429-a61e-dbc0-b74309d131e0@osg.samsung.com> Date: Fri, 10 Mar 2017 10:23:55 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170221133435.25881-1-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Lee, On 02/21/2017 10:34 AM, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. > > But this could change in the future so the correct approach is to have a > OF device ID table if the devices are registered via OF. > > The compatible strings don't have a vendor prefix because that's how it's > used currently, and changing this will be a Device Tree ABI break. > > Signed-off-by: Javier Martinez Canillas > --- Any comment on this patch and 2/2? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America