From: Martin Kepplinger <martink@posteo.de>
To: Harinath Nampally <harinath922@gmail.com>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
amsfield22@gmail.com
Subject: Re: [PATCH 0/3] This patchset refactors event related functions
Date: Mon, 25 Sep 2017 08:23:50 +0200 [thread overview]
Message-ID: <096ed3a299892f6f5fd92557607c2f72@posteo.de> (raw)
In-Reply-To: <1506309333-1970-1-git-send-email-harinath922@gmail.com>
Am 25.09.2017 05:15 schrieb Harinath Nampally:
> Harinath Nampally (3):
> Following 2 patches are for refactor:
> iio: accel: mma8452: Rename time step look up struct to generic
> name as the values are same for all the events.
> iio: accel: mma8452: Rename read/write event value callbacks to
> generic function name.
> Following patch adds new feature:
> iio: accel: mma8452: Add single pulse/tap event detection feature
> for fxls8471.
>
I guess it's fine for now, but please don't call your patchset "This
patchset does...".
Just say "Refactor..." or whatever like you do in your patches.
prev parent reply other threads:[~2017-09-25 6:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 3:15 Harinath Nampally
2017-09-25 3:15 ` [PATCH 1/3] iio: accel: mma8452: Rename time step look up struct to generic name as the values are same for all the events Harinath Nampally
2017-09-25 3:15 ` [PATCH 2/3] iio: accel: mma8452: Rename read/write event value callbacks to generic function name Harinath Nampally
2017-09-25 3:15 ` [PATCH 3/3] iio: accel: mma8452: Add single pulse/tap event detection feature for fxls8471 Harinath Nampally
2017-09-25 6:37 ` Martin Kepplinger
2017-09-25 6:23 ` Martin Kepplinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=096ed3a299892f6f5fd92557607c2f72@posteo.de \
--to=martink@posteo.de \
--cc=amsfield22@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=harinath922@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®