From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C03803B47D9 for ; Tue, 14 Apr 2026 08:37:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155870; cv=none; b=qTtbT8tpNqn8+d8mc1jPrhuRruYXwgO/9Q+9iqEAfJL+SRkp2v/kB0aMkjfuIdfC6Ws2H+HvODr9iS2Ns4ZXIax08N1QMxm7tXOYg5ufgEUO9VxTMa02go1xJixv3Yl2VXbIUU1Voe0xOTQ5R442zHkeGqsPtRyKo59StdGlufI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776155870; c=relaxed/simple; bh=X8lFaRFuQvTjjfOP0wHXGXx2yw6hqUgyHUYrHGhj5nw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m9qpJSIa314eeaX3kOARR1sG12W1agXBSNnIChG5YE6paiyCd9HR5ZizOHysQFpxtonFndf3nikhR8O2i8HeBGaL/Qh8ALRvRzEjXhhtaGiXfhgFlMTUQYCsHN8/0BIrBh9nhay0zAGuS1gTFhL76azxDwjgaCVSVhb5W1NlfBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Rcr1JUQn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AYkwNYnp; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Rcr1JUQn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AYkwNYnp" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63E6Uv9D363173 for ; Tue, 14 Apr 2026 08:37:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OOa8dsm5vN52AnGgckPTFkRysjqvS9wIZbizCzelXdg=; b=Rcr1JUQnKfCoDY1m 1K47TRpqSOR8AzQvXZsm7Y+UIv492lxqbIUMTaIjfvd/XZDAz5R+QlvIs17qfh63 3mvb8S1YU0EAnEY/4VF6Eqpppb85kME0ENTAlwVM6khPyg+kgWzTXvgeyOHGmfpn QfjvYFIZej8THMJMjh2qrzgsosXHRAeDv82IVqiFxLBIBES4nofzEEKgFeoT6aml Y4+gM1otkD9WwtUSQFnZx9wT2/WK2VnUjCGHFUVJJZ7cSrUnLadvcXd8rmpuV648 tR0hwYWgkYX8cndZW6PoeZeK+YxpySLfBH0kiNJtAe+87lK3cDGq+qj4PwYKpk6g iG5IyA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh870su3v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Apr 2026 08:37:46 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8a016b99579so19114076d6.0 for ; Tue, 14 Apr 2026 01:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776155866; x=1776760666; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OOa8dsm5vN52AnGgckPTFkRysjqvS9wIZbizCzelXdg=; b=AYkwNYnp+sUxrO74cc/s+84EKB/ZFTR0qIfgZySEyViWsqKn1uZKEozppDztneZWyL xrYP9iFJWe5jpfsJbHn7c91mUsn5IIxFlc8KUZ/x6A68jyQo3kNONawW00tppi+C0HKo Ar+U5fzUEmNbl+I7lG16xi9X6VJY2Sy0yun/HTnoAG0WiFZNrVuVlbAgIHlF/BxS0VlL SemivLUuUp16L+ofjuVCy6+PRs2cXZCOQrlA6fHUfzKEzyVwhhwv8O0lk6zkZi0gvyFL OD2s1A82LNxkBk85c1xfEg1C06IzkihqAUw3o6LEohHwObd4TDuJLMl2PXqWW3Nvz5Hk bGsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776155866; x=1776760666; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OOa8dsm5vN52AnGgckPTFkRysjqvS9wIZbizCzelXdg=; b=OKOdyNxH8J/2pJSGishjC0KJuzOSO4XUbLjLgT/O2UkGFQx+EK+X/dUVValC4Gf8Hi dnsenNnM/uRp7D+IV9AUK/vNWCIz0DP9Mzp7e31HVQUwAkb3bIEk9iZhrvI8SqQDqUz6 AjUcR9Q5/fthM9UukBFU4KPYUaozsrwLKayr2aqo8kgkqbR5GyP7noSDNB75r0V2S07O 0MF6UP/Du+Me9IZEFBT8EWzI3ScMS6HgU8nYX6fWMnYZWtlvDpDCYX8bOQGRf9/jWano bAUJw+zqd0ugewTadx8MbHuy66U49MPMupf+uQTPWJmwY/WhqNZYIM0EGiLQLaxJnMFF CM+g== X-Forwarded-Encrypted: i=1; AFNElJ+wwioIGittzPysKjDZIQUE8PqaOsH1y7Xr1jSNY1iylCpIe7t6w/PJFMhxEkq7KkcgrLjCpYf8t6o8LAs=@vger.kernel.org X-Gm-Message-State: AOJu0YzaP1VtUh0XNBjFTC3C27ayGPg+uA/rJr5hbhNkKtetxOkF4p+p 4JC05cD+pOZpRddt01u6n1SZU9FqQ2MHVT75RVpAGpI+3b6pZQng8J4+HVwlWnXyTbxYwun39VM i+6cmhK1Q3asrZZUYaoHUZ6riRTdvvUFp+r++OCWoK6fwvz6pJvdvN7RXKVR/4fwk04Q= X-Gm-Gg: AeBDieu8EvZC6Iu+ZWxASjGxog3bcXsvlFRZEFR1N3JA4jw85cO5J7mhRQ9lLXAt4El RU0wJiCZUzQ/zAegFmJkCVFZqxkVpT6WKbekOJuXms/C25sUi+Gai8lS9eDDJc5zCScn8qn27QM ymUwyLMffX+aSVZr81guJRhwPDlMvVV9+xH850jLVq6MmXCVdGrTVyHdElHmGus5qGqacK9mzwe Lssz1y2SRU6JxOEQTZbY2MhcYuc/q6cOKt/bjFGcPYMLr7Kez+MRa7kSjggLUWADk/Ct8bN/crT Wpdie4kpLp5i/uUaJMbUsa4CLbUedW0obRlRXh3QRvA8fSEgx8yAR3GpKPu2k1GBwXMPia8tRCy fntHKCihjocgLsKo3PEPm21hXAv1ht7E20oLpLxrplPxnoXd0qt1OTJ/e5bcm+XvD6fbCnjrKfJ DC2YPp4kWqiiSPlg== X-Received: by 2002:a05:6214:258f:b0:89c:d639:e7be with SMTP id 6a1803df08f44-8ac874bf3c6mr177289966d6.5.1776155865887; Tue, 14 Apr 2026 01:37:45 -0700 (PDT) X-Received: by 2002:a05:6214:258f:b0:89c:d639:e7be with SMTP id 6a1803df08f44-8ac874bf3c6mr177289786d6.5.1776155865476; Tue, 14 Apr 2026 01:37:45 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9d6e7c8492sm383732966b.47.2026.04.14.01.37.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2026 01:37:44 -0700 (PDT) Message-ID: <0975d136-0013-425b-a465-08f07efcefc7@oss.qualcomm.com> Date: Tue, 14 Apr 2026 10:37:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM To: Ajay Kumar Nandam , Bjorn Andersson , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@oss.qualcomm.com References: <20260413122233.375945-1-ajay.nandam@oss.qualcomm.com> <20260413122233.375945-2-ajay.nandam@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260413122233.375945-2-ajay.nandam@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=C9vZDwP+ c=1 sm=1 tr=0 ts=69ddfcdb cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=geYgjXO_D7EpWZfwOI0A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE0MDA3OSBTYWx0ZWRfX0zaRmqaxV0Yl W4xUZopestEY7x1BMcvP+axfasisCjk1jpBsxWrgevba53fkks+h/blYZNmwZIzQ5BlDcCQupI6 /vyqRYNprD4ZFf7g2PGyJjRr7DaAF5cQenLevxkImZ3caRP/CGyeHFQfkFpZQ3hBmrSHEzrlogR Taj+UIcZeqaszNpxD+HlPq3rCM21yjUCZWeIC3ek5VJIxO8FwCPLZNVDKxBow++3gFNn4dU18lK FIv78FH8CT/eA8lCKCbzaOVZhJMXiK3esGMd3gK6mGRO5OdpVBgr4Lpun2rIbg3Pb4OyGcKUD5i lh6B3fNN29CYa55uPqb1EwRTBndT1BZzXN+a1hMbByM9U2LTIaCpG7tO+vbertVnOFM4h1wOKK9 ciZW6Ge0RpQX1tmixskUkYSR7K3Q0uybNkg5qTmad1jVbT5S868hzsJgQVo2zLOThmkWfsJsfE3 +7reNpKguor/0DPNDkA== X-Proofpoint-GUID: M2nMuIiVP5VlINIl6A75szQrV5fl5g-s X-Proofpoint-ORIG-GUID: M2nMuIiVP5VlINIl6A75szQrV5fl5g-s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-14_02,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 spamscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604140079 On 4/13/26 2:22 PM, Ajay Kumar Nandam wrote: > Convert the LPASS LPI pinctrl driver to use the PM clock framework for > runtime power management. > > This allows the LPASS LPI pinctrl driver to drop clock votes when idle, > improves power efficiency on platforms using LPASS LPI island mode, and > aligns the driver with common runtime PM patterns used across Qualcomm > LPASS subsystems. > > Signed-off-by: Ajay Kumar Nandam > --- > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 36 +++++++++++++------ > drivers/pinctrl/qcom/pinctrl-lpass-lpi.h | 2 ++ > .../pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 5 +++ > 3 files changed, 32 insertions(+), 11 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > index 76aed3296..6d50e06ef 100644 > --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c > @@ -14,15 +14,16 @@ > > #include > #include > +#include > #include > > #include "../pinctrl-utils.h" > > #include "pinctrl-lpass-lpi.h" > +#include Please move it up, together with other non-local includes [...] > + pm_runtime_set_autosuspend_delay(dev, 100); > + pm_runtime_use_autosuspend(dev); > + pm_runtime_enable(dev); devm_pm_runtime_enable() will let you drop the manual disablement below and in .remove() > > pctrl->desc.pctlops = &lpi_gpio_pinctrl_ops; > pctrl->desc.pmxops = &lpi_gpio_pinmux_ops; > @@ -539,20 +540,33 @@ int lpi_pinctrl_probe(struct platform_device *pdev) > return 0; > > err_pinctrl: > + pm_runtime_disable(dev); > mutex_destroy(&pctrl->lock); > - clk_bulk_disable_unprepare(MAX_LPI_NUM_CLKS, pctrl->clks); > > return ret; > } [...] > --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c > +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c > @@ -139,10 +139,15 @@ static const struct of_device_id lpi_pinctrl_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, lpi_pinctrl_of_match); > > +static const struct dev_pm_ops lpi_pinctrl_pm_ops = { > + RUNTIME_PM_OPS(lpi_pinctrl_runtime_suspend, lpi_pinctrl_runtime_resume, NULL) > +}; > + > static struct platform_driver lpi_pinctrl_driver = { > .driver = { > .name = "qcom-sc7280-lpass-lpi-pinctrl", > .of_match_table = lpi_pinctrl_of_match, > + .pm = pm_ptr(&lpi_pinctrl_pm_ops), I believe SoCs other than kodiak also require this change to avoid regressions. Konrad