From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 456C2C46467 for ; Tue, 3 Jan 2023 08:40:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233011AbjACIkB (ORCPT ); Tue, 3 Jan 2023 03:40:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236949AbjACIjr (ORCPT ); Tue, 3 Jan 2023 03:39:47 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32143BE1F; Tue, 3 Jan 2023 00:39:46 -0800 (PST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NmQzh4gJHzJpXn; Tue, 3 Jan 2023 16:35:44 +0800 (CST) Received: from [10.67.109.184] (10.67.109.184) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Tue, 3 Jan 2023 16:39:42 +0800 Message-ID: <09763a5e-22c9-513d-ca51-9234478b9c67@huawei.com> Date: Tue, 3 Jan 2023 16:39:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [RFC PATCH bpf-next 3/4] riscv, bpf: Add bpf_arch_text_poke support for RV64 Content-Language: en-US To: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Pu Lehui , , , CC: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20221219133736.1387008-1-pulehui@huaweicloud.com> <20221219133736.1387008-4-pulehui@huaweicloud.com> <87v8looypd.fsf@all.your.base.are.belong.to.us> <713f9f26-da42-eda8-c804-338d61b1557c@huawei.com> <877cy4xc2l.fsf@all.your.base.are.belong.to.us> From: Pu Lehui In-Reply-To: <877cy4xc2l.fsf@all.your.base.are.belong.to.us> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.184] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/1/3 16:21, Björn Töpel wrote: > Pu Lehui writes: > >> On 2023/1/3 15:37, Björn Töpel wrote: >>> Pu Lehui writes: >>> >>>> diff --git a/arch/riscv/net/bpf_jit_comp64.c b/arch/riscv/net/bpf_jit_comp64.c >>>> index bf4721a99a09..fa8b03c52463 100644 >>>> --- a/arch/riscv/net/bpf_jit_comp64.c >>>> +++ b/arch/riscv/net/bpf_jit_comp64.c >>> >>>> @@ -1266,7 +1389,7 @@ int bpf_jit_emit_insn(const struct bpf_insn *insn, struct rv_jit_context *ctx, >>>> >>>> void bpf_jit_build_prologue(struct rv_jit_context *ctx) >>>> { >>>> - int stack_adjust = 0, store_offset, bpf_stack_adjust; >>>> + int i, stack_adjust = 0, store_offset, bpf_stack_adjust; >>>> bool is_main_prog = ctx->prog->aux->func_idx == 0; >>> >>> This line magically appeared, and makes it hard to apply the series >>> without hacking the patches manually. Going forward, please supply a >>> base tree commit to the series (or a link to a complete git tree). >>> >> >> A rebase version has been resend as follow: >> >> https://lore.kernel.org/bpf/20221220021319.1655871-1-pulehui@huaweicloud.com/ > > Yes, but with the same issue: > https://lore.kernel.org/bpf/20221220021319.1655871-4-pulehui@huaweicloud.com/ > > The "is_main_prog" line is still around in the resend. > Oops, something was left when debugging mixing bpf2bpf and tailcalls. Sorry, will send v2. > > Björn