From: K Prateek Nayak <kprateek.nayak@amd.com>
To: Shubhang Kaushik <shubhang@os.amperecomputing.com>,
Christian Loehle <christian.loehle@arm.com>,
<linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
<mingo@redhat.com>, <vincent.guittot@linaro.org>
Cc: <juri.lelli@redhat.com>, <dietmar.eggemann@arm.com>,
<pierre.gondois@arm.com>
Subject: Re: [PATCHv2] sched/fair: Skip SCHED_IDLE rq for SCHED_IDLE task
Date: Wed, 4 Feb 2026 13:24:58 +0530 [thread overview]
Message-ID: <097c6b1a-6b1e-48b9-813f-31de79e883b6@amd.com> (raw)
In-Reply-To: <6895a358-c993-74d5-d804-3b7130ee1559@os.amperecomputing.com>
Hello Shubhang,
On 2/4/2026 7:38 AM, Shubhang Kaushik wrote:
>> @@ -12299,7 +12305,7 @@ static void sched_balance_domains(struct rq *rq, enum cpu_idle_type idle)
>> * state even if we migrated tasks. Update it.
>> */
>> idle = idle_cpu(cpu);
>> - busy = !idle && !sched_idle_cpu(cpu);
>> + busy = !idle && !sched_idle_rq(rq);
>
> Usually sched_idle_rqs were treated as not-busy in several balancing decisions to avoid yielding to background load. Does this change alter that interpretation at the domain balancing level ?
I don't think anything changes in the load-balancer path since we still
check for sched_idle_rq() here. Only the wakeup path will consider both
the waking task's policy and whether the CPU is completely idle vs
sched_idle_rq().
>
>> }
>> sd->last_balance = jiffies;
>> interval = get_sd_balance_interval(sd, busy);
--
Thanks and Regards,
Prateek
next prev parent reply other threads:[~2026-02-04 7:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 18:49 Christian Loehle
2026-02-04 2:08 ` Shubhang Kaushik
2026-02-04 7:54 ` K Prateek Nayak [this message]
2026-02-04 9:53 ` Christian Loehle
2026-02-04 7:48 ` K Prateek Nayak
2026-02-04 10:10 ` Christian Loehle
2026-02-04 10:53 ` Vincent Guittot
2026-02-05 0:00 ` Shubhang Kaushik
2026-02-05 7:25 ` Vincent Guittot
2026-02-05 18:52 ` Shubhang Kaushik
2026-02-06 13:43 ` Christian Loehle
2026-02-06 18:50 ` Shubhang Kaushik
2026-02-24 9:13 ` [tip: sched/core] " tip-bot2 for Christian Loehle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=097c6b1a-6b1e-48b9-813f-31de79e883b6@amd.com \
--to=kprateek.nayak@amd.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pierre.gondois@arm.com \
--cc=shubhang@os.amperecomputing.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®