From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 010633AEF4C for ; Tue, 28 Apr 2026 11:57:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777377428; cv=none; b=L4LwN5nMQY+IfMHk4Ah2Sj4NHnDz+pSnSK5p0i3vZjRIP3t4YTqf32JIu8ctx94FhN8iuz7oZlP09hgUJegT8eiD1pRFbvzS3WmwIzjmjz5IKPJ0Fbb+tGRtSQ4wJhPEAOMaVthk922O7ZhihL8ZlEmHuunNUlXbBC9wR+KE+xI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777377428; c=relaxed/simple; bh=x01fyI9hSlHUiPCaC8zQGcP2vLXq4qwF7JHLG0WKnek=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rKiyWWve+ucBqY73DBUy12BEyjorVY2QDQIhgGxT9TehDzVMGE3J7rWUW3FnEUZR5FD/xeWIEmUaEHTJTmyoA9MxKkCZhNNp2/VouQTzyCkvaaCUwtpKLcFTQmM25KSGBLaKRlhf3SROU0rE9ea+9p+oMJMd5B97B1AlTSQwm5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=L+sqkzm4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L+sqkzm4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777377426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AgBBjKG/PS5Dz1DwpETM5k/BFvsOUmL0XkfBNTKeCf4=; b=L+sqkzm4z3IkDQu6VhMqkw9E06qzjfi+U1KBD5J6F+EyPah3Fq4FfxiSXSWhlfXL7npTa2 NsdtY6dXf07ZOCA8i5SEolfaGgSSzxl+vXbolE8QPeQIFV1jUhS1h8tTSRNnNtp8wXLrSE 2WRffW0WaztkyE2s5ecwQoWmF7LNTJ0= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-InQ2uG5OPYijZ2K7MXq0ng-1; Tue, 28 Apr 2026 07:57:04 -0400 X-MC-Unique: InQ2uG5OPYijZ2K7MXq0ng-1 X-Mimecast-MFC-AGG-ID: InQ2uG5OPYijZ2K7MXq0ng_1777377424 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8a8ea3f1becso193673896d6.0 for ; Tue, 28 Apr 2026 04:57:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777377424; x=1777982224; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AgBBjKG/PS5Dz1DwpETM5k/BFvsOUmL0XkfBNTKeCf4=; b=qicRq0kTytO+mkSBcKfy/QEIei05chLLEasAuDpAuA+X4Yci8xRdUHEuuAL+nv0t7B DHST8aiWvQyl03xpFJYJdMi5VLt0yAwf0MGBPdaz/PHXKQx/MQcmGdnNBgXfRohISPDO s6df8UO8IjOFMrp7Sdrm5f2fsxGuhJacBDkDUuyeySFmVc2ZUtdYeGggNAXEQEBXFzAK sof9D0cp4nON6rC4ivDm+bmnK9lOO4fASjZ5oI+vODsorkmJ2THN1eIFPNd9uDTRB/vs eSLbv076nPCKzKTEvE5LRk/aKPcuT33SCp24Q9DcbiNeplJWpijP9UeBZGAl4KKOwZDj +a0Q== X-Forwarded-Encrypted: i=1; AFNElJ+trGvZ6xjajf8eKioRntZGiTtfVfsx1oKKjz+ax+xYyITB5MelnqMz4GvH0LdklD5puEu1SLFCRH3RRzw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywuwl1/WwCzQ0Lo/PAY2F5EAwK7Njm0n271YlOnjNs4tgKbC3T0 3E3kQtGAUrZ/bPVOG7YrAjDK74/cxZLba+hUWATpq3bFCWEET0u0KPawMQj9LLlNvJl6dq+Avqt 8Sp/PHs4DFT0ukDU5SY/fPYU2oDLaF/gn04JZbjdAXnoJck3OFOFtjFLJJGk6qrmB9fcsCYx15Z 4U X-Gm-Gg: AeBDies2bPsvZ09nbkCac/jPJNcc+j40A7gmO4kADWaZj/gfojATCdL21g8wPyEf+c7 1KXxZ5DRH+4cEau/2Ox17k42weUiTo/IEUtmh0HMygh5W+pxPhk5St3CyPxGt7ggLu9X6xEmnwa socbCis7yaNV2eaEz99ZSj3LrtBob+T9UDlcYosKoSQvzqNxz/anEJSjPbpcPQneyb3HBl8sDPd K6M4ZkeECr74RB8TC6XqZSXxsRVvpHXCm73s8SpIdja/mPb1UJbx9xgUtwsk8GWVrN9Dq4C38yy CmqouVcE9T7okE3w6wIgS8r2hc44Wh4D839WWX6v2mi1cPCaqXo+7F67encH93UhB5pBEaB7ju4 v+gpMRC9UdpaEY2Kyew0kZvlq9o/jwfYnEUZL3VkmjnX3Qbmsk0TTBUhW8QngRWJ1mIN5kMloD9 gjlnvgCCi3QvnyYL2a1nYDsk4= X-Received: by 2002:a05:6214:311b:b0:8ac:ab31:0 with SMTP id 6a1803df08f44-8b3e31fb96dmr42763866d6.40.1777377423684; Tue, 28 Apr 2026 04:57:03 -0700 (PDT) X-Received: by 2002:a05:6214:311b:b0:8ac:ab31:0 with SMTP id 6a1803df08f44-8b3e31fb96dmr42763486d6.40.1777377423235; Tue, 28 Apr 2026 04:57:03 -0700 (PDT) Received: from [192.168.2.110] (bras-base-aylmpq0104w-grc-22-70-53-202-134.dsl.bell.ca. [70.53.202.134]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b3e2956a8bsm18295396d6.31.2026.04.28.04.57.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 04:57:02 -0700 (PDT) Message-ID: <09847e2f-0397-44cc-b517-75bffa7124e2@redhat.com> Date: Tue, 28 Apr 2026 07:57:01 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 43/53] selftests/mm: migration: add setup of HugeTLB pages To: Mike Rapoport Cc: Andrew Morton , David Hildenbrand , Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Sarthak Sharma , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260418105539.1261536-1-rppt@kernel.org> <20260418105539.1261536-44-rppt@kernel.org> <67d7b067-97a8-4600-a9a6-46f3e797ffed@redhat.com> <0e2ef2c0-d74e-4aff-bba0-6dd91dbd4e41@redhat.com> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-04-28 01:48, Mike Rapoport wrote: > On Mon, Apr 27, 2026 at 01:19:07PM -0400, Luiz Capitulino wrote: >> On 2026-04-27 12:51, Mike Rapoport wrote: >>> On Mon, Apr 27, 2026 at 08:56:27AM -0400, Luiz Capitulino wrote: >>>> On 2026-04-26 06:58, Mike Rapoport wrote: >>>>>> And there's another issue: when running the migration test individually, >>>>>> private_anon_htlb gets skipped. I guess it's because the previous test >>>>>> is restoring the HugeTLB state: >>>>> >>>>> It could be. >>>>> >>>>> I pushed the updated version that has the fixes for both zombie and >>>>> signal issues: >>>>> >>>>> https://git.kernel.org/pub/scm/linux/kernel/git/rppt/linux.git/log/?h=mm-selftest/v3 >>>>> >>>>> Would be great if you can test it in your setup. >>>> >>>> This works! Both issues are fixed: the migration test completes w/o >>>> hanging and when I run it individually all tests run. >>> >>> Thanks for confirming! >>>> One last question: should we munmap() the mappings in this test? Though >>>> I understand this goes beyond your series goal. >>> >>> We could, but the tests _exit() anyway as a part of kselftest_harness, so >>> it does not really matter. >> >> OK. Just to clarify that I meant exercising the munmap() path, not that >> we're not freeing resources. But if we know that _exit() is sufficient >> for this, then it's fine. > > exit tears down all the mappings, but the code path is slightly different > than calling munmap(). > > We can add munmap() calls there, but let's do it separately from this > series. Agreed.