From: Markus Elfring <Markus.Elfring@web.de>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>,
linux-kselftest@vger.kernel.org,
Chunyan Zhang <zhang.lyra@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Kees Cook <kees@kernel.org>, Shuah Khan <shuah@kernel.org>,
Will Drewry <wad@chromium.org>
Subject: Re: [PATCH v5] tools/testing: Fix the wrong format specifier
Date: Fri, 26 Jul 2024 10:30:20 +0200 [thread overview]
Message-ID: <0987e828-f7c3-4d11-ab1b-a671d091fbea@web.de> (raw)
In-Reply-To: <20240726023241.17295-1-zhujun2@cmss.chinamobile.com>
> The format specifier in fprintf is "%u", that "%u" should use
> unsigned int type instead.
* Please improve the change description with imperative wordings.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n94
* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n145
* How good does the summary phrase fit to your proposal?
> the problem is discovered by reading code.
How do you think about to detect such change possibilities by more systematic
source code analyses?
Regards,
Markus
next prev parent reply other threads:[~2024-07-26 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 2:32 [PATCH v5] tools/testing:Fix " Zhu Jun
2024-07-26 8:30 ` Markus Elfring [this message]
2024-07-26 17:32 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0987e828-f7c3-4d11-ab1b-a671d091fbea@web.de \
--to=markus.elfring@web.de \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=shuah@kernel.org \
--cc=wad@chromium.org \
--cc=zhang.lyra@gmail.com \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®