mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Avri Altman <avri.altman@wdc.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] scsi: ufs: critical health condition
Date: Thu, 13 Mar 2025 11:13:51 -0700	[thread overview]
Message-ID: <0991bf65-aa76-46b1-b353-2a19069426d1@acm.org> (raw)
In-Reply-To: <20250211065813.58091-1-avri.altman@wdc.com>

On 2/10/25 10:58 PM, Avri Altman wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index cd404ade48dc..ef56a5eb52dc 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6216,6 +6216,11 @@ static void ufshcd_exception_event_handler(struct work_struct *work)
>   	if (status & hba->ee_drv_mask & MASK_EE_URGENT_TEMP)
>   		ufshcd_temp_exception_event_handler(hba, status);
>   
> +	if (status & hba->ee_drv_mask & MASK_EE_HEALTH_CRITICAL) {
> +		hba->critical_health_count++;
> +		sysfs_notify(&hba->dev->kobj, NULL, "critical_health");
> +	}
> +
>   	ufs_debugfs_exception_event(hba, status);
>   }

Hi Avri,

sysfs_notify() may sleep and hence must not be called from an interrupt
handler. Please fix.

Thanks,

Bart.

      parent reply	other threads:[~2025-03-13 18:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11  6:58 Avri Altman
2025-02-11 17:41 ` Bart Van Assche
2025-02-13  3:17 ` Martin K. Petersen
2025-02-19  1:06 ` Martin K. Petersen
2025-03-13 18:13 ` Bart Van Assche [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0991bf65-aa76-46b1-b353-2a19069426d1@acm.org \
    --to=bvanassche@acm.org \
    --cc=avri.altman@wdc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®