From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A89593BAD94 for ; Tue, 16 Jun 2026 11:33:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781609583; cv=none; b=M3hmWILT50w6ks113Eh46E6Az7Gadt+YRI0CrRveE9GqQ59IgDwAfkwwYjG0/PS2UPg1G+LzbMxXbIo3eUTV1eaLW5hJiP78sAp5t62un+LAKxPEgzY81bmdpiYz3DbMptXqynXQx4cFMZ9ap1u4feSaiAY1TEkxZ4IRjiKDQvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781609583; c=relaxed/simple; bh=NRZLHxuL2zqAm1Eat7MK4PNeGjSNwvs4EpwC5IBRw3k=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=T41UB5Fdg7nSqYxZptf7m9RGMuj96wif9MyBN1y7JwOo7yprlOglFHt5POIL16ykd5+bczJCWiI6Lt71ur3p/V/imObszcat7y+d6SAhgaXF8DAzc3smwXhFZRzjK+QzK93cRVKmlxjc6QYc0NDsRFgrnhFx/5zLkoqFy6KLh6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WgjKow//; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WgjKow//" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 595771F000E9; Tue, 16 Jun 2026 11:33:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781609582; bh=3jUacLBnaiUT8m88bzKss7QjSDoac1btVgY57AcZMV4=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=WgjKow//JXgyD/56WCfiaRtjxvaNlvsSgGjwQxbqfY4iz2B8IBBtcwob2gffp9IwJ Xmni5VWtpJ7T00KneG9C5Ysy/nqL+pMgpDoAL77+NHDQ9WG3h/eUkYKuORKj7gY6zH vGdBy+Q8iQSvCO0VYm8LEWbccgu5vCT+q6E3KMAumHpJZBqCdlLe3aNLtEmqkBJg6N JpGwYVkwXji79LbkmONEiWvTQTnSxtaFq7WWLbhN6t4rQ2RkXsFp0e5o7A7WjNnow1 P+ZcHOoXLrmkuOmzwm3fETPYQVSOy1ya+p9wnWFoK03/QEZkxig1/N59puwpiQjSqW BySWEL/FNYekw== Message-ID: <09934a59-1504-4de7-811a-8cea4824c64b@kernel.org> Date: Tue, 16 Jun 2026 11:32:59 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, LKML , oliver.yang@linux.alibaba.com, Hongbo Li Subject: Re: [PATCH] erofs: clean up erofs_ishare_fill_inode() To: Gao Xiang , linux-erofs@lists.ozlabs.org References: <20260607172132.2695176-1-hsiangkao@linux.alibaba.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260607172132.2695176-1-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/7/26 17:21, Gao Xiang wrote: > - Use the shorthand `si` to replace the overly long `sharedinode`; > > - Introduce erofs_warn() and get rid of barely-used _erofs_printk(); > > - Get rid of the variable `hash`; > > - Simplify error paths. > > Cc: Hongbo Li > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,