From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A9C6318139 for ; Wed, 7 Jan 2026 12:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767790468; cv=none; b=XK/4DTYczxJ/Oeboz1SZluBV3J831wIYG+PN4W3O5D+NPHI0kF8dqSEbta9RkxSaeqZGgUPJypFMhsl9eewdRh6wRzF9eV6Lt8Ad5PZ5h/v7l88DjecactHPrl4Czg12C/YLY5PF+x7PoEln8cDJIB4sWO8+3EqlFw2TD9LGEVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767790468; c=relaxed/simple; bh=9sIb48gzo7zaea43chj376ZbKNW5nydE4/qvvdyuxSE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n0ISv5eLPTGgVZoXBMgcRFx7FQ4aXWTXDcwal1QmOfZ8CsDuVSZCuX2JPFtU7dmkYvQx7Xv/HhdI7HZ1U369b1klayXF5+ocpYEnpY1Io+VPTHEU8hkcKnMP5eILtd1i8wPhFVVSD7zQPmW+he+M1bJn7hmZ5ll11RPIHnwFLtc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M60YzcXz; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M60YzcXz" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47796a837c7so15093325e9.0 for ; Wed, 07 Jan 2026 04:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767790464; x=1768395264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z1ZFsihSM7eUuf7F3kKj8vZvzmYO9Sr6mOcUt9tE0Pw=; b=M60YzcXzF6lYY0ALNfuRkqV1Ng20wTF5XWydb02Cgwkd6gokKIYXyUB/Hv+eJjXNeu YWEYrPcw0xeqToM6XSHhM1q+OpsGBrn97DUYTR/Z1zoHD/48Org2efa4Rsu6Dgw+rcva pU7b0acKge4IA7Dorp5St3/ThFBm/ZPhA7aDorID4rKFU03QWvCLY8gu2QZDfjNoZgAm 2rCnTVAecaA4xfXwchX1ClnfH646QiJN96gyAvKSrhoN7uX49h9C6Eukz2corkae2Fa3 3+OKS7+CcTRrQrupOFck/gdT7QXNwxcw0pFcW/siqDUIhsriglGOF4xXbK2/oH+UnjoH s6EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767790464; x=1768395264; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z1ZFsihSM7eUuf7F3kKj8vZvzmYO9Sr6mOcUt9tE0Pw=; b=EDJWb37OAfMhQu3mWESJhvKyBJczIABffZRnkXRLldzthZA3CeXTXjRa0e5A/06oVH lbwKiBmh7DeCtQMw0BRrI3GocxcJTJKrDZB4u83GPCdXSJmEylOUYR//wmhp7QBn7/5d F4Pc8ELpu4n7FdXkc/6zddJPeR+OhZf3J9TzRxpUTHS3D9kSmbdhkJ0jFZSsgbnwv7JH ePxp7FlYXguP2Zlj3Ox1uDNvk3n3xYq0sN9Lpwyke427+Q0vAhJ/xfCFjZsbBTuK9Mo/ qpa1TQAWvzdadpgpj/ElFs4NL9wz9J2n7M6eC3wrlPst8Wb7bBXz2yOL2GormU5iFzws /8xA== X-Forwarded-Encrypted: i=1; AJvYcCXCRQv2cwahVAyafNvnjqIa9aTZE5WWds606hC3EIqSFH9iV6KlXkBfd6BS6ivj2CuthT0J7jvrzjVjahI=@vger.kernel.org X-Gm-Message-State: AOJu0YyZsB+OoU63JfQLQ8QKEvVIKOwV3me/Luo7qdF9/83ag7GB5tDw kPNB9DVn7w/mgRysKJizXBXlrJAYdZEsT+SDToc/q9k9/Is4tPC3od5q X-Gm-Gg: AY/fxX7kJRQ2j7miFNs7Vbx3DC1g0F67tJf+wDrM9rbwVJSir2WTfWsfgQObe7ch+Xa b6NhtntXpHMg44xDLUztv15jFAAsnC/xdIdY5+UOavs7GTm1yKKplc9TMWvpkB4zTNrfNsE0Lrj qivOtlK/rmLikvxjYd591PJm18Tr71wj3CbmU74YEJ8BzFrVOWbMUifJ0pgnKKoeGRXNybX9SHy l74zqb0sQuYZW6O86Bs0obBDVXdcJGbctZPhFG4B6C52BjpXvNvVOagOFZLR8Pt7izzwUpV8Xcj 5aCEWyy/Z7wDCrq7BeF9s+IL/EWcaiOgJeLzURVKKYboa3nMmFmmFCQl+ZR2OfiAn87K1zQXpwd bfacGRZFMEWCdbQWfmp+6hCb8nltTjx6H5n8gnwSbfXkUVHYbDIc77fdZo6m/2UN0/GLojsVwzC ZB6Ajj/Qs8Cdyjbiby6tL2qHY= X-Google-Smtp-Source: AGHT+IF7Zi0gv3AWydSEPynSUrmNBWHaZkiYYoLznyQjAwtqZBSf/Fv1/ZtHJsKhxhrOka4SLvcdXA== X-Received: by 2002:a05:600c:4752:b0:477:df7:b020 with SMTP id 5b1f17b1804b1-47d84b54c47mr24381205e9.18.1767790463539; Wed, 07 Jan 2026 04:54:23 -0800 (PST) Received: from [192.168.1.121] ([176.206.93.222]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f6ef868sm94841355e9.11.2026.01.07.04.54.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 04:54:23 -0800 (PST) Message-ID: <09936227-9292-4a36-a581-1eb622f3d32e@gmail.com> Date: Wed, 7 Jan 2026 13:54:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 00/11] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling To: Antheas Kapenekakis , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Cc: Kelsios , platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, LKML , Jiri Kosina , Benjamin Tissoires , Corentin Chary , "Luke D . Jones" , Hans de Goede References: <3ec43b6f-a284-4af7-bcae-8aee11929abb@proton.me> <1adcffd1-2381-654d-b9b5-966306758509@linux.intel.com> Content-Language: en-US, it-IT, en-US-large From: Denis Benato In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/7/26 11:45, Antheas Kapenekakis wrote: > On Wed, 7 Jan 2026 at 12:42, Ilpo Järvinen > wrote: >> On Tue, 9 Dec 2025, Antheas Kapenekakis wrote: >>> On Tue, 9 Dec 2025 at 10:17, Ilpo Järvinen >>> wrote: >>>> On Sat, 6 Dec 2025, Antheas Kapenekakis wrote: >>>>> On Sat, 6 Dec 2025 at 00:03, Antheas Kapenekakis wrote: >>>>>> On Fri, 5 Dec 2025 at 23:13, Kelsios wrote: >>>>>>> I would like to report a regression affecting keyboard backlight brightness control on my ASUS ROG Zephyrus G16 (model GU605CW). >>>>>>> >>>>>>> Using kernel 6.17.9-arch1-1.1-g14 with the latest HID ASUS patchset v10, keyboard *color* control works correctly, but *brightness* control no longer responds at all. The issue is reproducible on every boot. This problem is not present when using patchset v8, where both color and brightness work as expected. >>>>>>> >>>>>>> Important detail: the issue occurs even **without** asusctl installed, so it must be within the kernel HID/WMI handling and is unrelated to userspace tools. >>>>>>> >>>>>>> Output of dmesg is available here [1], please let me know if any additional information is required. >>>>>>> >>>>>>> Thank you for your time and work on supporting these ASUS laptops. >>>>>>> >>>>>>> Best regards, >>>>>>> Kelsios >>>>>>> >>>>>>> [1] https://pastebin.com/ZFC13Scf >>>>>> [ 1.035986] asus 0003:0B05:19B6.0001: Asus failed to receive handshake ack: -32 >>>>>> >>>>>> Oh yeah, asus_kbd_init no longer works with spurious inits so it broke >>>>>> devices marked with QUIRK_ROG_NKEY_LEGACY >>>>>> >>>>>> There are three ways to approach this. One is to ignore the error... >>>>>> second is to drop the quirk... third is to check for the usages for ID1, ID2... >>>>>> >>>>>> I would tend towards dropping the ID2 init and ignoring the error for >>>>>> ID1... Unless an EPIPE would cause the device to close >>>>> Benjamin correctly caught the deviation >>>> BTW, we want to record this knowledge also into the changelog so that the >>>> next person who'd want to make the check stricter does not need to guess >>>> whether it was based on a real observed problem or mere guessing there >>>> could be a problem. >>> If we keep the spurious inits, the stricter check will catch them and >>> throw errors. This is problematic. >>> >>> Kelsios, you have a device that allegedly would not work without those >>> inits. Perhaps you could try removing the legacy quirk from your >>> device and see if everything is ok? >>> >>> If it is, then we have a tested device and a case for removing the >>> legacy quirk altogether >> Hi all, >> >> Is there any progress on this? > Hi, > I plan to revise the patch series and fix this issue next week. > Currently on holidays > > I am unsure how I will tackle this issue, I might make the init not > fail for 0x5d/0x5e, and try to avoid printing errors if the endpoint > is missing. Hello, I have left the patchset in linux-g14 for people to try. I estimate some thousands laptops run it at this point, however we had to stop the driver from aborting probe for things to function otherwise lots of model would have stopped working: https://gitlab.com/asus-linux/linux-g14/-/blob/6.18/PATCH-v10-00-11-HID-asus-Fix-ASUS-ROG-Laptop-s-Keyboard-backlight-handling-id1-id2-pr_err.patch?ref_type=heads There is only one laptop model remaining that display some serious problems where loading this patchset makes keys unresponsive or repeats some keys or takes a long time for buttons to register. I have asked the user to response to this thread, providing instructions but as you can see he never did. As an additional note I would say that I plan in the future to mode the asusd implementation of anime to hid-asus and the handshake on 5e is the perfect entrypoint to check for compatibility so I guess just pr_info the unsupported feature for the time being. > Best, > Antheas > >> -- >> i.