From: Lucas Tanure <lucas.tanure@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: David Rhodes <david.rhodes@cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>,
"Takashi Iwai --cc=alsa-devel @ alsa-project . org"
<tiwai@suse.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v3] ASoC: cs35l41: Steam Deck Shared boost properties quirk
Date: Wed, 1 Mar 2023 16:14:05 +0000 [thread overview]
Message-ID: <099945bb-8da6-7a47-5dff-6a1a457fbf7d@collabora.com> (raw)
In-Reply-To: <Y/9mT2ZVzf/5o4QV@sirena.org.uk>
On 01-03-2023 14:50, Mark Brown wrote:
> On Wed, Mar 01, 2023 at 12:44:47PM +0000, Lucas Tanure wrote:
>> Add support for Steam Deck bios old properties. If a Steam deck didn't
>> upgrade the BIOS, the driver should be able to handle the previous
>> properties for shared boost types.
>
> This doesn't build:
>
> /build/stage/linux/sound/soc/codecs/cs35l41.c: In function ‘cs35l41_handle_pdata’:
> /build/stage/linux/sound/soc/codecs/cs35l41.c:1041:36: error: ‘CS35L41_SHD_BOOST_ACTV’ undeclared (first use in this function); did you mean ‘CS35L41_EXT_BOOST’?
> 1041 | hw_cfg->bst_type = CS35L41_SHD_BOOST_ACTV;
> | ^~~~~~~~~~~~~~~~~~~~~~
> | CS35L41_EXT_BOOST
> /build/stage/linux/sound/soc/codecs/cs35l41.c:1041:36: note: each undeclared identifier is reported only once for each function it appears in
> /build/stage/linux/sound/soc/codecs/cs35l41.c:1043:36: error: ‘CS35L41_SHD_BOOST_PASS’ undeclared (first use in this function); did you mean ‘CS35L41_EXT_BOOST’?
> 1043 | hw_cfg->bst_type = CS35L41_SHD_BOOST_PASS;
> | ^~~~~~~~~~~~~~~~~~~~~~
> | CS35L41_EXT_BOOST
>
My mistake, it seems I checkout the wrong tree here with the Shared
boost patches already merged.
This patches needed the previous Shared boost series merged.
I will wait for that patches series to be merged.
Sorry About that.
next prev parent reply other threads:[~2023-03-01 16:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 12:44 Lucas Tanure
2023-03-01 14:50 ` Mark Brown
2023-03-01 16:14 ` Lucas Tanure [this message]
2023-03-01 18:08 ` David Rhodes
2023-03-02 2:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=099945bb-8da6-7a47-5dff-6a1a457fbf7d@collabora.com \
--to=lucas.tanure@collabora.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®