mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: "André Draszik" <andre.draszik@linaro.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
	Peter Griffin <peter.griffin@linaro.org>,
	Tudor Ambarus <tudor.ambarus@linaro.org>,
	Juan Yescas <jyescas@google.com>,
	kernel-team@android.com
Subject: Re: [PATCH] dma-fence: use correct callback in dma_fence_timeline_name()
Date: Thu, 18 Jun 2026 14:46:34 +0200	[thread overview]
Message-ID: <099959fa-3a41-4166-8c10-4e5c2b9fdf19@amd.com> (raw)
In-Reply-To: <20260618-linux-drm_crtc_fix-v1-1-801f29c9853d@linaro.org>

On 6/18/26 14:00, André Draszik wrote:
> dma_fence_timeline_name() is a wrapper around
> dma_fence_ops::get_timeline_name(). Since the blamed commit below, it
> calls an incorrect callback.
> 
> Update it to restore functionality by calling the intended callback.
> 
> Fixes: 62918542b7bf ("dma-fence: Fix sparse warnings due __rcu annotations")
> Signed-off-by: André Draszik <andre.draszik@linaro.org>

I'm like 99% sure we had that already fixed weeks ago, but somehow it looks like that was never merged to drm-misc-fixes.

Anyway Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/dma-buf/dma-fence.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index b3bfa6943a8e..5292d714419b 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -1202,7 +1202,7 @@ const char __rcu *dma_fence_timeline_name(struct dma_fence *fence)
>         /* RCU protection is required for safe access to returned string */
>         ops = rcu_dereference(fence->ops);
>         if (!dma_fence_test_signaled_flag(fence))
> -               return (const char __rcu *)ops->get_driver_name(fence);
> +               return (const char __rcu *)ops->get_timeline_name(fence);
>         else
>                 return (const char __rcu *)"signaled-timeline";
>  }
> 
> ---
> base-commit: e2cae00c05d196491c318196792297f2dfbaa02c
> change-id: 20260618-linux-drm_crtc_fix-267655a1c89f
> 
> Best regards,
> --
> André Draszik <andre.draszik@linaro.org>
> 


  reply	other threads:[~2026-06-18 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-18 12:00 André Draszik
2026-06-18 12:46 ` Christian König [this message]
2026-06-18 18:30   ` Tvrtko Ursulin
2026-06-23 13:08     ` pstanner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=099959fa-3a41-4166-8c10-4e5c2b9fdf19@amd.com \
    --to=christian.koenig@amd.com \
    --cc=andre.draszik@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jyescas@google.com \
    --cc=kernel-team@android.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=sumit.semwal@linaro.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=tvrtko.ursulin@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome