From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933318AbbI1Me1 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 08:34:27 -0400
Received: from terminus.zytor.com ([198.137.202.10]:50148 "EHLO mail.zytor.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932602AbbI1MeY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 08:34:24 -0400
User-Agent: K-9 Mail for Android
In-Reply-To: <1443443037-22077-4-git-send-email-dvlasenk@redhat.com>
References: <1443443037-22077-1-git-send-email-dvlasenk@redhat.com> <1443443037-22077-4-git-send-email-dvlasenk@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain;
 charset=UTF-8
Subject: Re: [PATCH] x86/signal: Deinline get_sigframe, save 240 bytes
From: "H. Peter Anvin" <hpa@zytor.com>
Date: Mon, 28 Sep 2015 05:33:53 -0700
To: Denys Vlasenko <dvlasenk@redhat.com>, Ingo Molnar <mingo@kernel.org>
CC: Andy Lutomirski <luto@amacapital.net>, Borislav Petkov <bp@alien8.de>,
        Brian Gerst <brgerst@gmail.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Message-ID: <099BA174-FB96-4849-BCD2-807D9A6B9580@zytor.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This one makes me slightly nervous, because it isn't clear that these aren't potentially performance sensitive.

On September 28, 2015 5:23:57 AM PDT, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>This function compiles to 277 bytes of machine code and has 4
>callsites.
>
>Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>CC: Ingo Molnar <mingo@kernel.org>
>CC: Andy Lutomirski <luto@amacapital.net>
>CC: "H. Peter Anvin" <hpa@zytor.com>
>CC: Borislav Petkov <bp@alien8.de>
>CC: Brian Gerst <brgerst@gmail.com>
>CC: x86@kernel.org
>CC: linux-kernel@vger.kernel.org
>---
> arch/x86/kernel/signal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c
>index da52e6b..054a4d0 100644
>--- a/arch/x86/kernel/signal.c
>+++ b/arch/x86/kernel/signal.c
>@@ -196,7 +196,7 @@ static unsigned long align_sigframe(unsigned long
>sp)
> 	return sp;
> }
> 
>-static inline void __user *
>+static void __user *
>get_sigframe(struct k_sigaction *ka, struct pt_regs *regs, size_t
>frame_size,
> 	     void __user **fpstate)
> {

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.