From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936198AbdJQPDx (ORCPT ); Tue, 17 Oct 2017 11:03:53 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:43944 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbdJQPDv (ORCPT ); Tue, 17 Oct 2017 11:03:51 -0400 X-Google-Smtp-Source: ABhQp+TbGBq0g+lUNYSlOSwJmG+T4nZ5oM+zS3rmDLHXA8H2LbVsSod67GqxhLbqIPoLBC3qpbq4qw== Subject: Re: [PATCH] mtd: spi-nor: Add support for Winbond w25q16dw To: cyrille.pitchen@wedev4u.fr, marek.vasut@gmail.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org References: <1503925893-17116-1-git-send-email-narmstrong@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: <099bf486-4830-4d19-eb88-bf05d4d6994f@baylibre.com> Date: Tue, 17 Oct 2017 17:03:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1503925893-17116-1-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/08/2017 15:11, Neil Armstrong wrote: > Add JEDEC entry for the Winbond w25q16fw/w25q16dw with similar > flags and format than the Winbond w25q32dw entry. > > Tested on a Khadas VIM2 SBC board with an Amlogic S912 SoC. > > Signed-off-by: Neil Armstrong > --- > drivers/mtd/spi-nor/spi-nor.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index cf1d4a1..2f74583 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -1137,6 +1137,11 @@ static int spi_nor_is_locked(struct mtd_info *mtd, loff_t ofs, uint64_t len) > { "w25x40", INFO(0xef3013, 0, 64 * 1024, 8, SECT_4K) }, > { "w25x80", INFO(0xef3014, 0, 64 * 1024, 16, SECT_4K) }, > { "w25x16", INFO(0xef3015, 0, 64 * 1024, 32, SECT_4K) }, > + { > + "w25q16dw", INFO(0xef6015, 0, 64 * 1024, 32, > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > + }, > { "w25x32", INFO(0xef3016, 0, 64 * 1024, 64, SECT_4K) }, > { "w25q20cl", INFO(0xef4012, 0, 64 * 1024, 4, SECT_4K) }, > { "w25q20bw", INFO(0xef5012, 0, 64 * 1024, 4, SECT_4K) }, > Hi Cyrille, Did you had time to review this patch ? Thanks, Neil