From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98CC2161321 for ; Wed, 15 Jan 2025 18:40:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736966447; cv=none; b=kY5D/IF0oHQqLcCDWRuo+tbnC+1WJtPfq1zfYBOi+IE970sjuYqJCeYWD7maUSebMfrajTKxo5FnWi61XpTUTR3ztZsArPJBmc5Iv2PVpRv9hBS4MN+5n5WM9d08MfKU647HIP2hJeiUxBSIS3HdJTVUutu19uuGpR6tDjq6O/c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736966447; c=relaxed/simple; bh=rkCYpA5/6HyvgCk0Q1kSIaS7X4hbRhHrd+naSGckOAc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DXZR7VIJG4NVvh2JLQ/9AwVVEIiHJzSMS+cVYmeDy8Nsyh4RzxnKhhr1wUu2XVwRG6e9Zsut+PNYl9inuRB8+YT+Ua09TNFto+AmORSkTwOZh2BXWRHMa/UHycbsLXmTLuXVEXjeEGdx0MUimjYRhRs4ShBR1rbg0WUmNM1DBc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XmRrfdbN; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XmRrfdbN" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d96944401dso115577a12.0 for ; Wed, 15 Jan 2025 10:40:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736966444; x=1737571244; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/bMntqLLbRnNm+8V16Mvxg5kR3zMbyGJQK/UUP2AtJg=; b=XmRrfdbNE5JpyoeJLZbVs6QeNAiiYmBan+LQutvHNQeIW0OoNckhEglXfA8uQAsuLL liyc02k40smhsh4/6xFzxHj5vw0MCnAXko+C41uthM8UWJtknmexTFbNL3Pprz7IlBCZ 2ztnbf4ipy9ky8LrdgRnUCXEo9t9EJdQu/BIZKfAoZYGaUV8dvJE4AlkwptT3GBM3oxL JHJb0eFwWWyE8TrhX6e0cWLnMBN2g59LB4Dm4hvqXVU5qvrNMvr4Ua8JAYpsLNK1GbBJ 8WAO2dqcE7mevgHvMkzQxdc17BiclrV6IyEc9HwtWXgfat7Y8Z2klwYJ5lIFawKj1sPV XucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736966444; x=1737571244; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/bMntqLLbRnNm+8V16Mvxg5kR3zMbyGJQK/UUP2AtJg=; b=v9Vupw5IKfhgr4D0udIMCqXXOIWClRia0GxPo5t6OcMZT1YRES2Q9ljZj0gBGtzIfL nhZXiid2aweTa1t0Vn0T/gSUcHypfnXxxilDA8QbpiXy/fcDSppdhpQA6zaUbpVdR9ZA A0YIuh4TtnJkdcw60NDYq8uLjKYwtnNUkanNn0lfOuKZFqhsVWkAY2YPpuKkGuGkVEOJ D0OmcUtOgy4EKGIQgOcjD5xBcGKTdcbl6TwVRYOV0advQ7zpg/DmGW9aSNWGFedNpwWC VsjjPelkq7LLsb+q83WeU/PrhZboAxrp0O954gSXCHmC4OP0JiCU2N3UqDbM8d5oik25 JrUw== X-Forwarded-Encrypted: i=1; AJvYcCV67o1Et8xy4RWRrZHSaKI/a0RxuN7TfXSjD+gJgg2qm8G1Tn+0UOz+bHYooAEeNeT2fy3GsVqiaXb2KqY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw97N9btjHQRBac0nmnh8oH5ahfkMr4LUYsnybufPzePva+F/Uy 4JnMUNm2lvFidOHP88uS3c9IJriEsxJGRtuX6rjNGNoT8JVbXTm/zhbURUzbe24= X-Gm-Gg: ASbGncs/8Jp0uxLc0+SoqPG1jBfk0R8DNmvcPOUJM8AmfKHXf+hGoHe82u6rFsKmryf UgF6a3s6DCBzIChRCvUKOJkkx3lwROpAZCxdhyGz2ppF7afklMDchOdu0pQ5FkwusSigrVbyW9h VGEKcxynN+j2c4W9l0B0Bi6/TE5N31qeqezI+GFzFlW94Liia0EBPXlyXni9omZKsE/5jzHLQ54 Cdwcvlam9Y8HZ2eGhcUeJpmPXUnbEfr3TEryukzMP+x6b2cr/iztvIeovwulQ== X-Google-Smtp-Source: AGHT+IFEhu1Ze7Q3nWToOqZkmLGT5dglBO8lGamc5A7N+ohPNWaVdIrUEnpC//b/4VgLC1z7cN4e6g== X-Received: by 2002:a05:6402:270d:b0:5d3:d4cf:fea0 with SMTP id 4fb4d7f45d1cf-5d972e4c62emr25697586a12.21.1736966443924; Wed, 15 Jan 2025 10:40:43 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d990469e5asm7805305a12.55.2025.01.15.10.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2025 10:40:43 -0800 (PST) Date: Wed, 15 Jan 2025 21:40:40 +0300 From: Dan Carpenter To: Costa Shulyupin Cc: Steven Rostedt , Daniel Bristot de Oliveira , John Kacur , "Luis Claudio R. Goncalves" , Eder Zulian , Tomas Glozar , Gabriele Monaco , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] tools/rtla: Add osnoise_trace_is_off() Message-ID: <099e9ae9-5d36-46bb-8790-1b6a33dc1448@stanley.mountain> References: <20250115180055.2136815-1-costa.shul@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250115180055.2136815-1-costa.shul@redhat.com> On Wed, Jan 15, 2025 at 07:58:30PM +0200, Costa Shulyupin wrote: > The original code accidentally works because offset of > `record->trace` is zero. It doesn't "accidentally work". The people who write this kind of code 100% understand what they are doing. They don't see it as anything complicated. regards, dan carpenter