From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752603AbdFMKde (ORCPT ); Tue, 13 Jun 2017 06:33:34 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:11081 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbdFMKdb (ORCPT ); Tue, 13 Jun 2017 06:33:31 -0400 X-AuditID: b6c32a2c-f79be6d0000051f7-78-593fbf78be4f MIME-version: 1.0 Content-type: text/plain; charset="utf-8"; format="flowed" Subject: Re: [PATCH] drm/exynos/dsi: Remove error handling for bridge_node DT parsing To: Inki Dae , jy0922.shim@samsung.com, sw0312.kim@samsung.com, airlied@linux.ie, kgene@kernel.org, krzk@kernel.org Cc: javier@osg.samsung.com, a.hajda@samsung.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Hoegeun Kwon From: Hoegeun Kwon Message-id: <099ebbf8-4ec2-be45-f1d7-36bf24def429@samsung.com> Date: Tue, 13 Jun 2017 19:33:28 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 In-reply-to: <593FAF9E.1040406@samsung.com> Content-transfer-encoding: 8bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJJsWRmVeSWpSXmKPExsWy7bCmlm7lfvtIgz/tjBa31p1jteg9d5LJ 4srX92wW75d3sVlMuj+BxeLN2zVMFi/uXWSx6H/8mtni/PkN7BabHl9jtbi8aw6bxYzz+5gs Zkx+yebA67FpVSebx/ZvD1g97ncfZ/LYvKTeY0v/XXaPvi2rGD0+b5ILYI9KtclITUxJLVJI zUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLxCdB1y8wBulZJoSwxpxQoFJBYXKyk b2dTlF9akqqQkV9cYqsUbWhopGdoYK5nZGSkZ2Ica2VkClSSkJoxsf0zc8FV7oov13uYGxj3 cnYxcnJICJhITDl5mh3CFpO4cG89WxcjF4eQwFJGift7bzJDOJ8ZJTavm8vYxcgB1vHyZCxE fAejRPPej8wg3bwCghI/Jt9jAbGZBawknv1rZYUoussocav3GCtIQlggXOLhs4VgK0QEuhkl +o8uBatiFnjGKLHl4RtGkCo2AV2Jrz3XmSDG2km0b90GtoJFQFXi5bSTYLaoQITEokkTwQ7n FNCWOH/oFyPEanmJg1eeQ50hLtHcepMFZIGEwEt2iba791kgfpCV2HSAGeJpF4kFC5dBA0BY 4tXxLVC2lER3xywou17i8o6TjBBzGoCunjgbKmEscaqrkQliGZ9E7+8nTBDzeSU62oQgSjwk 7r16CFXuKLF2xTImSLDsZZT42/mRbQKjwiyk4JuFFHyzkPwzC8k/CxhZVjGKpRYU56anFpsW GOoVJ+YWl+al6yXn525iBCdjLZ0djPcWeB9iFOBgVOLhXTHJLlKINbGsuDL3EKMEB7OSCO+c ffaRQrwpiZVVqUX58UWlOanFhxhNgWE8kVlKNDkfmCnySuINTSwNTEzNjA2MDS0slcR5NVZe ixASSE8sSc1OTS1ILYLpY+LglGpgTF/PKdJ91cm0PsB6W793VmfdlfMXC88rbYwIk/jcIJq/ 5Maytd75R/cE6N8+8rnm7m4+SydGxue5unyyCmqqZsrXuk7n5O95Fv/q74zIrMa86ZJMq3YX Xn0e4HfUqKR3JWfhws/PF6TvjjJgdD7x0LFg7mIOvmr70nc9DHGib2cyHtmzrUpCiaU4I9FQ i7moOBEAfhXyEdwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBIsWRmVeSWpSXmKPExsVy+t9jAd2K/faRBv82iVncWneO1aL33Ekm iytf37NZvF/exWYx6f4EFos3b9cwWby4d5HFov/xa2aL8+c3sFtsenyN1eLyrjlsFjPO72Oy mDH5JZsDr8emVZ1sHtu/PWD1uN99nMlj85J6jy39d9k9+rasYvT4vEkugD3KzSYjNTEltUgh NS85PyUzL91WKTTETddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhkT2z8z F1zlrvhyvYe5gXEvZxcjB4eEgInEy5OxXYycQKaYxIV769m6GLk4hAS2MUr8OfiVBSTBKyAo 8WPyPTCbWcBM4svLw6wQRfcZJVZ2fARLCAuESzw5/5gRJCEi0M0o8fbydnYQh1ngGaPEtk1H oObuZ5R4v2QdWAubgK7E157rTBA77CTat25jBrFZBFQlXk47CWaLCkRI7Lp+gBXE5hTQljh/ 6BcjxB3yEgevPIe6SVyiufUmywRGwVlIzp2F5NxZSFpmIWlZwMiyipErtaA4Nz232KjAaBMj MJa3HdYK2MHYdC76EKMAB6MSD++KSXaRQqyJZcWVuYcYJTiYlUR4L+yzjxTiTUmsrEotyo8v Ks1JLT7EaAp0+kRmKdHkfGCaySuJNzSxNDIxMDMzNDIwNlMS550Q+CVCSCA9sSQ1OzW1ILUI po+Jg1OqgdHi2qaYX3GRQWdL1k4P+zjFYkGN5k1R58W1El78H+4yN9pvuOE790nTNavFB9of Xi58cKJ6Ln/Ao9xd5zbMMqpxsLo/YdaHW78Kb4sEP3q3auLlv7f2WGZYsNb8FrmW/LE8rDO8 qv5btPuK3Ud2nAq55X/ugMZ7KYEg8c4FUYtm3k7t4lmzd6mEEktxRqKhFnNRcSIAL+hbsPsC AAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170613103328epcas5p3e1127b50efa646cbf063026811cb38a7 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?6raM7ZqM6re8G1RpemVuIFBsYXRmb3JtIExhYihTL1fshLw=?= =?UTF-8?B?7YSwKRvsgrzshLHsoITsnpAbRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?SG9lZ2V1biBLd29uG1RpemVuIFBsYXRmb3JtIExhYi4bU2Ft?= =?UTF-8?B?c3VuZyBFbGVjdHJvbmljcxtFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1RFTEUbQzEwVjgxMTE=?= CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20170609092307epcas5p3a7851f80bd799626782941a640824521 X-RootMTR: 20170609092307epcas5p3a7851f80bd799626782941a640824521 References: <1497000180-30669-1-git-send-email-hoegeun.kwon@samsung.com> <593FAF9E.1040406@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/13/2017 06:25 PM, Inki Dae wrote: > > 2017년 06월 09일 18:23에 Hoegeun Kwon 이(가) 쓴 글: >> The bridge_node is unnecessary between FIMD and DSIM. If don't remove >> error handling, it will not work between FIMD and DSIM. So remove >> error handling. > Please make sure to describe why bridge_node is unnecessary. > For example, > In case of Exynos SoC, a bridge device such as mDNIe and MIC could be placed between Display Controller and MIPI DSI device but the bridge device is required optionally. > > Thanks, > Inki Dae Remove the error handling for bridge_node because the bridge_node is required optionally. It has already been described in commit message. For example, In case of Exynos 3250 SoC, no bridge_node is required between FIMD and MIPI DSI. Best regards, Hoegeun > >> Signed-off-by: Hoegeun Kwon >> --- >> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> index a11b795..6ee0dac 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c >> @@ -1651,8 +1651,6 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) >> return ret; >> >> dsi->bridge_node = of_graph_get_remote_node(node, DSI_PORT_IN, 0); >> - if (!dsi->bridge_node) >> - return -EINVAL; >> >> return 0; >> } >> >