From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 381A129E117 for ; Sun, 5 Apr 2026 12:50:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775393408; cv=none; b=QazqHhGuXD/TMVN9D9mC2QefOSjyNmOw3pMY20aAHFJx9dgwBFVZWifpOBqNyM9WAItQt2kjv3yJt4Gktjqw2PnlCRp8nyvZq/0gWf2a0Fzg4g1KTVZM2T/HZDSRkbI8S5wmX1SU0Wssh6gvG/KMW5GN58ehJ0cBv31+2LrxLN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775393408; c=relaxed/simple; bh=LcpEC3rE6zBteaE48WUPFXLhegLAKydIJJU5eVjF05k=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=iXZ709EZbRHwR2VQLX4MFbwMy6cRWx1GJFBhWRh0aiQFKDDbS/Jc8IviSkb/SUaW64RsrxhxC42QBw7VLsEYPwUNKAuTJzmS2iU3WncZDq4+2t5sAMW+op5++azIyyVn6gT3tjkbdeaOqwwqQiNybD1vxVQyUKmeFRY2PzLiqUI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F+7aUHCR; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F+7aUHCR" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43cf5fbacc9so1558488f8f.1 for ; Sun, 05 Apr 2026 05:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775393404; x=1775998204; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=c1nOmdjGmdisPsJolJO/R2r/fUOnUgCGQrzxTPrfNdA=; b=F+7aUHCRddLJXIAWr5oCjKt9rf0FtqLb8ABEO7yGl1EQjJG+jq5F/hdH1mMrIsxY8v y2oFfNLZ8AHpVcEc9zNTioxeVfZajoNQr/m9DWM0DGcrIAbkgCMH7MrDGIiBqS6dPRMs IZCUlzQD2JsX1MznJuZnLjkE4yPnDJWG+TgMpdDRgx72sOOPpk1MMEKdC7flsJQ4fohz IxGumIh5EUl6OP7S0FiWVYXSuvUjO8gQmM9M8C4xVD1dX61S20WAyc2Dsv6WCIXQSgS9 pzNmP7XrPnze4dyohdLkWdr45CTKsPcZrFcUHlhQaIE7X0TH3s1EGXJEsrc/DA4Mz/2F Q71Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775393404; x=1775998204; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c1nOmdjGmdisPsJolJO/R2r/fUOnUgCGQrzxTPrfNdA=; b=csFF5zPDptpphd1dP726j5343RUYv3WxvoENDS4k+5OpiNZ//6T3Jt9mCQkNlfBuhZ jDJBIMzeJxpKc5zC6vBn3UmLl/zzDKpuj0mzESe24cK4SdXNbmlEvTPpk0phofCJhWy1 o2EtvlPgtwjDRtuN17BJJ09Mfp5KLhi2aU5O/+O0s7TjTBqd5MDfuqBm6iMKPoKmO8+H 996NZl5zVL3ZydnOcAd+4BQLbD6KWQt7IoCGO8eCZf7VXvM+J9Qj81I4WC0viI50jTfs 0eeHHa9Ebqi/M+yYmLQgWTLgA6e8XRekFwecGO87mll8mxi329Rbsa86wsFK+bOyoI0C f7Qg== X-Forwarded-Encrypted: i=1; AJvYcCXE+jD9/MiBHe+iK4WA6WrsNlROxiPdBqZ8lw9E2X6Wnx+gyqxjFr943vGzxBaTRu7zqVC6ne5sRIAxCwk=@vger.kernel.org X-Gm-Message-State: AOJu0YynblBEpjPpx7+EDPVpM7zVcSJVbxqEBhC3UynrxlAHYmgg1LWH 0uEo+fopSP2IpN8W+uQ176rieHTTI8vItM4uT/pWduXA78m1bhlhgm0= X-Gm-Gg: AeBDieuaSMnoDfiPAmGW/KPy04ML5qD5idldWU6XtX+Kr5ZRl1I/9e11xLfMzM0Xz1u B7XD4sM81D4mf0RwEIbxgdeveO9TcyL1zD6UIqF95E3RNnECuQBgoiLkGyllAop6iY8lWG3amL1 p9gD9dU2tGUah/ySMXW7NWWmDGdbORs6wklpUx3VVzQTNvl6se+cUf9vO83iCUGLFUbtJTyRcut vO2wkZUiJAgj9qNmI5Mfk0OoLZTHfB7ljjVpXIvvrkvcGUi5Bvz6yT4OKqC15uDRKEFJJVjim94 1HH7Oe0seQ0bYmOf9bt8JIibK8Tt3ICreQptw+7d3fFbpxSCFuLyjk0i3vxVfkooo5K3MsgolgS 4dQI2DRt68rXjQ7glRW1Dyh8pwkqEdKXLmKYFB5OwBZEfObbw6mKKdsjWS0KjpmUs7En/eO6Bty 1T3TuItSpAsIe0H3/xUGk3l+g4BxtAcGTLzYuCikCt/MLvcOwIPJHmzM7v82vJjdqDjp63rovYr gpJ4wmv5D/UYGeE/JfxPw== X-Received: by 2002:a05:6000:24c5:b0:43d:33a0:f5b6 with SMTP id ffacd0b85a97d-43d33a0f5d0mr7913845f8f.2.1775393404150; Sun, 05 Apr 2026 05:50:04 -0700 (PDT) Received: from ehlo.thunderbird.net ([46.239.6.110]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4f5294sm29873755f8f.35.2026.04.05.05.50.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Apr 2026 05:50:02 -0700 (PDT) Date: Sun, 05 Apr 2026 14:49:59 +0200 From: Luka Gejak To: Prithvi Tambewagh , gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com, b9788213@gmail.com, straube.linux@gmail.com, ethantidmore06@gmail.com, andriy.shevchenko@linux.intel.com, dan.carpenter@linaro.org, weibu@redadmin.org, knavaneeth786@gmail.com, ignacio.pena87@gmail.com, dharanitharan725@gmail.com, samasth.norway.ananda@oracle.com, karanja99erick@gmail.com, s9430939@naver.com, suunj1331@gmail.com, ysinghcin@gmail.com CC: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BRFT_PATCH_v3_1/5=5D_staging=3A_rtl8723bs=3A_mov?= =?US-ASCII?Q?e_constant_to_right_side_of_test_in_comparison?= User-Agent: Thunderbird for Android In-Reply-To: <20260405114132.310774-2-activprithvi@gmail.com> References: <20260405114132.310774-1-activprithvi@gmail.com> <20260405114132.310774-2-activprithvi@gmail.com> Message-ID: <09A5A0B6-B1FB-49CD-821A-7EFC2224101D@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable LGTM, Reviewed-by: Luka Gejak On April 5, 2026 1:41:28 PM GMT+02:00, Prithvi Tambewagh wrote: >Move constant from the left side to the right side of the test in a >comparison, where =3D=3D, !=3D, <=3D, >=3D, <, > operators are used, fixi= ng the >checkpatch warning: Comparisons should place the constant on the right >side of the test=2E > >Signed-off-by: Prithvi Tambewagh >--- > =2E=2E=2E/staging/rtl8723bs/hal/HalBtc8723b2Ant=2Ec | 4 ++-- > drivers/staging/rtl8723bs/hal/HalPhyRf_8723B=2Ec | 2 +- > drivers/staging/rtl8723bs/hal/hal_com=2Ec | 2 +- > drivers/staging/rtl8723bs/hal/hal_com_phycfg=2Ec | 4 ++-- > =2E=2E=2E/staging/rtl8723bs/hal/rtl8723b_hal_init=2Ec | 18 +++++++++---= ------ > drivers/staging/rtl8723bs/hal/rtl8723bs_xmit=2Ec | 2 +- > drivers/staging/rtl8723bs/include/ieee80211=2Eh | 4 ++-- > 7 files changed, 18 insertions(+), 18 deletions(-) > >diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant=2Ec b/drivers/= staging/rtl8723bs/hal/HalBtc8723b2Ant=2Ec >index d32dbf94858f=2E=2E58f6cf063498 100644 >--- a/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant=2Ec >+++ b/drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant=2Ec >@@ -2211,7 +2211,7 @@ static void halbtc8723b2ant_RunCoexistMechanism(str= uct btc_coexist *pBtCoexist) > } >=20 > algorithm =3D halbtc8723b2ant_ActionAlgorithm(pBtCoexist); >- if (pCoexSta->bC2hBtInquiryPage && (BT_8723B_2ANT_COEX_ALGO_PANHS !=3D = algorithm)) { >+ if (pCoexSta->bC2hBtInquiryPage && (algorithm !=3D BT_8723B_2ANT_COEX_A= LGO_PANHS)) { > halbtc8723b2ant_ActionBtInquiry(pBtCoexist); > return; > } else { >@@ -2490,7 +2490,7 @@ void EXhalbtc8723b2ant_BtInfoNotify( > return; > } >=20 >- if (BT_INFO_SRC_8723B_2ANT_WIFI_FW !=3D rspSource) { >+ if (rspSource !=3D BT_INFO_SRC_8723B_2ANT_WIFI_FW) { > pCoexSta->btRetryCnt =3D pCoexSta->btInfoC2h[rspSource][2] & 0xf; /* [= 3:0] */ >=20 > pCoexSta->btRssi =3D pCoexSta->btInfoC2h[rspSource][3] * 2 + 10; >diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B=2Ec b/drivers/s= taging/rtl8723bs/hal/HalPhyRf_8723B=2Ec >index 9df3274c1048=2E=2E9e7eebfc02a9 100644 >--- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B=2Ec >+++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B=2Ec >@@ -313,7 +313,7 @@ static void GetDeltaSwingTable_8723B( > u16 rate =3D *(pDM_Odm->pForcedDataRate); > u8 channel =3D pHalData->CurrentChannel; >=20 >- if (1 <=3D channel && channel <=3D 14) { >+ if (channel >=3D 1 && channel <=3D 14) { > if (IS_CCK_RATE(rate)) { > *TemperatureUP_A =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_P; > *TemperatureDOWN_A =3D pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_N; >diff --git a/drivers/staging/rtl8723bs/hal/hal_com=2Ec b/drivers/staging/= rtl8723bs/hal/hal_com=2Ec >index 31b3e880ae6a=2E=2E597ba3d283c1 100644 >--- a/drivers/staging/rtl8723bs/hal/hal_com=2Ec >+++ b/drivers/staging/rtl8723bs/hal/hal_com=2Ec >@@ -107,7 +107,7 @@ u8 hal_com_config_channel_plan( > pHalData->bDisableSWChannelPlan =3D false; > chnlPlan =3D def_channel_plan; >=20 >- if (0xFF =3D=3D hw_channel_plan) >+ if (hw_channel_plan =3D=3D 0xFF) > AutoLoadFail =3D true; >=20 > if (!AutoLoadFail) { >diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg=2Ec b/drivers/s= taging/rtl8723bs/hal/hal_com_phycfg=2Ec >index dc2da49e6738=2E=2E9e523491a008 100644 >--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg=2Ec >+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg=2Ec >@@ -462,11 +462,11 @@ u8 PHY_GetTxPowerIndexBase( >=20 > if (IS_CCK_RATE(Rate)) > txPower =3D pHalData->Index24G_CCK_Base[RFPath][chnlIdx]; >- else if (MGN_6M <=3D Rate) >+ else if (Rate >=3D MGN_6M) > txPower =3D pHalData->Index24G_BW40_Base[RFPath][chnlIdx]; >=20 > /* OFDM-1T */ >- if ((MGN_6M <=3D Rate && Rate <=3D MGN_54M) && !IS_CCK_RATE(Rate)) >+ if ((Rate >=3D MGN_6M && Rate <=3D MGN_54M) && !IS_CCK_RATE(Rate)) > txPower +=3D pHalData->OFDM_24G_Diff[RFPath][TX_1S]; >=20 > if (BandWidth =3D=3D CHANNEL_WIDTH_20) { /* BW20-1S, BW20-2S */ >diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init=2Ec b/driver= s/staging/rtl8723bs/hal/rtl8723b_hal_init=2Ec >index 8d259820f103=2E=2E02c3f4229e74 100644 >--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init=2Ec >+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init=2Ec >@@ -405,11 +405,11 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padap= ter, bool bUsedWoWLANFw) > break; > } > _FWDownloadEnable(padapter, false); >- if (_SUCCESS !=3D rtStatus) >+ if (rtStatus !=3D _SUCCESS) > goto fwdl_stat; >=20 > rtStatus =3D _FWFreeToGo(padapter, 10, 200); >- if (_SUCCESS !=3D rtStatus) >+ if (rtStatus !=3D _SUCCESS) > goto fwdl_stat; >=20 > fwdl_stat: >@@ -1165,15 +1165,15 @@ s32 rtl8723b_InitLLTTable(struct adapter *padapte= r) >=20 > static void hal_get_chnl_group_8723b(u8 channel, u8 *group) > { >- if (1 <=3D channel && channel <=3D 2) >+ if (channel >=3D 1 && channel <=3D 2) > *group =3D 0; >- else if (3 <=3D channel && channel <=3D 5) >+ else if (channel >=3D 3 && channel <=3D 5) > *group =3D 1; >- else if (6 <=3D channel && channel <=3D 8) >+ else if (channel >=3D 6 && channel <=3D 8) > *group =3D 2; >- else if (9 <=3D channel && channel <=3D 11) >+ else if (channel >=3D 9 && channel <=3D 11) > *group =3D 3; >- else if (12 <=3D channel && channel <=3D 14) >+ else if (channel >=3D 12 && channel <=3D 14) > *group =3D 4; > } >=20 >@@ -1221,7 +1221,7 @@ static void Hal_ReadPowerValueFromPROM_8723B( >=20 > memset(pwrInfo24G, 0, sizeof(struct TxPowerInfo24G)); >=20 >- if (0xFF =3D=3D PROMContent[eeAddr+1]) >+ if (PROMContent[eeAddr+1] =3D=3D 0xFF) > AutoLoadFail =3D true; >=20 > if (AutoLoadFail) { >@@ -2035,7 +2035,7 @@ static void hw_var_set_bcn_func(struct adapter *pad= apter, u8 variable, u8 *val) > val8 &=3D ~(EN_BCN_FUNCTION | EN_TXBCN_RPT); >=20 > /* Always enable port0 beacon function for PSTDMA */ >- if (REG_BCN_CTRL =3D=3D bcn_ctrl_reg) >+ if (bcn_ctrl_reg =3D=3D REG_BCN_CTRL) > val8 |=3D EN_BCN_FUNCTION; >=20 > rtw_write8(padapter, bcn_ctrl_reg, val8); >diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit=2Ec b/drivers/s= taging/rtl8723bs/hal/rtl8723bs_xmit=2Ec >index a1f2cbf2cf55=2E=2E9f6503ac2234 100644 >--- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit=2Ec >+++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit=2Ec >@@ -413,7 +413,7 @@ int rtl8723bs_xmit_thread(void *context) > if (signal_pending(current)) { > flush_signals(current); > } >- } while (_SUCCESS =3D=3D ret); >+ } while (ret =3D=3D _SUCCESS); >=20 > complete(&pxmitpriv->SdioXmitTerminate); >=20 >diff --git a/drivers/staging/rtl8723bs/include/ieee80211=2Eh b/drivers/st= aging/rtl8723bs/include/ieee80211=2Eh >index 0f28c904a714=2E=2E0f378830462f 100644 >--- a/drivers/staging/rtl8723bs/include/ieee80211=2Eh >+++ b/drivers/staging/rtl8723bs/include/ieee80211=2Eh >@@ -395,8 +395,8 @@ enum { > }; >=20 > #define IS_HT_RATE(_rate) (_rate >=3D MGN_MCS0 && _rate <=3D MGN_MCS3= 1) >-#define IS_CCK_RATE(_rate) (MGN_1M =3D=3D _rate || _rate =3D=3D MGN_2= M || _rate =3D=3D MGN_5_5M || _rate =3D=3D MGN_11M) >-#define IS_OFDM_RATE(_rate) (MGN_6M <=3D _rate && _rate <=3D MGN_54M = && _rate !=3D MGN_11M) >+#define IS_CCK_RATE(_rate) (_rate =3D=3D MGN_1M || _rate =3D=3D MGN_2= M || _rate =3D=3D MGN_5_5M || _rate =3D=3D MGN_11M) >+#define IS_OFDM_RATE(_rate) (_rate >=3D MGN_6M && _rate <=3D MGN_54M = && _rate !=3D MGN_11M) >=20 >=20 > /* NOTE: This data is for statistical purposes; not all hardware provide= s this