From: Pengfei Wang <wpengfeinudt@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Vaishali Thakkar <vaishali.thakkar@oracle.com>,
Kees Cook <keescook@chromium.org>,
Vaishali Thakkar <vthakkar1994@gmail.com>,
linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.com>,
cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] coccicheck: add a test for repeat copy_from_user
Date: Wed, 11 Jan 2017 21:44:00 +0800 [thread overview]
Message-ID: <09D4B047-4E54-4A3B-9EDB-B1F5E87A660B@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1701110708030.2396@hadrien>
> 在 2017年1月11日,下午2:12,Julia Lawall <julia.lawall@lip6.fr> 写道:
>
> I looked at the get_user part of the original script. It looks like most
> of the complexity is to deal with the possibility of the src location
> being expressed in two different ways between the two calls.
Yes, in addition to pointer alias and the “field-whole” double-fetch type
as we mentioned previously, we also need to take into consideration of
the explicit data type conversion of the src pointer, such as:
get_user(dst, src)
…
get_user(dst, (int*)src)
Also the embedded computation at the argument position, such as
get_user(dst, ++src) , get_user(dst, align(src)), or get_user(dst, src[i]),
which could cause false positives. Loops also cause false positives.
> Even if this
> happens in practice only for get_user, it would seem that it could happen
> for copy_from_user as well. So I think we could just throw both get_user
> and copy_from_user into the same rule?
>
Agreed.
> I'm also not sure to understand why there are cases for things like
>
> get_user(exp1, src->f1)
> ...
> get_user(exp2,src)
>
> Can this happen? The types seem wrong.
I think it is unreasonable. It doesn’t work in practice. It exists in my script
because I combined different situations with disjunction but forgot to remove
the infeasible ones. Please remove it. A practical one should be:
get_user(exp1, src->f1)
…
copy_from_user(exp2, src ,size)
> Likewise, I see the need to take into account a second argument of src++,
> but not the need to take into account a second argument of src+4. Either
> there is src+4 in both calls or the addresses involved are just different.
src++ or src+4 are used when handling long messages byte by byte or word
by word by means of a loop. I paid attention to these because they cause
false positives as src pointers have changed for the double fetches. I remember
both of these two situations when examining the source code but I cannot
guarantee the src+4 situation exists as I don’t have an example in hand now. I suggest
we focus on the src++ for now. If src+4 cause any false positives, we’ll add it, too.
Regards
Pengfei
>
> Perhaps I'm missing something, though.
>
> julia
>
next prev parent reply other threads:[~2017-01-11 13:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 22:24 Kees Cook
2016-04-26 22:30 ` Kees Cook
2016-12-27 18:21 ` Julia Lawall
2017-01-09 17:05 ` [Cocci] " Vaishali Thakkar
2017-01-09 19:08 ` Julia Lawall
2017-01-09 20:56 ` Kees Cook
2017-01-09 22:02 ` Kees Cook
[not found] ` <05AE3A59-EF48-4FFF-A028-0204B2E56DEB@gmail.com>
2017-01-10 8:40 ` Vaishali Thakkar
[not found] ` <19545870-5238-4BEB-AF1E-741BA97A6AA2@gmail.com>
2017-01-10 17:46 ` Vaishali Thakkar
[not found] ` <76D088EA-3C7E-4766-A237-3FA1F0767C1A@gmail.com>
2017-01-11 6:12 ` Julia Lawall
2017-01-11 13:44 ` Pengfei Wang [this message]
2017-01-10 19:16 ` Kees Cook
2017-01-10 19:15 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09D4B047-4E54-4A3B-9EDB-B1F5E87A660B@gmail.com \
--to=wpengfeinudt@gmail.com \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=vaishali.thakkar@oracle.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®