From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75951326947 for ; Wed, 7 Jan 2026 14:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767794891; cv=none; b=osDE5BwHeq/41HY3tB5MbNifY/Ceb8Bcz+cpKFbbxeOpCZPk519C7ned0kl/WDn8RsMT1fZxSP7mai9u/2xRzVQ7OwRsYxoJrCPO1ZrRQS/bAsdMV7nhLJgrWVpxRqBlES7CgsznW0I4XU8PIhtR9q4tdpdAWVG9GJCTu5UkF9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767794891; c=relaxed/simple; bh=mCbn5kuKUVOa7StqdNfdgtoPVjIvEhpYuWWE9PJhHbI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N2T6FC+TXMlh8Xsyd5RRX9X4VYHWHUgxHF1+CYVtkVJcCb5n4UFb9RXOnZ1zYyXqjYAcWK43dRsoIG4JTmLKu3WPqmwUpZsexHVCYn7+1y+p4C6veDp4PU3HlB9ITTRPFdwweLF2BIqtaZp+kya4rRgcDldCvjfRL4d8I9IeSWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UBmKmXa8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NkOEhDSK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UBmKmXa8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NkOEhDSK" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 607CsTp52239483 for ; Wed, 7 Jan 2026 14:08:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mCbn5kuKUVOa7StqdNfdgtoPVjIvEhpYuWWE9PJhHbI=; b=UBmKmXa8lJdanWPk 9kQMooo71A92HE7SGebPQ9STM8M+9pq6NRg8hbacBluETQb8u+OeIvIxmi5QV1Jr PPJdfU+cqC24l9Ui5QXrV8HaJWZmBMNoge3SDtRbrJNE4HUPdYuKhXIEComH/kSZ ZnhYEQ7tTCAp6G+VtP/I5N7zVGPQ9+bew655fML/x62frlELdJzEj/T7Y7Pr8W4j +6BtDdiCIzQzxFA77rKgy/Wm1hyR48d4HPmcPVkRzJGwjpMmxbFcMLvd8YLzLmPQ 3nm0I42bAyVexV9CKB79GExN/2KYdHL/O9gl4baTg83yDBqG04DgH+YNuoCP39+I A+qYtw== Received: from mail-yx1-f69.google.com (mail-yx1-f69.google.com [74.125.224.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bhqwg06uj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 07 Jan 2026 14:08:08 +0000 (GMT) Received: by mail-yx1-f69.google.com with SMTP id 956f58d0204a3-640d4dc536aso651909d50.1 for ; Wed, 07 Jan 2026 06:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767794888; x=1768399688; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mCbn5kuKUVOa7StqdNfdgtoPVjIvEhpYuWWE9PJhHbI=; b=NkOEhDSKta21OHf6Ejf5UQXtSiR7lSkd0De4rUEE2GSlULWXNqaZNenOVoJFbAqh7+ YXXaTli55uq7Raysvais9CwIhv45iBdV1Vv970fqxvzRfIkO3y4PGC5Q5ijNnQs6cSoX BNm5W6y7CZBSZiRxDPENQMQWYhIl2C1Z1SdxgCto4roePMkRuQXLS9iMlpk1qGkA2aK2 jmmizSKLkDUCN7ETd1l/9GxX5NRfSzwxlEYMAZSF7KUoppXG2E3cU2JT6AGQ7qSHEc0x JOoELehuUkm5JJq/O7uygGMcO25SHnXJGUjmllyMiFvzC2jSVNou37lN8mQL9Msq7Or7 eRBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767794888; x=1768399688; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mCbn5kuKUVOa7StqdNfdgtoPVjIvEhpYuWWE9PJhHbI=; b=lwzk2bkDTsoea3Kjpn/RFMKUFjb/9FlUz8nUZSZNNFHmiGZ9I+HIdST9VHenIZ6xju smptgdJIpzrCC8TnTa9VJ158L2SxAx/gbCsarfelmHDid9vgABbJFXghAp0+xLIFadlb mrGJhnWM8ArmPRD3XPT28SGGcgBx5Rsx4K4DNP6B+si97ycthTsld3/c8MgUF9vb26ri vh3gw9CK0nJplICVfVnnj5lL2nBHeM7nkR7V1TT9wNepi8PKjt2Aj558wnYwICPzlnOh Goimdy48ab66PKwikPtcD1SXzLbRT/sfJL1CbE+B1t47Q6hTi0H0tnqRgYd6o5OGM0k5 smXA== X-Forwarded-Encrypted: i=1; AJvYcCW+ISgUyRgFeZ/WkWUBngj0DjLb8fSsewAgNVHVPrlA0Df2TqorSCrI386xnppRWcJePdTabAJHzvJe7QA=@vger.kernel.org X-Gm-Message-State: AOJu0YztlR8ERBW5bGf2STxHhgnqQ2VIxKyXWvxnqNqAcUEgXZSj/KVw JKTDDXP0Ituu0/1pLId9uwgdpSZPIvimewVp96URYDCCv66BwT/l1dS/hWTu4hfgKz+icquqpBR 7YOw51k9OkvQAjEEs5/jKmhYJJcv1ufgE2lv4SzTp/9H5/Rn/HHDORWJuYarBJg5ic/k= X-Gm-Gg: AY/fxX7Rnh/jJ+tHxzTHwWDtfFUHSg9iv26tM/k6mZaYq3MD/aPCnFb8Ed7URy99cPF NL7FdSVI2vvhGyp7F3SU1Rk/zxbmaUENSrqAYSnJCeFK91B9lVi2VS4khQyXS0Q760SmDa4uPa0 ZOOHJCiIRjyicjnBD+xkMwpPyoyLIXZmkNmeFubhZLg06iL7wxvwp7Qe/9tZjvsIcocKiD/SI0Q fMICNY8Vzvu/xNLLjTGFFAvZAFV52RcOTLHU4NPMmzjOA2wuknt263FTYvED6B3+rWnmVHFbOuR MwtVqVw8ABPt3BzGMmmq6Ge4ViRL4E3IhBR59jT6TXcEEl6WYwtYaYWDpbE92Jfbou7BQczzJe0 /QGRiN/iAd6fmmwpbhpPzsEQmrq7Oo4sEj+MR9T17sMwkYo7Pokw08eyZ3E/yL+vO3O8= X-Received: by 2002:a05:690c:9:b0:78c:2c4d:3df9 with SMTP id 00721157ae682-790b54b5af8mr27270467b3.0.1767794888329; Wed, 07 Jan 2026 06:08:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IHyUpA3k3b3g5qtKWK7Tl1X2D7wG2aBAVLD35CZGCs0GMhgDfMQ+H933I+o6Rq2dV0QTyPUnQ== X-Received: by 2002:a05:690c:9:b0:78c:2c4d:3df9 with SMTP id 00721157ae682-790b54b5af8mr27270177b3.0.1767794887752; Wed, 07 Jan 2026 06:08:07 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a56962esm529552466b.66.2026.01.07.06.08.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 06:08:07 -0800 (PST) Message-ID: <09a4642a-3552-44e7-97bd-b26e6937ad8b@oss.qualcomm.com> Date: Wed, 7 Jan 2026 15:08:04 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] arm64: dts: qcom: msm8953-xiaomi-vince: correct wled ovp value To: =?UTF-8?B?QmFybmFiw6FzIEN6w6ltw6Fu?= , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Kiran Gunda , Helge Deller , Luca Weiss , Konrad Dybcio , Eugene Lepshy , Gianluca Boiano , Alejandro Tafalla Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Thompson , linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org References: <20260107-pmi8950-wled-v1-0-5e52f5caa39c@mainlining.org> <20260107-pmi8950-wled-v1-3-5e52f5caa39c@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260107-pmi8950-wled-v1-3-5e52f5caa39c@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: qayjJNR5yXRkYahtVJkRW4ikOqTX1jYi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA3MDEwOSBTYWx0ZWRfXy/KAcUKPegqW gtp/v5a7Su7eaBvVQw4IsaZUZ4N0tqvBDmQiN9wH6eY3jg/hyvkgxfcVRz/LoTeDqDW+7oYB8R/ n90v63O18o3LKHb/kV2RweC9MvBjsiK6GgK2Dtnr7Qrlf6oCRaOjAzrlDwiRRRcH+55CCwdAKtA UlmAHuKAJVvEUz/n92/4ipOoQB/v/ft3AW3LZXRr85olOrXVKhSfk+lWrzDFVoibyuERK/d7jwg 3gOxXdWKWg6lEkMFHQMEqhxXlKVSRXXAUO4rzg3fJOR7PZYKPZQVx7ISAQPXMzEwNptb9MbE697 heZfD4tSrdNFtN+Ns+OnhKBGxBzWCtucOpQU0aMKvUiOhc9MVdjApWrY4fC1T4az0Nr9ixy2WJR 7Zf2JqJQ09R3InfQYbfy7HFQMKXZtL/o0bEjgukeY+t11JB62MtKc7uuDMv0Xpfl4x3eVLSungO XvwsXFZljx8SrKltSEA== X-Authority-Analysis: v=2.4 cv=Pa7yRyhd c=1 sm=1 tr=0 ts=695e68c8 cx=c_pps a=J+5FMm3BkXb42VdG8aMU9w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=cwWn7d2NfpHSwl1uxIYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=Epx66wHExT0cjJnnR-oj:22 X-Proofpoint-ORIG-GUID: qayjJNR5yXRkYahtVJkRW4ikOqTX1jYi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-07_02,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 spamscore=0 malwarescore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601070109 On 1/7/26 2:31 PM, Barnabás Czémán wrote: > Correct wled ovp value from 29600 to 29500. This tells us what the fix is, but not why the fix needs to be made. We can infer the former from the patch contents, but it's really important that the next reader, perhaps in 5 years, can find out the reason it was made. How about: """ PMI8950 doesn't actually support setting an OVP threshold value of 29.6 V. The closest allowed value is 29.5 V. Set that instead. """ With this or similar commit message: Reviewed-by: Konrad Dybcio Konrad