From: Pu Lehui <pulehui@huawei.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf <bpf@vger.kernel.org>,
linux-riscv@lists.infradead.org,
Networking <netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Björn Töpel" <bjorn@kernel.org>,
"Luke Nelson" <luke.r.nels@gmail.com>,
"Xi Wang" <xi.wang@gmail.com>, "Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>
Subject: Re: [PATCH bpf-next v3 6/6] selftests/bpf: Remove the casting about jited_ksyms and jited_linfo
Date: Thu, 7 Jul 2022 19:55:25 +0800 [thread overview]
Message-ID: <09b87170-09e1-167f-4afa-ed516fa688ac@huawei.com> (raw)
In-Reply-To: <CAEf4Bza4RT=KFhr9ev29967dyT0eF_+6ZRqK35beUvnA_NbcqQ@mail.gmail.com>
On 2022/6/4 5:05, Andrii Nakryiko wrote:
> On Mon, May 30, 2022 at 1:58 AM Pu Lehui <pulehui@huawei.com> wrote:
>>
>> We have unified data extension operation of jited_ksyms and jited_linfo
>> into zero extension, so there's no need to cast u64 memory address to
>> long data type.
>>
>> Signed-off-by: Pu Lehui <pulehui@huawei.com>
>> ---
>> tools/testing/selftests/bpf/prog_tests/btf.c | 14 +++++++-------
>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/tools/testing/selftests/bpf/prog_tests/btf.c b/tools/testing/selftests/bpf/prog_tests/btf.c
>> index e6612f2bd0cf..65bdc4aa0a63 100644
>> --- a/tools/testing/selftests/bpf/prog_tests/btf.c
>> +++ b/tools/testing/selftests/bpf/prog_tests/btf.c
>> @@ -6599,8 +6599,8 @@ static int test_get_linfo(const struct prog_info_raw_test *test,
>> }
>>
>> if (CHECK(jited_linfo[0] != jited_ksyms[0],
>> - "jited_linfo[0]:%lx != jited_ksyms[0]:%lx",
>> - (long)(jited_linfo[0]), (long)(jited_ksyms[0]))) {
>> + "jited_linfo[0]:%llx != jited_ksyms[0]:%llx",
>> + jited_linfo[0], jited_ksyms[0])) {
>
> __u64 is not always printed with %lld, on some platforms it is
> actually %ld, so to avoid compiler warnings we just cast them to long
> long or unsigned long long (and then %lld or %llu is fine). So please
> update this part here and below.
>
I found that __u64 in ppc64 actually is defined to be unsigned long. I
will update it. Thanks.
>> err = -1;
>> goto done;
>> }
>> @@ -6618,16 +6618,16 @@ static int test_get_linfo(const struct prog_info_raw_test *test,
>> }
>>
>> if (CHECK(jited_linfo[i] <= jited_linfo[i - 1],
>> - "jited_linfo[%u]:%lx <= jited_linfo[%u]:%lx",
>> - i, (long)jited_linfo[i],
>> - i - 1, (long)(jited_linfo[i - 1]))) {
>> + "jited_linfo[%u]:%llx <= jited_linfo[%u]:%llx",
>> + i, jited_linfo[i],
>> + i - 1, jited_linfo[i - 1])) {
>> err = -1;
>> goto done;
>> }
>>
>> if (CHECK(jited_linfo[i] - cur_func_ksyms > cur_func_len,
>> - "jited_linfo[%u]:%lx - %lx > %u",
>> - i, (long)jited_linfo[i], (long)cur_func_ksyms,
>> + "jited_linfo[%u]:%llx - %llx > %u",
>> + i, jited_linfo[i], cur_func_ksyms,
>> cur_func_len)) {
>> err = -1;
>> goto done;
>> --
>> 2.25.1
>>
> .
>
next prev parent reply other threads:[~2022-07-07 11:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-30 9:28 [PATCH bpf-next v3 0/6] Support riscv jit to provide Pu Lehui
2022-05-30 9:28 ` [PATCH bpf-next v3 1/6] bpf: Unify data extension operation of jited_ksyms and jited_linfo Pu Lehui
2022-05-30 9:28 ` [PATCH bpf-next v3 2/6] riscv, bpf: Support riscv jit to provide bpf_line_info Pu Lehui
2022-05-30 9:28 ` [PATCH bpf-next v3 3/6] bpf: Correct the comment about insn_to_jit_off Pu Lehui
2022-05-30 9:28 ` [PATCH bpf-next v3 4/6] libbpf: Unify memory address casting operation style Pu Lehui
2022-05-30 21:03 ` Daniel Borkmann
2022-06-03 21:03 ` Andrii Nakryiko
2022-07-07 12:23 ` Pu Lehui
2022-07-08 22:30 ` Andrii Nakryiko
2022-07-09 1:32 ` Pu Lehui
2022-07-07 11:49 ` Pu Lehui
2022-05-30 9:28 ` [PATCH bpf-next v3 5/6] selftests/bpf: " Pu Lehui
2022-05-30 9:28 ` [PATCH bpf-next v3 6/6] selftests/bpf: Remove the casting about jited_ksyms and jited_linfo Pu Lehui
2022-06-03 21:05 ` Andrii Nakryiko
2022-07-07 11:55 ` Pu Lehui [this message]
2022-05-30 21:00 ` [PATCH bpf-next v3 0/6] Support riscv jit to provide patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09b87170-09e1-167f-4afa-ed516fa688ac@huawei.com \
--to=pulehui@huawei.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luke.r.nels@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=songliubraving@fb.com \
--cc=xi.wang@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®