From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CBEF1C28E for ; Tue, 21 Oct 2025 09:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761037649; cv=none; b=RmR8ZZHvUbrIRF+J0CzgkmTy+nqMgbPdHedyXuOJPypDvzlh+StfVPnyIfQ/9rnMB77Sh0gfKvHxcrRVU2ie6z193rAZ1uU6Lr5tCY8u3ZIq/hYj2DiA6xH+/Jimiq9FJm3K/hlLQfGK+De55j55g7UYk3Hzs9/Fz7y/sr8wNeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761037649; c=relaxed/simple; bh=tUqEp6FRotyZoHUqJl+M1N4DLR56pVmELzujGzEYun0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=STZXhPnfCQLC4SmoTdTicWQWToJ053C4Mo2fSpU2ub4R5eouWlatxx5nRvNnx7C0hiY5YK4Q9Ipn5jlzDb90f6sAPcg8DEzQ3ZGhbSw+2g2lM69ON/iUNekSaJbz3/oXQgh3uVTIzkZFuAKePihysiQqA0E0CLt/sVmAfvHLeJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WDF4SbQR; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WDF4SbQR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761037646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vxuYfXKfr3imHgkQvW2ygYGzwCXEJYL5J80r//u9SeE=; b=WDF4SbQRlQdN9VfTLyNd/ONOmKm8t8q1gD5kYRUtFkunH8I/Jt5dgmS9kE6Fs/aj0KTihs 0y4YqYPkWcgeN6MMZDR4a55RD+kO5XNA6fmzz7q5RlIlvuZkgeKLEiU9qokTS+243Uf1dV ZRFkuNTblNyJhCt9M2Jk6X9Ckr9Tb+Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-245-UyNs7N43OeC8byYwXgv2CA-1; Tue, 21 Oct 2025 05:07:24 -0400 X-MC-Unique: UyNs7N43OeC8byYwXgv2CA-1 X-Mimecast-MFC-AGG-ID: UyNs7N43OeC8byYwXgv2CA_1761037644 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-470fd5ba449so18062485e9.0 for ; Tue, 21 Oct 2025 02:07:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761037643; x=1761642443; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vxuYfXKfr3imHgkQvW2ygYGzwCXEJYL5J80r//u9SeE=; b=sxZenkhNrumZe1wJEHgUz1Go1b1FsrGzKg2j+F81zYtKSz8HWXZAPnYiXCsySN4DEX 0TqivhcFxqCclF7zdkuhVlZxV2OKvAkrYCWM8XUIuzWFOPt2q/sQVIlhoZz7trCs+jMh nWkmwVIo3kCaP5Fshdq0AgOaLRIWvteO56NS9dHIVQG6SRD7EafS57c669aYH720OZDG hgBSAsa3DMDWzO16N6LvvtrWX22hnGD57BIiph8DRoGOfvNHi/KePCJEs8Nwhy8JwJt3 fcEMbNeaLePjjAwWNFjYoB4LMTZvDpOX2CZE7qXMz8uZiBgLf2Mctp2wStXT0384yxNG wlhQ== X-Forwarded-Encrypted: i=1; AJvYcCVVbFouNJHJxtIWtWiibS3SRVLDYZZbYX3ZMM/9HpUnCwM81vIR9rQNYg+QOh6yelTDgyoocUX4LlvQ4j0=@vger.kernel.org X-Gm-Message-State: AOJu0YyJGiQB2v3VirBFVwMwYtM9V9B/0IFSPNNeGT6b1juhmA5/v1Ri 29Q+L3rWs+RyGb6ktsuwUqK6NmbEEA0zVSQsqI4t6mIfgihPHbIJQ6ivuW3UK/jT5O5GvKer41K +wD/Ab6ilQpDvCM+e5Q3TykT210rbiUiVeq3ov2QvCF1Lw5BH2BFfhQAi3Ph5WDxKBg== X-Gm-Gg: ASbGncvs+bMJRsTUTqMMKjr31CaAZlzB1slLxQVX4qdAjC5RCQKzlYt23I3ut++y/ug 3dT0rpboeRtHBK9ffhgGCJ8uIwoM/f868Eigb5FBykJNDM3CK8PsbPCjq4w5j0IJND/G+DlDnHf kOtskHxoEUkueWHQPQQbNCJcjVCUg8rwzbQswc17jLitg+pHygvhXPTyzMh6o05t58RODT58std +mZLHnBn42uTdMHGeMzO/4604rXfBBnLda1HUGaRXmykoOyR6wzko5QCDYHOuXRjKAVxPyVWo0x aUM1LpdCzGtQKFcs6wcQNCUwmVDz8Weg86ZxCPbOomfrzpaBtkDJWWW+X2lMcMsK2L9TsI8aqk1 POS+FU7Wc0VFrzr0Kx5XZkjmxSmNLifnekDhDHZ3fQjlTvUQ= X-Received: by 2002:a5d:64e7:0:b0:3e7:428f:d33 with SMTP id ffacd0b85a97d-42704bc0e86mr14305331f8f.16.1761037643470; Tue, 21 Oct 2025 02:07:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8Gy9jf6dORCTbvPabRPFqLZ9AU3h3AuGcVYPrbC7L1U5/N9elmMWZ2CnLRn1z2Vj5o0vp+A== X-Received: by 2002:a5d:64e7:0:b0:3e7:428f:d33 with SMTP id ffacd0b85a97d-42704bc0e86mr14305293f8f.16.1761037643038; Tue, 21 Oct 2025 02:07:23 -0700 (PDT) Received: from ?IPV6:2a0d:3344:2712:7e10:4d59:d956:544f:d65c? ([2a0d:3344:2712:7e10:4d59:d956:544f:d65c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427f009a96asm19525120f8f.31.2025.10.21.02.07.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 02:07:22 -0700 (PDT) Message-ID: <09b90c94-4b55-4b9f-a23b-e2bd920545bf@redhat.com> Date: Tue, 21 Oct 2025 11:07:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v4 2/2] phy: mscc: Fix PTP for VSC8574 and VSC8572 To: Jakub Kicinski , andrew@lunn.ch Cc: Horatiu Vultur , hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, richardcochran@gmail.com, vladimir.oltean@nxp.com, vadim.fedorenko@linux.dev, rmk+kernel@armlinux.org.uk, christophe.jaillet@wanadoo.fr, rosenp@gmail.com, steen.hegelund@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251017064819.3048793-1-horatiu.vultur@microchip.com> <20251017064819.3048793-3-horatiu.vultur@microchip.com> <20251020165346.276cd17e@kernel.org> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251020165346.276cd17e@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/21/25 1:53 AM, Jakub Kicinski wrote: > On Fri, 17 Oct 2025 08:48:19 +0200 Horatiu Vultur wrote: >> For VSC8574 and VSC8572, the PTP initialization is incomplete. It is >> missing the first part but it makes the second part. Meaning that the >> ptp_clock_register() is never called. >> >> There is no crash without the first part when enabling PTP but this is >> unexpected because some PHys have PTP functionality exposed by the >> driver and some don't even though they share the same PTP clock PTP. > > I'm tempted to queue this to net-next, sounds like a "never worked > in an obvious way" case. I'd appreciate a second opinion.. Andrew? FTR, I agree with the above, as (out of sheer ignorance) I think/fear the first patch can potentially cause regressions. /P