From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 173AA223C5C; Thu, 19 Dec 2024 12:14:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734610472; cv=none; b=vB5sZ+aMWMFDSzA1WIYqtezMonK8oLwueW59LBOkQW6xL0tXqUwfaOvpDgj4y7p4NccGYykfTfsY5SNDkFWbedTuM7DmlQKs6x1WixquXPSjzlV1qfyz7w0zK7DCz7d0zXIa9IzgXLsNXmUux7bV+GCf0EeQwUZLFi4aOYxVy70= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734610472; c=relaxed/simple; bh=jswSLq35Y+IdsUb0wXzPhwIdE6q0OErga8nf6MPHT6A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mTe3NhQE3+p1QVC31rY/5JOK9bAjChrHecVBdVZ1Tq/jxpfBxnI08LldpXTf1DGvbrA5hyG7WZJ4mvadWnCFNw5jBB8ftBWfZe7Lo+aH8RMistYGAfZ4HL4eCohOwt55/i7XLa4Yj477NtvSyugWQqzRZfyICVpYFZr0hWu1PU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HM7CuuFv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HM7CuuFv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0571DC4CECE; Thu, 19 Dec 2024 12:14:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734610471; bh=jswSLq35Y+IdsUb0wXzPhwIdE6q0OErga8nf6MPHT6A=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=HM7CuuFvV+m3KHpxPviNp9JAG32VxXqJ3QinE6rmVvUFIZiGDtKkhPGRUVG6+XdiA afdy7JBfqkoO/GGqyp6gSjNwe2cDGhLqmB7mKqL0Z0ngQUn7UlT2bR3Kbjk1/r+Bzg m3nbj/gRAxsRZZcJG29EGQsS7k5MJ0KgNGOiX5WQfeRUCiTvGcshiLd3iicF8OlEtd UJba77Pfk1fZCxNA4CLY7nZL/LGYh5UI3lNV2X6ePb2bfPNj0ECc1WWGeOMR+qO11L hqdYybX2EA6SSalfU83YpLQZn8vdEUFprobuEVSKzDvkQt/z9xFh3felGHkriPVO14 EylpJ6lvEBW5Q== Message-ID: <09bee93e-48bd-4a7c-b975-b10dce945d60@kernel.org> Date: Thu, 19 Dec 2024 13:14:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] dt-bindings: display: Fix BCM2835 HVS bindings for BCM2712 To: Dave Stevenson Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Eric Anholt , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Ray Jui , Scott Branden , Doug Berger , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Stefan Wahren , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Florian Fainelli , linux-gpio@vger.kernel.org References: <20241218-dt-bcm2712-fixes-v4-0-54cc88b6c229@raspberrypi.com> <20241218-dt-bcm2712-fixes-v4-2-54cc88b6c229@raspberrypi.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/12/2024 12:54, Dave Stevenson wrote: > Hi Krzysztof > > On Thu, 19 Dec 2024 at 08:42, Krzysztof Kozlowski wrote: >> >> On Wed, Dec 18, 2024 at 02:48:33PM +0000, Dave Stevenson wrote: >>> Commit 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings") >>> added the compatible string for BCM2712, but missed out that >>> the number of interrupts and clocks changed too, and both need to be >>> named. >>> >>> Update to validate clock, interrupts, and their names for the variants. >>> >>> Fixes: 6cfcbe548a3a ("dt-bindings: display: Add BCM2712 HVS bindings") >>> Signed-off-by: Dave Stevenson >>> --- >>> .../bindings/display/brcm,bcm2835-hvs.yaml | 84 ++++++++++++++++++---- >>> 1 file changed, 70 insertions(+), 14 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml >>> index f91c9dce2a44..fd25ee5ce301 100644 >>> --- a/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml >>> +++ b/Documentation/devicetree/bindings/display/brcm,bcm2835-hvs.yaml >>> @@ -20,11 +20,20 @@ properties: >>> maxItems: 1 >>> >>> interrupts: >>> - maxItems: 1 >>> + minItems: 1 >>> + maxItems: 3 >>> + >>> + interrupt-names: >>> + minItems: 1 >>> + maxItems: 3 >>> >>> clocks: >>> - maxItems: 1 >>> - description: Core Clock >>> + minItems: 1 >>> + maxItems: 2 >>> + >>> + clock-names: >>> + minItems: 1 >>> + maxItems: 2 >>> >>> required: >>> - compatible >>> @@ -33,17 +42,64 @@ required: >>> >>> additionalProperties: false >>> >>> -if: >>> - properties: >>> - compatible: >>> - contains: >>> - enum: >>> - - brcm,bcm2711-hvs >>> - - brcm,bcm2712-hvs >>> - >>> -then: >>> - required: >>> - - clocks >>> +allOf: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + const: brcm,bcm2711-hvs >>> + >>> + then: >>> + properties: >>> + clocks: >>> + items: >>> + - description: Core Clock >>> + interrupts: >>> + maxItems: 1 >> >> >> clock-names and interrupt-names: false, unless driver needs them but all >> this should be explained in the commit msg because it would be a change >> to the binding. > > False it is then. > > Is there actually a full guide to binding requirements? > https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-schema.html > is the closest I've found, but it doesn't obviously cover these types > of things. > >>> + >>> + required: >>> + - clocks >>> + >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + const: brcm,bcm2712-hvs >>> + >>> + then: >>> + properties: >>> + clocks: >>> + minItems: 2 >>> + maxItems: 2 >>> + clock-names: >>> + items: >>> + - const: core >>> + - const: disp >>> + interrupts: >>> + items: >>> + - description: Channel 0 End of frame >>> + - description: Channel 1 End of frame >>> + - description: Channel 2 End of frame >>> + interrupt-names: >>> + items: >>> + - const: ch0-eof >>> + - const: ch1-eof >>> + - const: ch2-eof >>> + required: >>> + - clocks >>> + - clock-names >>> + - interrupt-names >> >> My previous comment still stands. Reply to people's feedback instead of >> ignoring it. > > Your previous comment was > "Why requiring last two names? Commit msg does not explain that." > > I didn't ignore it. The driver needs them, and the commit msg states Uh, so someone added undocumented ABI. How this passed any checks? Or no one cared to run validation? > " but missed out that the number of interrupts and clocks changed too, > and *both need to be > named*. Ah, I really did not get this. > Update to validate clock, interrupts, and *their names* for the variants." Please say explicitly that since some commit driver needs this. There should be a clear reason in the commit msg why you are adding this ABI. Best regards, Krzysztof