From: Robin Murphy <robin.murphy@arm.com>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Rob Clark <robdclark@chromium.org>,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org
Cc: Xin Tan <tanxin.ctf@gmail.com>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
"Isaac J. Manjarres" <isaacm@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 2/2] iommu/arm-smmu: Propagate errors from platform_get_irq()
Date: Thu, 23 Dec 2021 14:19:21 +0000 [thread overview]
Message-ID: <09bf1d0a-44d8-b382-2e08-e0c79f4fbbaf@arm.com> (raw)
In-Reply-To: <20211223130046.9365-3-prabhakar.mahadev-lad.rj@bp.renesas.com>
On 2021-12-23 13:00, Lad Prabhakar wrote:
> The driver overrides the error code returned by platform_get_irq() to
> -ENODEV. Switch to propagating the error code upstream so that errors
> such as -EPROBE_DEFER are handled.
I wouldn't usually expect an SMMU to be wired up to a secondary
interrupt controller that could cause deferral, but on the other hand I
don't think there's any good reason *not* to propagate the original
error anyway, so sure, why not.
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu.c b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> index 4844cd075644..6cf5612efcda 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu.c
> @@ -2129,7 +2129,7 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
> int irq = platform_get_irq(pdev, i);
>
> if (irq < 0)
> - return -ENODEV;
> + return irq;
> smmu->irqs[i] = irq;
> }
>
prev parent reply other threads:[~2021-12-23 14:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 13:00 [PATCH 0/2] iommu/arm-smmu: Use platform_irq_count() Lad Prabhakar
2021-12-23 13:00 ` [PATCH 1/2] iommu/arm-smmu: Use platform_irq_count() to get the interrupt count Lad Prabhakar
2021-12-23 14:14 ` Robin Murphy
2021-12-23 17:36 ` Lad, Prabhakar
2022-02-08 15:19 ` Will Deacon
2022-02-08 15:28 ` Robin Murphy
2022-02-08 15:31 ` Will Deacon
2021-12-23 13:00 ` [PATCH 2/2] iommu/arm-smmu: Propagate errors from platform_get_irq() Lad Prabhakar
2021-12-23 14:19 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09bf1d0a-44d8-b382-2e08-e0c79f4fbbaf@arm.com \
--to=robin.murphy@arm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=tanxin.ctf@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®