From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Gleb Fotengauer-Malinovskiy" <glebfm@altlinux.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Claudio Imbrenda" <imbrenda@linux.vnet.ibm.com>
Cc: "Dmitry V. Levin" <ldv@altlinux.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: Fix KVM_S390_GET_CMMA_BITS ioctl definition
Date: Mon, 10 Jul 2017 20:43:12 +0200 [thread overview]
Message-ID: <09c0760e-729d-548a-c3c4-b3afd9e67225@de.ibm.com> (raw)
In-Reply-To: <20170710144410.GA10359@glebfm.cloud.tilaa.com>
On 07/10/2017 04:44 PM, Gleb Fotengauer-Malinovskiy wrote:
> This ioctl actually writes to parameter too.
Maybe rephrase that to:
The kernel does not only read struct kvm_s390_cmma_log for KVM_S390_GET_CMMA_BITS,
it also writes back a return value making this _IOWR instead of _IOW.
> Fixes: 4036e387 ("KVM: s390: ioctls to get and set guest storage attributes")
> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Out of curiosity, how did you notice that?
> ---
> include/uapi/linux/kvm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
> index c0b6dfe..ebd604c 100644
> --- a/include/uapi/linux/kvm.h
> +++ b/include/uapi/linux/kvm.h
> @@ -1351,7 +1351,7 @@ struct kvm_s390_ucas_mapping {
> /* Available with KVM_CAP_X86_SMM */
> #define KVM_SMI _IO(KVMIO, 0xb7)
> /* Available with KVM_CAP_S390_CMMA_MIGRATION */
> -#define KVM_S390_GET_CMMA_BITS _IOW(KVMIO, 0xb8, struct kvm_s390_cmma_log)
> +#define KVM_S390_GET_CMMA_BITS _IOWR(KVMIO, 0xb8, struct kvm_s390_cmma_log)
> #define KVM_S390_SET_CMMA_BITS _IOW(KVMIO, 0xb9, struct kvm_s390_cmma_log)
>
> #define KVM_DEV_ASSIGN_ENABLE_IOMMU (1 << 0)
>
next prev parent reply other threads:[~2017-07-10 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-10 14:44 Gleb Fotengauer-Malinovskiy
2017-07-10 18:43 ` Christian Borntraeger [this message]
2017-07-10 21:22 ` [PATCH v2] " Gleb Fotengauer-Malinovskiy
2017-07-10 21:23 ` [PATCH] " Gleb Fotengauer-Malinovskiy
2017-07-11 8:21 ` Christian Borntraeger
2017-07-11 14:21 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09c0760e-729d-548a-c3c4-b3afd9e67225@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=glebfm@altlinux.org \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=ldv@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®