From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25F06C47082 for ; Mon, 7 Jun 2021 10:01:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B04F6023B for ; Mon, 7 Jun 2021 10:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbhFGKDH convert rfc822-to-8bit (ORCPT ); Mon, 7 Jun 2021 06:03:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230217AbhFGKCy (ORCPT ); Mon, 7 Jun 2021 06:02:54 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BDF4C061766 for ; Mon, 7 Jun 2021 03:01:02 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqC45-0002ml-62; Mon, 07 Jun 2021 12:01:01 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1lqC44-0004iF-Ce; Mon, 07 Jun 2021 12:01:00 +0200 Message-ID: <09cc7bc4b14b4995352bd4bd08d3aee556202c06.camel@pengutronix.de> Subject: Re: [PATCH] reset: berlin: support module build From: Philipp Zabel To: Jisheng Zhang Cc: linux-kernel@vger.kernel.org Date: Mon, 07 Jun 2021 12:01:00 +0200 In-Reply-To: <20210607175642.1c0e8ba4@xhacker.debian> References: <20210520171316.395de63e@xhacker.debian> <9f5bee632ed493b150c47f3127242c259a385192.camel@pengutronix.de> <20210607174445.3d532e6b@xhacker.debian> <562cabc4162d9f2c0fb3a307213ec1c5b4bb5535.camel@pengutronix.de> <20210607175642.1c0e8ba4@xhacker.debian> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-06-07 at 17:56 +0800, Jisheng Zhang wrote: > On Mon, 07 Jun 2021 11:49:45 +0200 > Philipp Zabel wrote: > > > > > > On Mon, 2021-06-07 at 17:44 +0800, Jisheng Zhang wrote: > > > On Mon, 07 Jun 2021 11:23:57 +0200 > > > Philipp Zabel wrote: > > > > > > > > > > On Thu, 2021-05-20 at 17:13 +0800, Jisheng Zhang wrote: > > > > > Make reset-berlin driver to be tristate module, support to build as > > > > > a module, this is useful for GKI. > > > > > > > > > > Partially revert commit ed4dba99cae8 ("reset: berlin: make it > > > > > explicitly non-modular") > > > > > > > > > > Signed-off-by: Jisheng Zhang > > > > > --- > > > > > drivers/reset/Kconfig | 4 ++-- > > > > > drivers/reset/reset-berlin.c | 10 ++++++++-- > > > > > 2 files changed, 10 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig > > > > > index 3e7f55e44d84..1e7443a4dae1 100644 > > > > > --- a/drivers/reset/Kconfig > > > > > +++ b/drivers/reset/Kconfig > > > > > @@ -43,8 +43,8 @@ config RESET_BCM6345 > > > > > This enables the reset controller driver for BCM6345 SoCs. > > > > > > > > > > config RESET_BERLIN > > > > > - bool "Berlin Reset Driver" if COMPILE_TEST > > > > > - default ARCH_BERLIN > > > > > + tristate "Berlin Reset Driver" > > > > > + depends on ARCH_BERLIN || COMPILE_TEST > > > > > > > > Is there a reason not to keep "default ARCH_BERLIN"? > > > > > > > > > > Hi, > > > > > > After this patch, the reset driver will be built as module in most cases > > > so I removed default ARCH_BERLIN > > > > I see, how about "default m if ARCH_BERLIN" then? > > Good idea. I think "default m" is enough, because we have a "depends on > ARCH_BERLIN || COMPILE_TEST" above "default m" would also enable the module for COMPILE_TEST by default, which may not be what most compile testers need. regards Philipp