From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62C9341DEE4 for ; Thu, 9 Jul 2026 15:39:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783611589; cv=none; b=lfnucOBm/Lec6Oa9wZ2yc+y0QZvy9U8hfemUPJcQxedRj2zROFwuYhx34DyTyACGZbA4WbOmJ9yasBuzsHWU9HD+J4qnx8O4yJoDJlrDl0MIPRlkN+bnd3OUt6JMR4PJI0yo82+R7c23fkcJxLfyHIaZeHGkDu1hoyFACphqvIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783611589; c=relaxed/simple; bh=ju50s5SZz0t3nId/ce1zzfx+fcngI4ZgBuNx8dshLhI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L+anIE4c/aInK6yPt3fM77DYA5qOC3cn47M9ZdWwedDusc7mXvtVgKetTGiI7OXCkP90/mKbklxeI/dOa5EstnvUxfcxUs9Jo522D6yNpxXQOMM0ZpUm64H5z9werf/Wai6CovQJ1WL2pg2ElC4XpHbFtG9r+kzS20GLHs/Pizw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hO1sHLzT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hO1sHLzT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48CA11F000E9; Thu, 9 Jul 2026 15:39:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783611583; bh=kVXGUPyVE/gPHZozvkVaevlfIH20EKgMQa6Ayk5jZFc=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=hO1sHLzTZ+Jmqi9H2QHWYu8ak6/WV223JIlPiKoMgqY8e/Wm5Z9e5730/Ntdvb5k5 QHfi22V+/CpN+6jsOZ/5Xk7jkwAU1Zs+S35hx9zaFamXaG+3Ufuf2B5ak1qk1uGGBY YfVa06DIxF9J2q2eAc4XM2jb/De0EXk6llx6//ZzNnSdCfE+OxoMrqMx510u8orfwM aUj+0q7UP2SxRmPcleCJBW5y+Q/wPudePHWb+dv5kVmTUy7XE63q//hq8Zl8Si0V6x GAvC+atDoIuYuMtqQMsR2rXiPQt1JtDNE+dzEkbCnEHbsrU7D9dGnMFowBHYWMV3Xd aQWlyYgy4GHaQ== Message-ID: <09d01959-3c26-40e6-8585-945671518dee@kernel.org> Date: Thu, 9 Jul 2026 10:39:41 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] firmware: stratix10-svc: fix FCS SMC call kernel-doc Content-Language: en-US To: "Chan, Genevieve" , Greg Kroah-Hartman , Ang Tien Sung , linux-kernel@vger.kernel.org Cc: Tze Yee Ng , Adrian Ng Ho Yin , Nazim Amirul , Hang Suan Wang References: <20260706055541.74783-1-genevieve.chan@altera.com> <6c061c83-4e71-49ff-be70-9051d0f624b5@altera.com> From: Dinh Nguyen In-Reply-To: <6c061c83-4e71-49ff-be70-9051d0f624b5@altera.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/7/26 00:02, Chan, Genevieve wrote: > On 6/7/2026 9:56 pm, Dinh Nguyen wrote: >> >> >> On 7/6/26 00:55, genevieve.chan@altera.com wrote: >>> From: Genevieve Chan >>> >>> Correct kernel-doc errors for two FCS SMC calls: >>> >>> INTEL_SIP_SMC_FCS_SEND_CERTIFICATE: >>> - Describe as async to match STD_CALL_VAL usage >>> - Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED >>> >>> INTEL_SIP_SMC_FCS_GET_PROVISION_DATA: >>> - Replace FCS-specific status macros with standard status macros >>>    (INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED) >>> - Restore return register documentation for a1 (mailbox error), >>>    a2 (physical address), and a3 (structure size) >>> >>> Fixes: 4a4709d470e6 ("firmware: stratix10-svc: add new FCS commands") >>> Fixes: 4b0a32016347 ("firmware: stratix10-svc: change get provision >>> data to async SMC call") >> >> I see how this patch fixes 4a4709d470e6 but I don't see how this patch >> fixes 4b0a32016347. Can you justify how it fixes the second commit? > > Hi Dinh, > > The fixes for 4b0a32016347 includes modifying the original macro > definition description section for register a1-a3 as well as the return > status description of the INTEL_SIP_SMC_FCS_GET_PROVISION_DATA cmd. > Applied! Thanks, Dinh