From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A2F7C433B4 for ; Thu, 1 Apr 2021 22:16:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B62846112E for ; Thu, 1 Apr 2021 22:16:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234884AbhDAWQe (ORCPT ); Thu, 1 Apr 2021 18:16:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234366AbhDAWQb (ORCPT ); Thu, 1 Apr 2021 18:16:31 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9423C061788 for ; Thu, 1 Apr 2021 15:16:29 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id a12so2424398pfc.7 for ; Thu, 01 Apr 2021 15:16:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=20/XsB+4nOjyVNc3FO5kZBSjhLzmibdPtDV2QDGrEKY=; b=nyyidNBycRid3npH/SZFrDzLYulf0Qdo3b0lzm34Pqrj0FZjUv/r/Ln/QwjeYQhk5s hEG0Z2LzVUo1SXSjaNKV7r2wxdsbV0Qitap1EZ1J9NlAZRyMWLdR17+IzxnHDu4Et0/J qSSZauNWIRP1Q6/Vh1X5wASeWOikw55ZpiJmzjPK1DWhGEMTvultBRdRmq9q+rZyQX3P RdPy/S0YErFITH7yl7rlOknt+SJRn4Drs7rk0FdPR+WNXMWT29Jfr3XIsZxs3Qk74E18 urly6ck0LH58BcqXsItZsh5xPxdXOVUrl7OiNfptLHeX2glm6Yj/S4nPO6GrDZqHmrGg AXwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=20/XsB+4nOjyVNc3FO5kZBSjhLzmibdPtDV2QDGrEKY=; b=Fo/g6g5wMszRn5/OcFRzXGHD2mqM2ymCN21OLpAI031U14TkzyCbFPTL5bSYvZyTfk pJAOt6pH8GsUAT1UNvP/XqsXNfU2GkPuTFg0mkelh/mj4P6FxhN3lO1v9lwbjXsG+Paa h1n+TZk1pOakQeWK1bzd+8Nk1mNA5yHTd6n9Wg2J6tfKPKYPxPxNqQrX62SqVPQPsLze YyCfLyO1gkugAKNvgsOwwQxFYpvDDIIv9pbyoC5zqPMDrEZashMP5bZTDtxAuFgZ9JsQ bZP/wHkmefrDmyneQ4y5OGiJqClqgPnt9Mv1LF6u0EuubBK8LCCt85r+DMpIHUG4uxcV V+xA== X-Gm-Message-State: AOAM5314v0Y+UWQ9C3XRE9zWzwRHjsfQKFoDh47aWnQXC2R31K6MpiQm 2Usqlh7eMjp+H4gQ+vwz4vY= X-Google-Smtp-Source: ABdhPJz38eh3WuSyN0IkxFTsQTKOkqp+n1Kao3wMI7GQxPkkiGZvbmXsJ3r2w5B5zMn87e5lSDzCwg== X-Received: by 2002:a65:4243:: with SMTP id d3mr9648485pgq.180.1617315389461; Thu, 01 Apr 2021 15:16:29 -0700 (PDT) Received: from djbComp.hitronhub.home (S0106ac202ecb0523.gv.shawcable.net. [70.67.120.89]) by smtp.gmail.com with ESMTPSA id d13sm6671494pgb.6.2021.04.01.15.16.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Apr 2021 15:16:29 -0700 (PDT) From: Deborah Brouwer To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com, marcocesati@gmail.com, fabioaiuto83@gmail.com, dan.carpenter@oracle.com, phil@philpotter.co.uk, amarjargal16@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, Deborah Brouwer Subject: [PATCH v3 2/3] staging: rtl8723bs: core: add * to block comments Date: Thu, 1 Apr 2021 15:15:41 -0700 Message-Id: <09db7fd3bed9a0ce00289d686a4e8dea256082e5.1617314121.git.deborahbrouwer3563@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add * at the beginning of each line in block comments to conform to the Linux kernel coding style. Issue detected using checkpatch. Signed-off-by: Deborah Brouwer --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 59 +++++++++++------------ 1 file changed, 28 insertions(+), 31 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 3878caf0b56c..428c71ce0334 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -46,8 +46,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) init_completion(&pxmitpriv->terminate_xmitthread_comp); /* - Please insert all the queue initializaiton using _rtw_init_queue below - */ + * Please insert all the queue initializaiton using _rtw_init_queue below + */ pxmitpriv->adapter = padapter; @@ -60,10 +60,10 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) _rtw_init_queue(&pxmitpriv->free_xmit_queue); /* - Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, - and initialize free_xmit_frame below. - Please also apply free_txobj to link_up all the xmit_frames... - */ + * Please allocate memory with the sz = (struct xmit_frame) * NR_XMITFRAME, + * and initialize free_xmit_frame below. + * Please also apply free_txobj to link_up all the xmit_frames... + */ pxmitpriv->pallocated_frame_buf = vzalloc(NR_XMITFRAME * sizeof(struct xmit_frame) + 4); @@ -1069,17 +1069,15 @@ u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *pattrib) } /* - -This sub-routine will perform all the following: - -1. remove 802.3 header. -2. create wlan_header, based on the info in pxmitframe -3. append sta's iv/ext-iv -4. append LLC -5. move frag chunk from pframe to pxmitframe->mem -6. apply sw-encrypt, if necessary. - -*/ + * This sub-routine will perform all the following: + * + * 1. remove 802.3 header. + * 2. create wlan_header, based on the info in pxmitframe + * 3. append sta's iv/ext-iv + * 4. append LLC + * 5. move frag chunk from pframe to pxmitframe->mem + * 6. apply sw-encrypt, if necessary. + */ s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe) { struct pkt_file pktfile; @@ -1693,23 +1691,22 @@ static void rtw_init_xmitframe(struct xmit_frame *pxframe) } /* -Calling context: -1. OS_TXENTRY -2. RXENTRY (rx_thread or RX_ISR/RX_CallBack) - -If we turn on USE_RXTHREAD, then, no need for critical section. -Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... - -Must be very, very cautious... - -*/ + * Calling context: + * 1. OS_TXENTRY + * 2. RXENTRY (rx_thread or RX_ISR/RX_CallBack) + * + * If we turn on USE_RXTHREAD, then, no need for critical section. + * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... + * + * Must be very, very cautious... + */ struct xmit_frame *rtw_alloc_xmitframe(struct xmit_priv *pxmitpriv)/* _queue *pfree_xmit_queue) */ { /* - Please remember to use all the osdep_service api, - and lock/unlock or _enter/_exit critical to protect - pfree_xmit_queue - */ + * Please remember to use all the osdep_service api, + * and lock/unlock or _enter/_exit critical to protect + * pfree_xmit_queue + */ struct xmit_frame *pxframe = NULL; struct list_head *plist, *phead; -- 2.17.1