From: "Arnd Bergmann" <arnd@arndb.de>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hongyan Xu" <getshell@seu.edu.cn>
Cc: "John Stultz" <jstultz@google.com>,
"Amit Pundir" <amit.pundir@linaro.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn,
"Benjamin Copeland" <ben.copeland@linaro.org>
Subject: Re: [PATCH] misc: hisi_hikey_usb: cancel role switch work on remove
Date: Wed, 29 Jul 2026 16:38:12 +0200 [thread overview]
Message-ID: <09de27ea-ce5a-4207-a94b-67a56e378342@app.fastmail.com> (raw)
In-Reply-To: <2026072955-paternity-dynamic-56ae@gregkh>
On Wed, Jul 29, 2026, at 15:42, Greg Kroah-Hartman wrote:
> On Wed, Jul 29, 2026 at 06:56:18PM +0800, Hongyan Xu wrote:
>> Thanks for the context. I wasn't aware that the driver had no upstream
>> DT user or binding.
>>
>> Given that, I will hold off on revising this patch. If removing the
>> unused driver is the preferred direction, I can prepare a separate
>> removal patch.
>
> Sorry, yes, that's what I was wanting to ask as well.
I asked around internally, and Ben Copeland mentioned that the hikey960
itself should still work fine with mainline kernels, but the role switch
driver was never getting tested.
I think we can just remove this driver. If anyone wants to get
the functionality working later, they can reintroduce a working
version in drivers/phy/, where all other usb-role-switch support
lives these days.
Arnd
next prev parent reply other threads:[~2026-07-29 14:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 6:55 Hongyan Xu
2026-07-29 2:54 ` John Stultz
2026-07-29 8:03 ` Arnd Bergmann
2026-07-29 10:56 ` Hongyan Xu
2026-07-29 13:41 ` Greg Kroah-Hartman
2026-07-29 13:42 ` Greg Kroah-Hartman
2026-07-29 14:38 ` Arnd Bergmann [this message]
2026-07-29 15:45 ` Hongyan Xu
2026-07-29 15:45 ` [PATCH] misc: hisi_hikey_usb: remove untested role-switch driver Hongyan Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09de27ea-ce5a-4207-a94b-67a56e378342@app.fastmail.com \
--to=arnd@arndb.de \
--cc=amit.pundir@linaro.org \
--cc=ben.copeland@linaro.org \
--cc=getshell@seu.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=jianhao.xu@seu.edu.cn \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®