From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbdK3O5M (ORCPT ); Thu, 30 Nov 2017 09:57:12 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:37593 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752500AbdK3O5K (ORCPT ); Thu, 30 Nov 2017 09:57:10 -0500 Reply-To: shuah@kernel.org Subject: Re: [PATCH] usbip: fix usbip attach to find a port that matches the requested speed To: Greg KH , Shuah Khan Cc: valentina.manea.m@gmail.com, yuyang.du@intel.com, k.opasiak@samsung.com, kstewart@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, juan.zea@qindel.com, Shuah Khan , Shuah Khan References: <20171129222422.19037-1-shuahkh@osg.samsung.com> <20171130082033.GA18429@kroah.com> From: Shuah Khan Message-ID: <09e82933-981b-0cef-3364-baa04aa9a4c3@kernel.org> Date: Thu, 30 Nov 2017 07:56:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171130082033.GA18429@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/30/2017 01:20 AM, Greg KH wrote: > On Wed, Nov 29, 2017 at 03:24:22PM -0700, Shuah Khan wrote: >> usbip attach fails to find a free port when the device on the first port >> is a USB_SPEED_SUPER device and non-super speed device is being attached. >> It keeps checking the first port and returns without a match getting stuck >> in a loop. >> >> Fix it check to find the first port with matching speed. >> >> Reported-by: Juan Zea >> Signed-off-by: Shuah Khan >> --- >> tools/usb/usbip/libsrc/vhci_driver.c | 14 +++++++++++--- >> 1 file changed, 11 insertions(+), 3 deletions(-) > > Does this need to go to the stable trees? > Yes it does. I forgot to tag this for stable. There is another one from Yuyang Du that needs to go into stable. I am just about to Ack that. These need to go tino 4.13 as well, but looks like 4.13 is all done now. So definitely for 4.14 [PATCH] usbip: Fix USB device hang due to wrong enabling of scatter-gather thanks, -- Shuah