From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Michal Kubecek <mkubecek@suse.cz>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org
Cc: Johannes Berg <johannes@sipsolutions.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 3/3] ethtool: reject unrecognized request flags
Date: Mon, 16 Mar 2020 12:39:44 +0300 [thread overview]
Message-ID: <09ec9c9b-10d3-510b-df0d-bf9f06bf99da@cogentembedded.com> (raw)
In-Reply-To: <40d6e189e3661dc996f7646c848bfb067ac324cb.1584292182.git.mkubecek@suse.cz>
Hello!
On 15.03.2020 20:17, Michal Kubecek wrote:
> As pointed out by Jakub Kicinski, we ethtool netlink code should respond
s/we/the/?
> with an error if request head has flags set which are not recognized by
> kernel, either as a mistake or because it expects functionality introduced
> in later kernel versions.
>
> To avoid unnecessary roundtrips, use extack cookie to provide the
> information about supported request flags.
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
[...]
MBR, Sergei
next prev parent reply other threads:[~2020-03-16 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 17:17 [PATCH net 0/3] ethtool: fail with error if request has unknown flags Michal Kubecek
2020-03-15 17:17 ` [PATCH net 1/3] netlink: allow extack cookie also for error messages Michal Kubecek
2020-03-15 17:17 ` [PATCH net 2/3] netlink: add nl_set_extack_cookie_u32() Michal Kubecek
2020-03-15 17:17 ` [PATCH net 3/3] ethtool: reject unrecognized request flags Michal Kubecek
2020-03-16 9:39 ` Sergei Shtylyov [this message]
2020-03-16 9:04 ` [PATCH net 0/3] ethtool: fail with error if request has unknown flags David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ec9c9b-10d3-510b-df0d-bf9f06bf99da@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome