From: Philipp Stanner <phasta@mailbox.org>
To: Zhang Heng <zhangheng@kylinos.cn>,
axboe@kernel.dk, phasta@kernel.org,
andriy.shevchenko@linux.intel.com, broonie@kernel.org,
lizetao1@huawei.com, viro@zeniv.linux.org.uk,
fourier.thomas@gmail.com, anuj20.g@samsung.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] block: mtip32xx: Remove excess code in mtip_pci_probe
Date: Wed, 27 Aug 2025 15:50:10 +0200 [thread overview]
Message-ID: <09ef0b44eef45a534fc3230e9dfaeebb36a08e44.camel@mailbox.org> (raw)
In-Reply-To: <20250827131228.2826678-1-zhangheng@kylinos.cn>
On Wed, 2025-08-27 at 21:12 +0800, Zhang Heng wrote:
> In the error exit function of the iomap_err in mtip_pci_probe,
> pci_set_drvdata(pdev, NULL) and return can be removed without
> affecting the code execution
>
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
Reviewed-by: Philipp Stanner <phasta@kernel.org>
> ---
> drivers/block/mtip32xx/mtip32xx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
> index 8fc7761397bd..2c33c1dfc39d 100644
> --- a/drivers/block/mtip32xx/mtip32xx.c
> +++ b/drivers/block/mtip32xx/mtip32xx.c
> @@ -3840,8 +3840,6 @@ static int mtip_pci_probe(struct pci_dev *pdev,
>
> iomap_err:
> kfree(dd);
> - pci_set_drvdata(pdev, NULL);
> - return rv;
> done:
> return rv;
> }
next prev parent reply other threads:[~2025-08-27 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 13:12 Zhang Heng
2025-08-27 13:50 ` Philipp Stanner [this message]
2025-09-01 6:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ef0b44eef45a534fc3230e9dfaeebb36a08e44.camel@mailbox.org \
--to=phasta@mailbox.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=fourier.thomas@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=phasta@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zhangheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®