From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A890F3AEF2A for ; Wed, 19 Aug 2026 14:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787148053; cv=none; b=YwIrjtCvO/OPeY/nntzuwr/5zX2m+EMImTj9Ks4WbyoRa+q1y04VLq8+rImwYWpWKyA75ltK0WlzB7OwMaCJEU9AAtFrs+TvpPW6Bc0AvYNRjymf7PUaYEtg25AqV5rSEDbWb3BPhbjJTZRDEXDCIftgYYuKz7MOL9dxJ13Yy/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787148053; c=relaxed/simple; bh=62e1kUMESzzCwuPSSGbFS0/epS4ablyVxUFHfRq4wfc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G7dlngIp/5/clV3mZ4/RtIuf6uGU+3ggHHy/CqLHP3ak53tFAPCOCVnNHCU6WZqea385JyBrbaud4tGIply4w7GlcDV3fpyCKIoR9KjIu8SqZ2H4SiVOQiMatDjjzFGm0/nVv+LpoNuN6Q5rBFAXDiGSvNB4sVNWubFlBIjjfmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RKpRwjQW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dikIMSZX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RKpRwjQW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dikIMSZX" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JD0R9I4114610 for ; Wed, 19 Aug 2026 14:00:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nF2NpJFe2HGshGcRjWNfEWmWVrM0+Bh1qZpz0JDv/hg=; b=RKpRwjQWmEDYC1k5 hms4mMV3ZkvzUyIf1+wcPVTqDIWwiqp4T9wJVhzHnO/AMcYn97K8TgFKp1RSt7Zg V/S+HaSEbrEJ9S6q9hp8b0bjxeO953rtTJH/S7jNQAGkJJgboCg6BByHR8miTEwW dEd7iSTzbsj/pT22tmZ1S4GWQsT68Q7/94XscwmtiyYxM3R15s4GBlY11xU6J4b0 iU946LqKzbzVjGZl0z11VdCrojPPbMTciDsZ6kewgm7ftAQzRSYHAhWjOnb2zUTr jq0oN3hUzXwBUn9dxq7LpWSDh4Gf7KzQZ3m7DKfbCP7uM0CBAfIhVw9K8pa9ThPv h+6Y7g== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yfmbhjq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 14:00:50 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-930b81c13b0so19564785a.0 for ; Wed, 19 Aug 2026 07:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787148049; x=1787752849; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nF2NpJFe2HGshGcRjWNfEWmWVrM0+Bh1qZpz0JDv/hg=; b=dikIMSZX1WiraT0fLjmVAS/wOiaQkC2hbpvCqpnHjeo6OkOduud6rcWafj/o8S5lS/ vGX/0aRT+zYFL3W3jOZl0EsCC0RPTuxbm/8HaRR/x17M8GarYBsh8+nCAuSWlCO/Q+tU 0yHQB9N5Xso1IxcbAXydT8U9AAkPgXTS2HQ8hKw7+f6enA8CyovSjyEmuZTANvQNOOIB dS/tF6I3A4gdkYFhuRefB5KSpV/jPa8yQXCfXTLbZpipZeBUe0F9X6TnUv9x9YWAgKMS izpH70JwqkUbzABdXfFcAafFSAe0nDyRPhjSL5vyH20/chGpXRnvyvqZR3J5jU4JN6FR aLuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787148049; x=1787752849; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nF2NpJFe2HGshGcRjWNfEWmWVrM0+Bh1qZpz0JDv/hg=; b=OFYnLxSLssEXpHivxLEnYRiz2MUYzAd2CJyXfViIY+m0YYwwJs9K+vYUpYUqIGaZId lOePxJCuGaZizTI8iN2P11SlnkIHX7hhxSXWXG/V2Ro8SopurRcl1wayhw1eEHe9lXm6 +fz0MEO93brVSbH70G4/iqpz3Xtp2tRFyB4vh2DtwJ54C1rUTluzB3sGxA5/xUoxFNNQ ahRMam+zQ6L0nj5RnKP8wbUGExMqjgv1VftjqIqQ/92aKxNwBk0+hY2xwwTnkLMSKiHe IeqFw8ds9OvMJ3RXwE/kDBLSpIIBVBegefb3+4dS8zXcm8MPF95WzeJPSEkay+G+Q3w1 nbDw== X-Forwarded-Encrypted: i=1; AHgh+RpCqoWak7MZ5kw356HXUfoTT4EbXVguDUm02vTDRRMAMlOexA+q+XJaQE6hphj5qcuSKrs4JwiN+wnAXAI=@vger.kernel.org X-Gm-Message-State: AOJu0YzRomUhe8fCoLPKC3VqUP+uoqozEZK0t/aEujsgvZZ0TtISJpy8 iRF/Ohhrn3B2NUShnJ7viQ+TEBcpDulQdiclczzBTq1WDULkVDsB+i8SmZh/4ALI4GHeEzoFquQ lsexF1bBoSLRoRY4HsX2Bw5Zq1VHHAakrIgf0Qc5ljXGJ3nFcApwqrGg6VAP2zTLGNropr/R3/J w= X-Gm-Gg: AR+sD107EuWmOA8ToThTGT1gD9/TJv5YPHLYGuBmqEZQu0u/Ih9Vn8pr2Y8sPXyJ9z8 g0G/58g65bQfcpS6wrIkdCpI2HrTv0atE7LU7xhxLNeJoVGroo31lyiqi8ArXaojJt8v61sBIUI cXV9zLDhCQQQGOnEap0nB3VhZFgw/AI6CYtPhHbBDWDexJss0pziGbNLFgg0ySCEKrOBTsEvw0H V9za80YWwzywn8x/bhz9FEIy/WLf8gzu0L66uTiP+EGX7+FKBtNe2eTDzOuiOewdoh6w64mGeD8 FpOqALukATecucKjsjZ7sl5dbeEFMxLncNDrV5ncdesQzc5W9zkkH84FkYDO8+985IMx4aTvZSG DUNfLP87/RLVR3kQx6xu/u94j X-Received: by 2002:a05:620a:708a:b0:92e:5ef1:9072 with SMTP id af79cd13be357-9371e6a9beemr349782385a.2.1787148048889; Wed, 19 Aug 2026 07:00:48 -0700 (PDT) X-Received: by 2002:a05:620a:708a:b0:92e:5ef1:9072 with SMTP id af79cd13be357-9371e6a9beemr349768485a.2.1787148047869; Wed, 19 Aug 2026 07:00:47 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b4788e791dsm533593e87.65.2026.08.19.07.00.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 07:00:46 -0700 (PDT) Message-ID: <09f10e30-f613-4a22-941c-1db63b190186@oss.qualcomm.com> Date: Wed, 19 Aug 2026 16:00:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] spi: qcom-geni: Use GPIO to notify master of SPI target activity To: Praveen Talari , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson Cc: chandana.chiluveru@oss.qualcomm.com, Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260818-use_gpio_to_notify_master_of_spi_target_activity-v3-0-e1c9e0dabbda@oss.qualcomm.com> <20260818-use_gpio_to_notify_master_of_spi_target_activity-v3-2-e1c9e0dabbda@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260818-use_gpio_to_notify_master_of_spi_target_activity-v3-2-e1c9e0dabbda@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDEwOSBTYWx0ZWRfX9a6v3ILjz7Wp 1xr77L2NV+G9cnR99O4LDXANILw/PFM/kUU962DQn37d/esricTudxyx/qitFBmyLD/brQKSfFu Ar4i0L6s9BknsFcZVtLpzSnnupcW211Kz7j0ZkHp4s/hIhWhGcQElJhldAv8fBhE20MrfZ/Mh33 d5GdWiLLKRXrOBVlTpBrTF8nNuIiftUU0nOm8DUIE04amVkx1MqSbGUAhkM8iMPoTMSLrL1Iqo5 i/0Sy3cnkvL/EbuwFwnLlP2ZM+tsFhijJm/g8kSgMnG/qUatQR8MUwWKJPm0yMrLHdvxCU39RfQ ggzM8/nR3dCdvCa+IXu2IP5qn3bjbygwOM/T6GUDz5rp8WZsq1ylXNoO5muazAm0l6CI5/kzs/B 5w4Hq0/JdvqkbLEEcEPYId6l0gtWcA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDEwOSBTYWx0ZWRfXwRNb4oRiyRgh SI20ZD04/znMZ41qrfjmDOgLMfe5EsmTaDwqYPsQXPcTyRKxL6c2kfFOXziLqYL92fsEgBytqdr IFDFvrKv0LGnykIrjP2VUYeJr0jtSyM= X-Proofpoint-GUID: IgqtFPLVPeD7D6T6YmzXrsr5RbDX1eju X-Proofpoint-ORIG-GUID: IgqtFPLVPeD7D6T6YmzXrsr5RbDX1eju X-Authority-Analysis: v=2.4 cv=J+SaKgnS c=1 sm=1 tr=0 ts=6a85b712 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=OIFkiNoqZ7k2w5cL0_IA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_03,2026-08-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190109 On 8/18/26 3:38 PM, Praveen Talari wrote: > When operating in SPI target mode, the GENI controller relies on an > external GPIO to notify the SPI master about the target's active state. > > Add support for an optional ready GPIO that is asserted when a target > transfer begins and deasserted when the transfer completes, is aborted, > or hits a timeout. This allows the target to explicitly signal its > availability to the master and ensures the GPIO is released in all error > and completion paths, preventing the master from observing a stale or > incorrect target-ready indication. [...] > + if (spi->target && mas->target_gpio) > + gpiod_set_value(mas->target_gpio, 0); FWIW it seems like the gpiod APIs can eat nullptrs [...] > @@ -1131,8 +1144,16 @@ static int spi_geni_probe(struct platform_device *pdev) > init_completion(&mas->rx_reset_done); > spin_lock_init(&mas->lock); > > - if (spi->target) > + if (spi->target) { > spi->target_abort = spi_geni_target_abort; > + mas->target_gpio = devm_gpiod_get_index_optional(dev, "ready", 0, > + GPIOD_OUT_LOW); Is there a reason for the get_index_ variant specifically? i.e. why not just devm_gpiod_get_optional()? Konrad