mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "SandeepI" <irlanki.s@samsung.com>
To: "'Jakub Kicinski'" <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <bpf@vger.kernel.org>,
	<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
	<ncardwell@google.com>, <ast@kernel.org>, <daniel@iogearbox.net>,
	<andrii@kernel.org>, <corbet@lwn.net>,
	<linux-kernel@vger.kernel.org>, <lorenzo@google.com>,
	<maze@google.com>, <sporeba@google.com>, <motomuman@google.com>,
	<srihari.k@samsung.com>, <g.pokhra@samsung.com>,
	<r.kumawat@samsung.com>, <raj.kumars@samsung.com>,
	<ts413.lee@samsung.com>,
	"'Daeil	Hwang'" <daeil2.hwang@samsung.com>,
	<ramyashree.s@samsung.com>
Subject: RE: [PATCH net-next v3] tcp: add TCP_ECN and TCP_ECN_OPTION socket options
Date: Wed, 16 Sep 2026 10:47:37 +0530	[thread overview]
Message-ID: <09fd01dd459a$b2b5ec50$1821c4f0$@samsung.com> (raw)
In-Reply-To: <20260915165805.359302fe@kernel.org>

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: 16 September 2026 05:28
> To: Irlanki Sandeep <irlanki.s@samsung.com>
> Cc: netdev@vger.kernel.org; bpf@vger.kernel.org; davem@davemloft.net;
> edumazet@google.com; pabeni@redhat.com; ncardwell@google.com;
> ast@kernel.org; daniel@iogearbox.net; andrii@kernel.org; corbet@lwn.net;
> linux-kernel@vger.kernel.org; lorenzo@google.com; maze@google.com;
> sporeba@google.com; motomuman@google.com; srihari.k@samsung.com;
> g.pokhra@samsung.com; r.kumawat@samsung.com;
> raj.kumars@samsung.com; ts413.lee@samsung.com
> Subject: Re: [PATCH net-next v3] tcp: add TCP_ECN and TCP_ECN_OPTION
> socket options
> 
> On Fri, 11 Sep 2026 14:41:48 +0530 Irlanki Sandeep wrote:
> > Currently, ECN and Accurate ECN (AccECN) configurations in the Linux
> > kernel are controlled globally via the net.ipv4.tcp_ecn and
> > net.ipv4.tcp_ecn_option sysctl variables. This global approach lacks
> > the granularity required for modern multi-application runtimes.
> 
> CI (bpf-ci) reports a failure to build tools/testing/selftests/bpf on all
tested
> toolchains/architectures (x86-64 gcc-15, x86-64 llvm-21, s390x gcc-15,
aarch64
> gcc-15) after this series. The build breaks in
> progs/setget_sockopt.c:
> 
>     progs/setget_sockopt.c:67:11: error: use of undeclared identifier
> 'TCP_ECN'
>             { .opt = TCP_ECN, .new = 3, .expected = 3, .restore = 255, },
>     progs/setget_sockopt.c:68:11: error: use of undeclared identifier
> 'TCP_ECN_OPTION'
>             { .opt = TCP_ECN_OPTION, .new = 2, .expected = 2, .restore =
255, },

Thanks for the report.

TCP_ECN and TCP_ECN_OPTION have been defined in
tools/testing/selftests/bpf/progs/bpf_tracing_net.h to resolve the
compilation failure in progs/setget_sockopt.c.

This has been addressed in v4:
https://lore.kernel.org/all/20260916050255.1379192-1-irlanki.s@samsung.com/

Thanks,
Sandeep.


      reply	other threads:[~2026-09-16  5:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20260911091026epcas5p35873551b66ec0a50e20ada6e26d2b056@epcas5p3.samsung.com>
2026-09-11  9:11 ` Irlanki Sandeep
2026-09-15 23:58   ` Jakub Kicinski
2026-09-16  5:17     ` SandeepI [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='09fd01dd459a$b2b5ec50$1821c4f0$@samsung.com' \
    --to=irlanki.s@samsung.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=daeil2.hwang@samsung.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=g.pokhra@samsung.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@google.com \
    --cc=maze@google.com \
    --cc=motomuman@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=r.kumawat@samsung.com \
    --cc=raj.kumars@samsung.com \
    --cc=ramyashree.s@samsung.com \
    --cc=sporeba@google.com \
    --cc=srihari.k@samsung.com \
    --cc=ts413.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®