From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org,
dianders@chromium.org, swboyd@chromium.org,
judyhsiao@chromium.org, konrad.dybcio@linaro.org
Subject: Re: [PATCH 4/7] arm64: dts: qcom: sc7280: audioreach: Update lpasscc reg property
Date: Fri, 23 Dec 2022 10:13:21 +0100 [thread overview]
Message-ID: <09fd48bd-7f92-b0e0-cb2a-ab2fb6ece868@linaro.org> (raw)
In-Reply-To: <1671702170-24781-5-git-send-email-quic_srivasam@quicinc.com>
On 22/12/2022 10:42, Srinivasa Rao Mandadapu wrote:
> Update lpasscc register mapping for avoiding memory regions conflict with
> ADSP pil node.
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Tested-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi
> index 0ce8755..a750f05 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audioreach-wcd9385.dtsi
> @@ -111,6 +111,14 @@
> };
> };
>
> +&lpasscc {
> + reg = <0 0x03c04000 0 0x4>,
> + <0 0x032a9000 0 0x1000>;
Misaligned.
> + reg-names = "top_cc", "reset-cgcr";
I have doubts this was tested... git grep shows 0 answers.
> + #reset-cells = <1>;
Why all these are not part of SoC DTSI?
> + status = "okay";
Why?
> +};
> +
> &soc {
> qcom,lpass@3000000 {
> compatible = "qcom,sc7280-adsp-pil";
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-23 9:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-22 9:42 [PATCH 0/7] Add SC7280 audioreach device tree nodes Srinivasa Rao Mandadapu
2022-12-22 9:42 ` [PATCH 1/7] arm64: dts: qcom: sc7280: Extract audio nodes from common idp dtsi file Srinivasa Rao Mandadapu
2022-12-23 9:05 ` Krzysztof Kozlowski
2022-12-22 9:42 ` [PATCH 2/7] arm64: dts: qcom: sc7280: audioreach: Add sound node Srinivasa Rao Mandadapu
2022-12-23 8:36 ` kernel test robot
2022-12-23 9:08 ` Krzysztof Kozlowski
2022-12-22 9:42 ` [PATCH 3/7] arm64: dts: qcom: sc7280: audioreach: Add lpass pil node Srinivasa Rao Mandadapu
2022-12-23 9:12 ` Krzysztof Kozlowski
2022-12-22 9:42 ` [PATCH 4/7] arm64: dts: qcom: sc7280: audioreach: Update lpasscc reg property Srinivasa Rao Mandadapu
2022-12-23 9:13 ` Krzysztof Kozlowski [this message]
2022-12-22 9:42 ` [PATCH 5/7] arm64: dts: qcom: sc7280: audioreach: Add CGCR reset property Srinivasa Rao Mandadapu
2022-12-23 9:14 ` Krzysztof Kozlowski
2022-12-22 9:42 ` [PATCH 6/7] arm64: dts: qcom: sc7280: audioreach: Update VA/RX/TX macro clock nodes Srinivasa Rao Mandadapu
2022-12-23 9:16 ` Krzysztof Kozlowski
2022-12-22 9:42 ` [PATCH 7/7] arm64: dts: qcom: sc7280: audioreach: Disable legacy path " Srinivasa Rao Mandadapu
2022-12-23 9:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09fd48bd-7f92-b0e0-cb2a-ab2fb6ece868@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rohkumar@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®